From: Andreas Enge <andreas@enge.fr>
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add MPD
Date: Mon, 24 Feb 2014 22:20:54 +0100 [thread overview]
Message-ID: <20140224212054.GA8987@debian> (raw)
In-Reply-To: <87txbpjte8.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Hello,
On Sun, Feb 23, 2014 at 06:34:07PM -0500, David Thompson wrote:
> Attached is a patch with basic package recipes for libmpdclient and MPD.
> MPD has a lot of optional dependencies and I've included as inputs all
> of the ones that Guix currently has packages for. libmpdclient requires
> doxygen in order to generate documentation and since Guix does not have
> a package for this yet I've disabled the documentation for now.
the approach looks good. I think I would prepare two separate patches,
adding the packages one by one. And I would prepend the comment "Needs
doxygen" by "FIXME", so we know there is a TODO item.
If you feel like it, you can also add in comment a list of all the optional
inputs, so that it will be easier to add them once they are available (see
ffmpeg for an example).
Andreas
prev parent reply other threads:[~2014-02-24 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 23:34 [PATCH] Add MPD David Thompson
2014-02-24 21:20 ` Andreas Enge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224212054.GA8987@debian \
--to=andreas@enge.fr \
--cc=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.