From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: Add miniupnpc. Date: Mon, 24 Feb 2014 22:15:30 +0100 Message-ID: <20140224211530.GA8805@debian> References: <1393061825-24964-1-git-send-email-sreeharsha@totakura.in> <1393061825-24964-2-git-send-email-sreeharsha@totakura.in> <20140223094324.GA26058@debian> <530B861B.3080100@totakura.in> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WI2sq-0002eW-0z for guix-devel@gnu.org; Mon, 24 Feb 2014 16:16:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WI2sh-0002nV-OQ for guix-devel@gnu.org; Mon, 24 Feb 2014 16:16:15 -0500 Received: from moutng.kundenserver.de ([212.227.17.13]:55883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WI2sh-0002n7-Eg for guix-devel@gnu.org; Mon, 24 Feb 2014 16:16:07 -0500 Content-Disposition: inline In-Reply-To: <530B861B.3080100@totakura.in> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Sree Harsha Totakura Cc: guix-devel@gnu.org On Mon, Feb 24, 2014 at 06:49:15PM +0100, Sree Harsha Totakura wrote: > Ah, I think I answered with a 'y' when git complained that it is going > to send the message as UTF-8. I guess I didn't read the message > properly; I guess it had asked me that character encoding the patch is in. ;-) > I fixed these in the following patch. Thanks! There was a bit of white space at line endings that I removed. Your source url "http://miniupnp.tuxfamily.org/files/download.php?file=miniupnpc-" version ".tar.gz")) resulted in something like The following derivations would be built: /nix/store/8d3ih5jb6s9lpldsninz6iy0pq6ph4k9-miniupnpc-1.9.drv /nix/store/rgaz10pi27qwp4fwflfp9ajypsppwkx7-download.php?file=miniupnpc-1.9.tar.gz.drv Rather ugly, although I suppose it works. I just guessed the file location and dropped "download.php?file=", and it works like this. I will push it now. Andreas