From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH] gnu: xterm: Accept $SHELL even if not in /etc/shells Date: Thu, 13 Feb 2014 09:07:20 +0100 Message-ID: <20140213080720.GA28268@jocasta.intra> References: <87zjlvh276.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDrKY-0005ey-Sp for guix-devel@gnu.org; Thu, 13 Feb 2014 03:07:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDrKU-0001J0-F3 for guix-devel@gnu.org; Thu, 13 Feb 2014 03:07:34 -0500 Received: from de.cellform.com ([88.217.224.109]:44639 helo=jocasta.intra) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDrKU-0001HA-1p for guix-devel@gnu.org; Thu, 13 Feb 2014 03:07:30 -0500 Content-Disposition: inline In-Reply-To: <87zjlvh276.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel@gnu.org --jI8keyz6grp/JLjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 13, 2014 at 03:00:29AM -0500, Mark H Weaver wrote: This patch makes xterm honor $SHELL (or the shell in the user's passwo= rd entry) even if it's not in /etc/shells. WDYT? =20 It sounds like a good idea to me. /etc/shells is supposed to be only a whi= telist of those shells which may be used for login. Not an exhaustive list of shells= which may be used at all. However, I'm wondering if we are forking too many upstream packages. We sh= ould only patch software in order to allow it to build/install. If we want to c= hange the behaviour like here, that should be sent to upstream for their next rel= ease. If they refuse the patch, then of course you can start your own weavershell= fork... J' --=20 PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlL8fTgACgkQimdxnC3oJ7MqWwCeJ7FkDnt4hyqn7w0ZtXy1akSj hFAAnR60qOopuVzup9lTcLbdIHVh2tTe =4PbF -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh--