From: John Darrington <john@darrington.wattle.id.au>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: xterm: Accept $SHELL even if not in /etc/shells
Date: Thu, 13 Feb 2014 09:07:20 +0100 [thread overview]
Message-ID: <20140213080720.GA28268@jocasta.intra> (raw)
In-Reply-To: <87zjlvh276.fsf@netris.org>
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
On Thu, Feb 13, 2014 at 03:00:29AM -0500, Mark H Weaver wrote:
This patch makes xterm honor $SHELL (or the shell in the user's password
entry) even if it's not in /etc/shells. WDYT?
It sounds like a good idea to me. /etc/shells is supposed to be only a whitelist of
those shells which may be used for login. Not an exhaustive list of shells which
may be used at all.
However, I'm wondering if we are forking too many upstream packages. We should
only patch software in order to allow it to build/install. If we want to change
the behaviour like here, that should be sent to upstream for their next release.
If they refuse the patch, then of course you can start your own weavershell fork...
J'
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-02-13 8:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 8:00 [PATCH] gnu: xterm: Accept $SHELL even if not in /etc/shells Mark H Weaver
2014-02-13 8:07 ` John Darrington [this message]
2014-02-13 8:47 ` Mark H Weaver
2014-02-13 11:06 ` John Darrington
2014-02-13 13:12 ` Ludovic Courtès
2014-02-13 16:29 ` Mark H Weaver
2014-02-14 10:59 ` Ludovic Courtès
2014-02-14 12:32 ` John Darrington
2014-02-14 13:30 ` Alex Sassmannshausen
2014-02-14 16:59 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213080720.GA28268@jocasta.intra \
--to=john@darrington.wattle.id.au \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.