From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: luajit recipe Date: Wed, 5 Feb 2014 00:27:30 +0100 Message-ID: <20140204232730.GA6428@debian> References: <87iosulff2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WApUp-0001Se-6z for guix-devel@gnu.org; Tue, 04 Feb 2014 18:33:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WApUi-0000je-KY for guix-devel@gnu.org; Tue, 04 Feb 2014 18:33:39 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:51191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WApUi-0000ig-B3 for guix-devel@gnu.org; Tue, 04 Feb 2014 18:33:32 -0500 Content-Disposition: inline In-Reply-To: <87iosulff2.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Raimon Grau Cc: guix-devel@gnu.org Hello, On Tue, Feb 04, 2014 at 10:46:25PM +0100, Raimon Grau wrote: > Here's the luajit recipe. I'd appreciate any comments you have on that > (It's my first (hopefully not the last) contribution to this project). excellent! Just a few very quick comments: > (define-module (gnu packages luajit) If you add a module/file, you also need to "register" it in gnu-system.am. Here, there is already a module lua in the file lua.scm. It would probably make sense to add your package there. > (description > "LuaJIT is a Just-In-Time Compiler (JIT) for the Lua > programming language. Lua is a powerful, dynamic and light-weight programming > language. It may be embedded or used as a general-purpose, stand-alone > language. > > LuaJIT is Copyright © 2005-2014 Mike Pall") You should write two spaces after the "." at the end of a sentence. I would drop the second paragraph (which is also likely to change with newer versions). I did not check anything else. Thanks for contributing! Andreas