From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: PATCH: Detect missing pkg.m4 Date: Sat, 23 Nov 2013 14:11:42 +0100 Message-ID: <20131123131142.GA25897@jocasta.intra> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KFztAG8eRSV9hGtP" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkD01-0006Bn-FZ for guix-devel@gnu.org; Sat, 23 Nov 2013 08:11:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkCzx-0006Vd-Fi for guix-devel@gnu.org; Sat, 23 Nov 2013 08:11:49 -0500 Received: from de.cellform.com ([88.217.224.109]:45010 helo=jocasta.intra) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkCzx-0006VL-21 for guix-devel@gnu.org; Sat, 23 Nov 2013 08:11:45 -0500 Received: from jocasta.intra (localhost [127.0.0.1]) by jocasta.intra (8.14.4/8.14.4/Debian-4) with ESMTP id rANDBgVh025920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 23 Nov 2013 14:11:42 +0100 Received: (from john@localhost) by jocasta.intra (8.14.4/8.14.4/Submit) id rANDBgiG025919 for guix-devel@gnu.org; Sat, 23 Nov 2013 14:11:42 +0100 Content-Disposition: inline List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org --KFztAG8eRSV9hGtP Content-Type: multipart/mixed; boundary="UlVJffcvxoiEqYs2" Content-Disposition: inline --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable configure.ac depends on pkg-config=20 I try to avoid pkg-config if at all possible. It is a source of constant a= ggrevation. However, if it is absolutely unavoidable I recommend the attached patch. I= t detects pkg-config problems early in the bootstrap process, rather than delaying th= eir discovery till halfway through the build. J' --=20 PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --UlVJffcvxoiEqYs2 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-configure.ac-Added-macros-to-help-detect-missing-pkg.patch" Content-Transfer-Encoding: quoted-printable =46rom ed23edf3a6020c87af7030a722a4705af10e2939 Mon Sep 17 00:00:00 2001 =46rom: John Darrington Date: Sat, 23 Nov 2013 13:43:33 +0100 Subject: [PATCH] configure.ac: Added macros to help detect missing pkg.m4 --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 7a67efa..2590435 100644 --- a/configure.ac +++ b/configure.ac @@ -41,6 +41,9 @@ AC_ARG_ENABLE([daemon], guix_localstatedir=3D"`eval echo $localstatedir | sed -e "s|NONE|/usr/loca= l|g"`" AC_SUBST([guix_localstatedir]) =20 +PKG_PROG_PKG_CONFIG +m4_pattern_forbid([PKG_CHECK_MODULES]) + PKG_CHECK_MODULES([GUILE], [guile-2.0 >=3D 2.0.5]) AC_PATH_PROG([GUILE], [guile]) AC_PATH_PROG([GUILD], [guild]) --=20 1.7.10.4 --UlVJffcvxoiEqYs2-- --KFztAG8eRSV9hGtP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlKQqY4ACgkQimdxnC3oJ7O/+gCePkcTzE2K+gNfAA0z/KDG/gtS kZcAnRDQLZaXwiRbhG/8nM2yc53kC2Cl =L6hA -----END PGP SIGNATURE----- --KFztAG8eRSV9hGtP--