From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH] gnu: Add libmikmod
Date: Fri, 25 Oct 2013 22:39:47 +0200
Message-ID: <20131025203947.GA20109@debian>
References: <5265C032.6000005@worcester.edu> <20131023191910.GB5494@debian>
	<52684A39.10205@worcester.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53223)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1VZoAq-00067G-Fr
	for guix-devel@gnu.org; Fri, 25 Oct 2013 16:40:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1VZoAj-0005Ug-4N
	for guix-devel@gnu.org; Fri, 25 Oct 2013 16:40:00 -0400
Received: from moutng.kundenserver.de ([212.227.17.9]:60525)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1VZoAi-0005UE-S5
	for guix-devel@gnu.org; Fri, 25 Oct 2013 16:39:53 -0400
Content-Disposition: inline
In-Reply-To: <52684A39.10205@worcester.edu>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

On Wed, Oct 23, 2013 at 06:14:17PM -0400, David Thompson wrote:
> I will, but libmikmod is a library that is not directly associated
> with SDL, so I made a separate module.

Well, I am a bit wary about creating lots of files for small packages.
If it occurs essentially as a dependency of sdl, I would be happy to
package it inside the sdl module. But we do not have a coherent policy
on packages vs. modules.

Concerning style:
In 'uri', the argument 'version' to 'string-append' should be aligned
with the first argument of the line above, that is, "mirror...".
I am not sure what to do about the synopsis spanning two lines; I think
we do not have a strict 80 column policy, so it could be put into one
longer line.
After copyright, I have '??' instead of '©'; maybe the file is not
in utf-8 format?

In any case, it compiles well, and after addressing the small stylistic
comments, I support pushing it.

Andreas