all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add libmikmod
Date: Fri, 25 Oct 2013 22:39:47 +0200	[thread overview]
Message-ID: <20131025203947.GA20109@debian> (raw)
In-Reply-To: <52684A39.10205@worcester.edu>

On Wed, Oct 23, 2013 at 06:14:17PM -0400, David Thompson wrote:
> I will, but libmikmod is a library that is not directly associated
> with SDL, so I made a separate module.

Well, I am a bit wary about creating lots of files for small packages.
If it occurs essentially as a dependency of sdl, I would be happy to
package it inside the sdl module. But we do not have a coherent policy
on packages vs. modules.

Concerning style:
In 'uri', the argument 'version' to 'string-append' should be aligned
with the first argument of the line above, that is, "mirror...".
I am not sure what to do about the synopsis spanning two lines; I think
we do not have a strict 80 column policy, so it could be put into one
longer line.
After copyright, I have '??' instead of '©'; maybe the file is not
in utf-8 format?

In any case, it compiles well, and after addressing the small stylistic
comments, I support pushing it.

Andreas

  reply	other threads:[~2013-10-25 20:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22  0:00 [PATCH] gnu: Add libmikmod David Thompson
2013-10-23 19:19 ` Andreas Enge
2013-10-23 22:14   ` David Thompson
2013-10-25 20:39     ` Andreas Enge [this message]
2013-10-25 23:49       ` David Thompson
2013-10-26 12:18         ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131025203947.GA20109@debian \
    --to=andreas@enge.fr \
    --cc=dthompson2@worcester.edu \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.