From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: Python-build-system does not honour phases
Date: Tue, 10 Sep 2013 20:31:00 +0200
Message-ID: <20130910183100.GA6819@debian>
References: <20130907222607.GA28990@debian> <87hadtfzk4.fsf@gnu.org>
	<20130910082655.GA8621@debian> <87txhsbma9.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46246)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1VJSid-00016G-3v
	for guix-devel@gnu.org; Tue, 10 Sep 2013 14:31:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1VJSiV-0006vn-Me
	for guix-devel@gnu.org; Tue, 10 Sep 2013 14:31:19 -0400
Content-Disposition: inline
In-Reply-To: <87txhsbma9.fsf@gnu.org>
List-Id: <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?iso-8859-15?Q?Court=E8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On Tue, Sep 10, 2013 at 07:48:30PM +0200, Ludovic Courtès wrote:
> You’re mixing different things: the line above is on the host side,
> whereas the patch I proposed changes the modules imported on the build
> side.

Okay, I get it!

> Can you try this patch to check the value of ‘phases’?

Without your previous patch, I get the following:

;;; (the-python-phases ((set-paths . #<procedure set-paths (#:key target inputs native-inputs search-paths native-search-paths)>) (unpack . #<procedure unpack (#:key source)>) (patch . #<procedure patch (#:key patches patch-flags)>) (patch-source-shebangs . #<procedure patch-source-shebangs (#:key source)>) (configure . #<procedure configure (#:key target native-inputs inputs outputs configure-flags out-of-source?)>) (patch-generated-file-shebangs . #<procedure patch-generated-file-shebangs rest>) (build . #<procedure build (#:key make-flags parallel-build?)>) (check . #<procedure check (#:key target make-flags tests? test-target parallel-tests?)>) (install . #<procedure 1c90070 at ice-9/eval.scm:264:7 %args>) (patch-shebangs . #<procedure patch-shebangs (#:key outputs patch-shebangs?)>) (
 strip . #<procedure strip (#:key target outputs strip-binaries? strip-command objcopy-command strip-flags strip-directories)>)))
WARNING: (guile-user): `%standard-phases' imported from both (guix build python-build-system) and (guix build gnu-build-system)


After applying your previous patch, I get this:

;;; (the-python-phases ((set-paths . #<procedure set-paths (#:key target inputs native-inputs search-paths native-search-paths)>) (unpack . #<procedure unpack (#:key source)>) (patch . #<procedure patch (#:key patches patch-flags)>) (patch-source-shebangs . #<procedure patch-source-shebangs (#:key source)>) (patch-generated-file-shebangs . #<procedure patch-generated-file-shebangs rest>) (build . #<procedure build empty>) (check . #<procedure check (#:key tests? test-target)>) (install . #<procedure b92230 at ice-9/eval.scm:264:7 %args>) (wrap . #<procedure wrap (#:key inputs outputs)>) (patch-shebangs . #<procedure patch-shebangs (#:key outputs patch-shebangs?)>) (strip . #<procedure strip (#:key target outputs strip-binaries? strip-command objcopy-command strip-flags strip-directories)>)
 ))


So indeed, your patch solves the confusion!

Thanks, I will push it then.

Andreas