* [PATCH] gnu: add dependencies to poppler.
@ 2013-03-24 20:08 Cyril Roelandt
2013-03-25 10:55 ` Ludovic Courtès
2013-03-28 19:20 ` Andreas Enge
0 siblings, 2 replies; 6+ messages in thread
From: Cyril Roelandt @ 2013-03-24 20:08 UTC (permalink / raw)
To: bug-guix
Add libpng and zlib to the inputs.
---
Hello!
This patch is quite simple. It adds both libpng (which was already available
in Guix) and zlib (which has to be explicitely enabled) to poppler. Note that
zlib is not enabled by default, even if it is found on the system, because it
is "not safe" according to the poppler developers. Andreas, do you know why ?
Maybe we should remove it from the dependencies.
I also listed the dependencies that are not yet satisfied. I think I will take
care of libopenjpeg soon, but it requires cmake, and I'd rather write a cmake
build system first.
Cyril.
gnu/packages/pdf.scm | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 5a9d513..a172414 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -25,6 +25,7 @@
#:use-module (gnu packages compression)
#:use-module (gnu packages fontutils)
#:use-module (gnu packages libjpeg)
+ #:use-module (gnu packages libpng)
#:use-module (gnu packages libtiff)
#:use-module (gnu packages pkg-config))
@@ -40,15 +41,25 @@
"1rmrspavldlpqi6g76fijcmshy80m0kxd01nc1dmy4id3h4las44"))))
(build-system gnu-build-system)
;; FIXME: more dependencies could be added
+ ;; cairo output: no (requires cairo >= 1.10.0)
+ ;; qt4 wrapper: no
+ ;; glib wrapper: no (requires cairo output)
+ ;; introspection: no
+ ;; use gtk-doc: no
+ ;; use libcurl: no
+ ;; use libopenjpeg: no
(inputs `(("fontconfig" ,fontconfig)
("freetype" ,freetype)
("libjpeg-8" ,libjpeg-8)
+ ("libpng" ,libpng)
("libtiff" ,libtiff)
("pkg-config" ,pkg-config)
("zlib" ,zlib)))
(arguments
`(#:tests? #f ; no test data provided with the tarball
- #:configure-flags '("--enable-xpdf-headers"))) ; to install header files
+ #:configure-flags
+ '("--enable-xpdf-headers" ; to install header files
+ "--enable-zlib")))
(synopsis "Poppler, a pdf rendering library")
(description
"Poppler is a PDF rendering library based on the xpdf-3.0 code base.")
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: add dependencies to poppler.
2013-03-24 20:08 [PATCH] gnu: add dependencies to poppler Cyril Roelandt
@ 2013-03-25 10:55 ` Ludovic Courtès
2013-03-28 19:20 ` Andreas Enge
1 sibling, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2013-03-25 10:55 UTC (permalink / raw)
To: Cyril Roelandt; +Cc: bug-guix
Cyril Roelandt <tipecaml@gmail.com> skribis:
> Add libpng and zlib to the inputs.
Looks good to me.
> This patch is quite simple. It adds both libpng (which was already available
> in Guix) and zlib (which has to be explicitely enabled) to poppler. Note that
> zlib is not enabled by default, even if it is found on the system, because it
> is "not safe" according to the poppler developers. Andreas, do you know why ?
> Maybe we should remove it from the dependencies.
Indeed, it would be good to see what’s meant by “not safe”.
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: add dependencies to poppler.
2013-03-24 20:08 [PATCH] gnu: add dependencies to poppler Cyril Roelandt
2013-03-25 10:55 ` Ludovic Courtès
@ 2013-03-28 19:20 ` Andreas Enge
2013-03-28 20:39 ` Cyril Roelandt
1 sibling, 1 reply; 6+ messages in thread
From: Andreas Enge @ 2013-03-28 19:20 UTC (permalink / raw)
To: bug-guix
Am Sonntag, 24. März 2013 schrieb Cyril Roelandt:
> Note that zlib is not enabled by default, even if it is found
> on the system, because it is "not safe" according to the poppler
> developers. Andreas, do you know why ? Maybe we should remove it from
> the dependencies.
There is some discussion at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=526864
but it is not very conclusive. I would suggest to go ahead and to enable
the switch for zlib.
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-28 22:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-24 20:08 [PATCH] gnu: add dependencies to poppler Cyril Roelandt
2013-03-25 10:55 ` Ludovic Courtès
2013-03-28 19:20 ` Andreas Enge
2013-03-28 20:39 ` Cyril Roelandt
2013-03-28 21:26 ` Andreas Enge
2013-03-28 22:15 ` Cyril Roelandt
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.