From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: #!/usr/bin/env perl
Date: Mon, 25 Feb 2013 10:43:12 +0100
Message-ID: <201302251043.12376.andreas@enge.fr>
References: <201301262131.48844.andreas@enge.fr>
	<201302231721.26689.andreas@enge.fr> <87k3px5cri.fsf@tines.lan>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:40659)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1U9uay-0000GY-DQ
	for bug-guix@gnu.org; Mon, 25 Feb 2013 04:43:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1U9uar-0001qJ-Cn
	for bug-guix@gnu.org; Mon, 25 Feb 2013 04:43:40 -0500
Received: from moutng.kundenserver.de ([212.227.126.171]:65243)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1U9uar-0001qB-30
	for bug-guix@gnu.org; Mon, 25 Feb 2013 04:43:33 -0500
In-Reply-To: <87k3px5cri.fsf@tines.lan>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: bug-guix@gnu.org

Am Montag, 25. Februar 2013 schrieb Mark H Weaver:
> Andreas Enge <andreas@enge.fr> writes:
> > (has-env (string-suffix? "/env" interp))
> 
> I think we might want to make this test more restrictive.  I'm looking
> at a package (guile-figl) that includes an 'env' script in its build
> directory, analogous to 'pre-inst-env' in Guix.  This makes me worry
> that the test above will have false positives.
> 
> In practice, the path used is (almost?) always "/usr/bin/env".
> I suspect it would be safer to check for that exact string.

I also wondered whether we should do this. Do you have a concrete example 
where the current test fails? Notice that the suffix is only part of the 
test; currently, we patch files that start with
   [[:blank:]]*#![[:graph:]]*/env
Unless a problem manifests itself, I would not change that behaviour.

Andreas