all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Mark H Weaver <mhw@netris.org>
Cc: bug-guix@gnu.org
Subject: Re: #!/usr/bin/env perl
Date: Mon, 25 Feb 2013 10:43:12 +0100	[thread overview]
Message-ID: <201302251043.12376.andreas@enge.fr> (raw)
In-Reply-To: <87k3px5cri.fsf@tines.lan>

Am Montag, 25. Februar 2013 schrieb Mark H Weaver:
> Andreas Enge <andreas@enge.fr> writes:
> > (has-env (string-suffix? "/env" interp))
> 
> I think we might want to make this test more restrictive.  I'm looking
> at a package (guile-figl) that includes an 'env' script in its build
> directory, analogous to 'pre-inst-env' in Guix.  This makes me worry
> that the test above will have false positives.
> 
> In practice, the path used is (almost?) always "/usr/bin/env".
> I suspect it would be safer to check for that exact string.

I also wondered whether we should do this. Do you have a concrete example 
where the current test fails? Notice that the suffix is only part of the 
test; currently, we patch files that start with
   [[:blank:]]*#![[:graph:]]*/env
Unless a problem manifests itself, I would not change that behaviour.

Andreas

  reply	other threads:[~2013-02-25  9:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-26 20:31 #!/usr/bin/env perl Andreas Enge
2013-01-26 21:09 ` Ludovic Courtès
2013-02-22 22:13   ` Andreas Enge
2013-02-22 23:26     ` Ludovic Courtès
2013-02-23  0:03       ` Andreas Enge
2013-02-23 15:15         ` Ludovic Courtès
2013-02-23 16:21     ` Andreas Enge
2013-02-23 17:31       ` Ludovic Courtès
2013-02-23 17:48         ` Andreas Enge
2013-02-23 18:45           ` Ludovic Courtès
2013-02-23 18:58             ` Andreas Enge
2013-02-23 19:14               ` Ludovic Courtès
2013-02-23 19:19                 ` Andreas Enge
2013-02-25  2:49       ` Mark H Weaver
2013-02-25  9:43         ` Andreas Enge [this message]
2013-02-25 15:40           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201302251043.12376.andreas@enge.fr \
    --to=andreas@enge.fr \
    --cc=bug-guix@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.