From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: Add Libogg. Date: Fri, 18 Jan 2013 11:04:27 +0100 Message-ID: <201301181104.27715.andreas@enge.fr> References: <874nifuuad.fsf@karetnikov.org> Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_r4R+Qnf+pXQ2wkl" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:59890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tw8oP-00063J-Kx for bug-guix@gnu.org; Fri, 18 Jan 2013 05:04:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tw8oK-00026c-GP for bug-guix@gnu.org; Fri, 18 Jan 2013 05:04:37 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:60313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tw8oK-00026O-32 for bug-guix@gnu.org; Fri, 18 Jan 2013 05:04:32 -0500 In-Reply-To: <874nifuuad.fsf@karetnikov.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: bug-guix@gnu.org --Boundary-00=_r4R+Qnf+pXQ2wkl Content-Type: multipart/alternative; boundary="Boundary-01=_r4R+QCU2ZaeG1NA" Content-Transfer-Encoding: 7bit --Boundary-01=_r4R+QCU2ZaeG1NA Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Hello, I prepared the same, but did not push it yet. Actually, I wanted to package the vorbis-tools, and got sucked into a dependency chain that started with curl and currently ends with ghostscript... > + (inputs `(("xz" ,xz))) You do not need this; it is only used for unpacking, which is handled automatically. Concerning the license, I have (license (bsd-style "file://COPYING" "See COPYING in the distribution.")) instead of + (license bsd-3))) My reason was that the license contained a line "Neither the name of the Xiph.org Foundation nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission." So this is not precisely the original BSD-3 license, which does not mention Xiph. What is our policy here? So I would suggest the following more comprehensive patch. Andreas --Boundary-01=_r4R+QCU2ZaeG1NA Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

Hello,

I prepared the same, but did not push it yet. Actually, I wanted to package the vorbis-tools, and got sucked into a dependency chain that started with curl and currently ends with ghostscript...

> + (inputs `(("xz" ,xz)))

You do not need this; it is only used for unpacking, which is handled automatically.

Concerning the license, I have

(license (bsd-style "file://COPYING"

"See COPYING in the distribution."))

instead of

+ (license bsd-3)))

My reason was that the license contained a line

"Neither the name of the Xiph.org Foundation nor the names of its

contributors may be used to endorse or promote products derived from

this software without specific prior written permission."

So this is not precisely the original BSD-3 license, which does not mention Xiph.

What is our policy here?

So I would suggest the following more comprehensive patch.

Andreas

--Boundary-01=_r4R+QCU2ZaeG1NA-- --Boundary-00=_r4R+Qnf+pXQ2wkl Content-Type: text/x-patch; charset="UTF-8"; name="0001-gnu-Add-libogg-libvorbis-and-vorbis-tools.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gnu-Add-libogg-libvorbis-and-vorbis-tools.patch" =46rom 657506537c1167d97b43ce8a69a2bf74b06e33f4 Mon Sep 17 00:00:00 2001 =46rom: Andreas Enge Date: Fri, 18 Jan 2013 11:02:26 +0100 Subject: [PATCH] gnu: Add libogg, libvorbis and vorbis-tools. * gnu/packages/oggvorbis.scm: New file. * Makefile.am (MODULES): Add it. =2D-- Makefile.am | 1 + gnu/packages/oggvorbis.scm | 108 ++++++++++++++++++++++++++++++++++++++++= ++++ 2 files changed, 109 insertions(+) create mode 100644 gnu/packages/oggvorbis.scm diff --git a/Makefile.am b/Makefile.am index 86f9651..5c58131 100644 =2D-- a/Makefile.am +++ b/Makefile.am @@ -102,6 +102,7 @@ MODULES =3D \ gnu/packages/ncurses.scm \ gnu/packages/nettle.scm \ gnu/packages/openssl.scm \ + gnu/packages/oggvorbis.scm \ gnu/packages/perl.scm \ gnu/packages/pkg-config.scm \ gnu/packages/pth.scm \ diff --git a/gnu/packages/oggvorbis.scm b/gnu/packages/oggvorbis.scm new file mode 100644 index 0000000..d92dfc3 =2D-- /dev/null +++ b/gnu/packages/oggvorbis.scm @@ -0,0 +1,108 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright =C2=A9 2013 Andreas Enge +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu packages oggvorbis) + #:use-module (gnu packages) + #:use-module (guix licenses) + #:use-module (guix packages) + #:use-module (guix download) + #:use-module (guix build-system gnu)) + +(define-public libogg + (package + (name "libogg") + (version "1.3.0") + (source (origin + (method url-fetch) + (uri (string-append "http://downloads.xiph.org/releases/ogg/li= bogg-" + version ".tar.xz")) + (sha256 + (base32 + "0jy79ffkl34vycnwfsj4svqsdg1lwy2l1rr49y8r4d44kh12a5r3")))) + (build-system gnu-build-system) + (synopsis "libogg, a library for manipulating the ogg multimedia format= ") + (description + "The libogg library allows to manipulate the ogg multimedia container +format, which encapsulates raw compressed data and allows the interleaving= of +audio and video data. In addition to encapsulation and interleaving of +multiple data streams, ogg provides packet framing, error detection, and +periodic timestamps for seeking.") + (license (bsd-style "file://COPYING" + "See COPYING in the distribution.")) + (home-page "http://xiph.org/ogg/"))) + +(define-public libvorbis + (package + (name "libvorbis") + (version "1.3.3") + (source (origin + (method url-fetch) + (uri (string-append "http://downloads.xiph.org/releases/vorbis= /libvorbis-" + version ".tar.xz")) + (sha256 + (base32 + "1gby6hapz9njx4l9g0pndyk4q83z5fgrgc30mfwfgx7bllspsk43")))) + (build-system gnu-build-system) + (inputs `(("libogg" ,libogg))) + (arguments `(#:configure-flags '("LDFLAGS=3D-lm"))) + (synopsis "libvorbis, a library implementing the vorbis audio format") + (description + "The libvorbis library implements the ogg vorbis audio format, +a fully open, non-proprietary, patent-and-royalty-free, general-purpose +compressed audio format for mid to high quality (8kHz-48.0kHz, 16+ bit, +polyphonic) audio and music at fixed and variable bitrates from 16 to +128 kbps/channel.") + (license (bsd-style "file://COPYING" + "See COPYING in the distribution.")) + (home-page "http://xiph.org/vorbis/"))) + +(define-public vorbis-tools + (package + (name "vorbis-tools") + (version "1.4.0") + (source (origin + (method url-fetch) + (uri (string-append "http://downloads.xiph.org/releases/vorbis= /vorbis-tools-" + version ".tar.gz")) + (sha256 + (base32 + "1g12bnh5ah08v529y72kfdz5lhvy75iaz7f9jskyby23m9dkk2d3")))) + (build-system gnu-build-system) + (inputs `(("libogg" ,libogg) + ("libvorbis" ,libvorbis))) +;; FIXME: Add more inputs, see the documentation: +;; All of the tools require libogg and libvorbis to be installed (along +;; with the header files). Additionally, ogg123 requires libao, libcurl, +;; and a POSIX-compatible thread library. Ogg123 can optionally compiled +;; to use libFLAC, and libspeex. Oggenc can be optionally compiled with +;; libFLAC, and libkate. The libraries libogg, libvorbis, and libao are +;; all available at +;; http://www.vorbis.com/download.psp + (synopsis "ogg vorbis tools") + (description + "Ogg vorbis is a non-proprietary, patent-and-royalty-free, +general-purpose compressed audio format. + +The package vorbis-tools contains +ogg123, an ogg vorbis command line audio player; +oggenc, the ogg vorbis encoder; +oggdec, a simple, portable command line decoder (to wav and raw); +ogginfo, to obtain information (tags, bitrate, length, etc.) about + an ogg vorbis file.") + (license gpl2) + (home-page "http://xiph.org/vorbis/"))) =2D-=20 1.7.10.4 --Boundary-00=_r4R+Qnf+pXQ2wkl--