From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] distro: Add MIT Kerberos 5. Date: Sun, 30 Dec 2012 14:10:39 +0100 Message-ID: <201212301410.39301.andreas@enge.fr> References: <201212300009.42579.andreas@enge.fr> <87sj6oqslj.fsf@karetnikov.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="Boundary-01=_P1D4QeAr42+VLtK" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:56385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TpIfB-0001Og-4O for bug-guix@gnu.org; Sun, 30 Dec 2012 08:10:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TpIf7-0004Af-HW for bug-guix@gnu.org; Sun, 30 Dec 2012 08:10:49 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:58634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TpIf7-00049u-1v for bug-guix@gnu.org; Sun, 30 Dec 2012 08:10:45 -0500 In-Reply-To: <87sj6oqslj.fsf@karetnikov.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: Nikita Karetnikov Cc: bug-guix@gnu.org --Boundary-01=_P1D4QeAr42+VLtK Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Am Sonntag, 30. Dezember 2012 schrieb Nikita Karetnikov: > > + `(#:tests? #f > Ludo told me some time ago that it's necessary to write a comment when > you disable tests. It should explain why they were disabled. This is a mistake, thanks for spotting it! Actually, the tests do fail with: make[2]: Entering directory `/tmp/nix-build-mit- krb5-1.11.drv-0/krb5-1.11/src/tests/resolve' LD_LIBRARY_PATH=`echo -L../../lib | sed -e "s/-L//g" -e "s/ /:/g"`; export LD_LIBRARY_PATH; ./resolve Error looking up IP address Hostname: localhost Host address: 127.0.0.1 FQDN: localhost Resolve library appears to have passed the test LD_LIBRARY_PATH=`echo -L../../lib | sed -e "s/-L//g" -e "s/ /:/g"`; export LD_LIBRARY_PATH; ./addrinfo-test -p telnet getaddrinfo(hostname (null), service telnet, hints { no-flags }): error => Servname not supported for ai_socktype make[2]: *** [check] Error 1 In my non-guix environment, I obtain privat@debian:/tmp/krb5-1.11/src/tests/resolve$ ./addrinfo-test -p telnet getaddrinfo(hostname (null), service telnet, hints { no-flags }): 0x2109f40: family = AF_INET6 proto = TCP socktype = STREAM addr = ::1 port = 23 getnameinfo => ip6-localhost, telnet 0x2109270: family = AF_INET proto = TCP socktype = STREAM addr = 127.0.0.1 port = 23 getnameinfo => localhost, telnet I suppose the problem is that the telnet ports are not defined in guix; when I manually do ./addrinfo-test -p t I obtain the same kind of error: getaddrinfo(hostname (null), service t, hints { no-flags }): error => Servname not supported for ai_socktype Instead of disabling all tests, one might patch the Makefile.in inside src/tests/resolve to not execute the telnet related tests. What do you think? Andreas --Boundary-01=_P1D4QeAr42+VLtK Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

Am Sonntag, 30. Dezember 2012 schrieb Nikita Karetnikov:

> > + `(#:tests? #f

> Ludo told me some time ago that it's necessary to write a comment when

> you disable tests. It should explain why they were disabled.

 

This is a mistake, thanks for spotting it!

 

Actually, the tests do fail with:

make[2]: Entering directory `/tmp/nix-build-mit-krb5-1.11.drv-0/krb5-1.11/src/tests/resolve'

LD_LIBRARY_PATH=`echo -L../../lib | sed -e "s/-L//g" -e "s/ /:/g"`; export LD_LIBRARY_PATH; ./resolve

Error looking up IP address

Hostname: localhost

Host address: 127.0.0.1

FQDN: localhost

Resolve library appears to have passed the test

LD_LIBRARY_PATH=`echo -L../../lib | sed -e "s/-L//g" -e "s/ /:/g"`; export LD_LIBRARY_PATH; ./addrinfo-test -p telnet

getaddrinfo(hostname (null), service telnet,

hints { no-flags }):

error => Servname not supported for ai_socktype

make[2]: *** [check] Error 1

 

In my non-guix environment, I obtain

privat@debian:/tmp/krb5-1.11/src/tests/resolve$ ./addrinfo-test -p telnet

getaddrinfo(hostname (null), service telnet,

hints { no-flags }):

0x2109f40:

family = AF_INET6 proto = TCP socktype = STREAM

addr = ::1 port = 23

getnameinfo => ip6-localhost, telnet

0x2109270:

family = AF_INET proto = TCP socktype = STREAM

addr = 127.0.0.1 port = 23

getnameinfo => localhost, telnet

 

I suppose the problem is that the telnet ports are not defined in guix; when I manually do

./addrinfo-test -p t

I obtain the same kind of error:

getaddrinfo(hostname (null), service t,

hints { no-flags }):

error => Servname not supported for ai_socktype

 

Instead of disabling all tests, one might patch the Makefile.in inside src/tests/resolve to not execute the telnet related tests.

 

What do you think?

 

Andreas

 

--Boundary-01=_P1D4QeAr42+VLtK--