From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: [PATCH] gnu build system: enable test-target during the check phase Date: Sat, 29 Dec 2012 21:10:31 +0100 Message-ID: <201212292110.31400.andreas@enge.fr> Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_3403QE5PddMZzWn" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:57416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tp2jx-00048g-Oa for bug-guix@gnu.org; Sat, 29 Dec 2012 15:10:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tp2ju-0004kI-UO for bug-guix@gnu.org; Sat, 29 Dec 2012 15:10:41 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:65413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tp2ju-0004k8-KV for bug-guix@gnu.org; Sat, 29 Dec 2012 15:10:38 -0500 List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: bug-guix@gnu.org --Boundary-00=_3403QE5PddMZzWn Content-Type: multipart/alternative; boundary="Boundary-01=_3403QEFb7xJNIbw" Content-Transfer-Encoding: 7bit --Boundary-01=_3403QEFb7xJNIbw Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hello, the attached patch should go to core-updates, but I would be in favour of moving it quickly to the master branch. It enables other make targets for the check phase; for instance, openssl needs "make test". The machinery was essentially in place, but the test-target variable was not passed to the appropriate build function. Andreas --Boundary-01=_3403QEFb7xJNIbw Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: 7bit

Hello,

 

the attached patch should go to core-updates, but I would be in favour of moving it quickly to the master branch. It enables other make targets for the check phase; for instance, openssl needs "make test". The machinery was essentially in place, but the test-target variable was not passed to the appropriate build function.

 

Andreas

 

 

 

--Boundary-01=_3403QEFb7xJNIbw-- --Boundary-00=_3403QE5PddMZzWn Content-Type: text/x-patch; charset="UTF-8"; name="0002-gnu-build-system-enable-test-target-during-the-check.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0002-gnu-build-system-enable-test-target-during-the-check.patch" =46rom 80b6c78100ee5a2acedd2276639ea2fa770ec4a5 Mon Sep 17 00:00:00 2001 =46rom: Andreas Enge Date: Sat, 29 Dec 2012 21:03:23 +0100 Subject: [PATCH 2/2] gnu build system: enable test-target during the check phase * guix/build-system/gnu.scm: add variable test-target =2D-- guix/build-system/gnu.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/guix/build-system/gnu.scm b/guix/build-system/gnu.scm index 9d94680..53fc474 100644 =2D-- a/guix/build-system/gnu.scm +++ b/guix/build-system/gnu.scm @@ -152,6 +152,7 @@ System: GCC, GNU Make, Bash, Coreutils, etc." (out-of-source? #f) (path-exclusions ''()) (tests? #t) + (test-target "check") (parallel-build? #t) (parallel-tests? #t) (patch-shebangs? #t) (strip-binaries? #t) @@ -193,6 +194,7 @@ which could lead to gratuitous input divergence." #:out-of-source? ,out-of-source? #:path-exclusions ,path-exclusions #:tests? ,tests? + #:test-target ,test-target #:parallel-build? ,parallel-build? #:parallel-tests? ,parallel-tests? #:patch-shebangs? ,patch-shebangs? =2D-=20 1.7.10.4 --Boundary-00=_3403QE5PddMZzWn-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu build system: enable test-target during the check phase Date: Sun, 30 Dec 2012 22:37:08 +0100 Message-ID: <8738yn1at7.fsf@gnu.org> References: <201212292110.31400.andreas@enge.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([208.118.235.92]:56898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TpQZD-0005A3-Pw for bug-guix@gnu.org; Sun, 30 Dec 2012 16:37:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TpQZC-0007DU-LZ for bug-guix@gnu.org; Sun, 30 Dec 2012 16:37:11 -0500 Received: from mail1-relais-roc.national.inria.fr ([192.134.164.82]:10098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TpQZC-0007DF-Ed for bug-guix@gnu.org; Sun, 30 Dec 2012 16:37:10 -0500 In-Reply-To: <201212292110.31400.andreas@enge.fr> (Andreas Enge's message of "Sat, 29 Dec 2012 21:10:31 +0100") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: Andreas Enge Cc: bug-guix@gnu.org Andreas Enge skribis: > the attached patch should go to core-updates, but I would be in favour of= =20 > moving it quickly to the master branch. It enables other make targets for= =20 > the check phase; for instance, openssl needs "make test". The machinery w= as=20 > essentially in place, but the test-target variable was not passed to the= =20 > appropriate build function. Thanks, I applied it to =E2=80=98core-updates=E2=80=99. I think that branch will have to be merged within one or two weeks anyway if we are to release in January. So I think we=E2=80=99ll just merge this patch then. WDYT? Ludo=E2=80=99. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu build system: enable test-target during the check phase Date: Tue, 1 Jan 2013 14:59:38 +0100 Message-ID: <201301011459.38261.andreas@enge.fr> References: <201212292110.31400.andreas@enge.fr> <8738yn1at7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="Boundary-01=_Kvu4QDjn9wYNPqf" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:36514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tq2aF-0005gH-90 for bug-guix@gnu.org; Tue, 01 Jan 2013 09:12:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tq2aC-00007j-FQ for bug-guix@gnu.org; Tue, 01 Jan 2013 09:12:47 -0500 In-Reply-To: <8738yn1at7.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: Ludovic =?utf-8?q?Court=C3=A8s?= , bug-guix@gnu.org --Boundary-01=_Kvu4QDjn9wYNPqf Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Am Sonntag, 30. Dezember 2012 schrieb Ludovic Court=C3=A8s: > Andreas Enge skribis: > > the attached patch should go to core-updates, but I would be in favour > > of moving it quickly to the master branch. It enables other make > > targets for the check phase; for instance, openssl needs "make test". > > The machinery was essentially in place, but the test-target variable > > was not passed to the appropriate build function. >=20 > Thanks, I applied it to =E2=80=98core-updates=E2=80=99. >=20 > I think that branch will have to be merged within one or two weeks > anyway if we are to release in January. So I think we=E2=80=99ll just me= rge > this patch then. WDYT? Whenever you like; I do not mind compiling gcc from time to time... Andreas --Boundary-01=_Kvu4QDjn9wYNPqf Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Am Sonntag,= 30. Dezember 2012 schrieb Ludovic Court=C3=A8s:

> Andrea= s Enge <andreas@enge.fr> skribis:

> > t= he attached patch should go to core-updates, but I would be in favour

> > o= f moving it quickly to the master branch. It enables other make

> > t= argets for the check phase; for instance, openssl needs "make test&quo= t;.

> > T= he machinery was essentially in place, but the test-target variable

> > w= as not passed to the appropriate build function.

>

> Thanks= , I applied it to =E2=80=98core-updates=E2=80=99.

>

> I thin= k that branch will have to be merged within one or two weeks

> anyway= if we are to release in January. So I think we=E2=80=99ll just merge

> this p= atch then. WDYT?

&nb= sp;

Whenever yo= u like; I do not mind compiling gcc from time to time...

&nb= sp;

Andreas

&nb= sp;

--Boundary-01=_Kvu4QDjn9wYNPqf--