* bug#26557: [PATCH] gnu: let exwm command work with arguments
@ 2017-04-18 22:33 Feng Shu
2017-04-19 6:01 ` Arun Isaac
2017-04-19 8:15 ` Arun Isaac
0 siblings, 2 replies; 6+ messages in thread
From: Feng Shu @ 2017-04-18 22:33 UTC (permalink / raw)
To: 26557
* gnu/packages/emacs.scm (emacs-exwm): Add $* to exwm shell-wrap
---
gnu/packages/emacs.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 6eb8751ad..27f9e2f63 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4475,7 +4475,7 @@ It should enable you to implement low-level X11 applications.")
(format #t "#!~a ~@
export DISPLAY=:0 ~@
~a +SI:localuser:$USER ~@
- exec ~a --exit-with-session ~a --eval '~s' ~%"
+ exec ~a --exit-with-session ~a $* --eval '~s' ~%"
(string-append (assoc-ref inputs "bash") "/bin/sh")
(string-append (assoc-ref inputs "xhost") "/bin/xhost")
(string-append (assoc-ref inputs "dbus") "/bin/dbus-launch")
--
2.12.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#26557: [PATCH] gnu: let exwm command work with arguments
2017-04-18 22:33 bug#26557: [PATCH] gnu: let exwm command work with arguments Feng Shu
@ 2017-04-19 6:01 ` Arun Isaac
2017-04-19 7:40 ` tumashu
2017-04-19 8:15 ` Arun Isaac
1 sibling, 1 reply; 6+ messages in thread
From: Arun Isaac @ 2017-04-19 6:01 UTC (permalink / raw)
To: 26557
What use case does this address?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#26557: [PATCH] gnu: let exwm command work with arguments
2017-04-19 6:01 ` Arun Isaac
@ 2017-04-19 7:40 ` tumashu
0 siblings, 0 replies; 6+ messages in thread
From: tumashu @ 2017-04-19 7:40 UTC (permalink / raw)
To: Arun Isaac; +Cc: 26557
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
The most useful case is adding "--debug-init" to debug the emacs problem, "-q" may useful too.
At 2017-04-19 14:01:41, "Arun Isaac" <arunisaac@systemreboot.net> wrote:>
>What use case does this address?
> > >
[-- Attachment #2: Type: text/html, Size: 448 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#26557: [PATCH] gnu: let exwm command work with arguments
2017-04-18 22:33 bug#26557: [PATCH] gnu: let exwm command work with arguments Feng Shu
2017-04-19 6:01 ` Arun Isaac
@ 2017-04-19 8:15 ` Arun Isaac
2017-04-19 10:03 ` tumashu
1 sibling, 1 reply; 6+ messages in thread
From: Arun Isaac @ 2017-04-19 8:15 UTC (permalink / raw)
To: 26557
> The most useful case is adding "--debug-init" to debug the emacs
> problem, "-q" may useful too.
Ok.
> - exec ~a --exit-with-session ~a --eval '~s' ~%"
> + exec ~a --exit-with-session ~a $* --eval '~s' ~%"
To account for arguments with spaces in them, could you make this "$@"
instead of $* ?
https://stackoverflow.com/questions/12314451/accessing-bash-command-line-args-vs
Also, the first line of the commit message should be
gnu: emacs-exwm: Let exwm ...
Note the addition of "emacs-exwm" and title case of "Let".
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#26557: [PATCH] gnu: let exwm command work with arguments
2017-04-19 8:15 ` Arun Isaac
@ 2017-04-19 10:03 ` tumashu
2017-04-19 16:52 ` Arun Isaac
0 siblings, 1 reply; 6+ messages in thread
From: tumashu @ 2017-04-19 10:03 UTC (permalink / raw)
To: Arun Isaac; +Cc: 26557@debbugs.gnu.org
[-- Attachment #1.1: Type: text/plain, Size: 702 bytes --]
updated patch:
At 2017-04-19 16:15:05, "Arun Isaac" <arunisaac@systemreboot.net> wrote:
>
>> The most useful case is adding "--debug-init" to debug the emacs
>> problem, "-q" may useful too.
>
>Ok.
>
>> - exec ~a --exit-with-session ~a --eval '~s' ~%"
>> + exec ~a --exit-with-session ~a $* --eval '~s' ~%"
>
>To account for arguments with spaces in them, could you make this "$@"
>instead of $* ?
>
>https://stackoverflow.com/questions/12314451/accessing-bash-command-line-args-vs
>
>Also, the first line of the commit message should be
>
>gnu: emacs-exwm: Let exwm ...
>
>Note the addition of "emacs-exwm" and title case of "Let".
>
>Thanks!
>
>
>
[-- Attachment #1.2: Type: text/html, Size: 998 bytes --]
[-- Attachment #2: 0001-gnu-emacs-exwm-Let-exwm-shell-wrap-work-with-argumen.patch --]
[-- Type: application/octet-stream, Size: 1147 bytes --]
From b9937f40378bcf616f5c866232e42db6630c9ae3 Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@163.com>
Date: Wed, 19 Apr 2017 06:14:44 +0800
Subject: [PATCH] gnu: emacs-exwm: Let exwm shell-wrap work with arguments
* gnu/packages/emacs.scm (emacs-exwm): Add "$@" to exwm shell-wrap
---
gnu/packages/emacs.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 6eb8751ad..68bac8b41 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4475,7 +4475,7 @@ It should enable you to implement low-level X11 applications.")
(format #t "#!~a ~@
export DISPLAY=:0 ~@
~a +SI:localuser:$USER ~@
- exec ~a --exit-with-session ~a --eval '~s' ~%"
+ exec ~a --exit-with-session ~a \"$@\" --eval '~s' ~%"
(string-append (assoc-ref inputs "bash") "/bin/sh")
(string-append (assoc-ref inputs "xhost") "/bin/xhost")
(string-append (assoc-ref inputs "dbus") "/bin/dbus-launch")
--
2.12.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#26557: [PATCH] gnu: let exwm command work with arguments
2017-04-19 10:03 ` tumashu
@ 2017-04-19 16:52 ` Arun Isaac
0 siblings, 0 replies; 6+ messages in thread
From: Arun Isaac @ 2017-04-19 16:52 UTC (permalink / raw)
To: 26557-done
Pushed!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-19 16:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-18 22:33 bug#26557: [PATCH] gnu: let exwm command work with arguments Feng Shu
2017-04-19 6:01 ` Arun Isaac
2017-04-19 7:40 ` tumashu
2017-04-19 8:15 ` Arun Isaac
2017-04-19 10:03 ` tumashu
2017-04-19 16:52 ` Arun Isaac
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.