From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUsp6-0003sv-82 for guix-patches@gnu.org; Thu, 06 Dec 2018 07:32:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUsp1-0008VJ-MG for guix-patches@gnu.org; Thu, 06 Dec 2018 07:32:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:58980) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gUsp1-0008V3-GW for guix-patches@gnu.org; Thu, 06 Dec 2018 07:32:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gUsp0-0008NK-D6 for guix-patches@gnu.org; Thu, 06 Dec 2018 07:32:03 -0500 Subject: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. Resent-Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Date: Thu, 06 Dec 2018 04:31:28 -0800 From: swedebugia@riseup.net In-Reply-To: <87k1knpjta.fsf@gmail.com> References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87y3967n3z.fsf@gnu.org> <87k1knpjta.fsf@gmail.com> Message-ID: <1f7a7e5589c465c0ad913b388374cf4b@riseup.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov Cc: 33575@debbugs.gnu.org, Guix-patches On 2018-12-06 01:42, Oleg Pykhalov wrote: > Hello, > > ludo@gnu.org (Ludovic Courtès) writes: > > […] > >> It’s something we rarely do so we’d get warnings for most packages. As >> a side effect, people may pay less attention to what ‘guix lint’ says. > > I think this should not stop us from improving a linter and an option > like --misc-checks=sort-input,foo,bar could be used for such cases. I agree with Oleg here. If many packages needs inputs to be sorted lets write a guix lint --sort modelling the updater (that is make the changes in the work tree to be committed). -- Cheers Swedebugia