[bug#57731] [PATCH 0/1] Add batsignal package

[bug#57731] [PATCH 0/1] Add batsignal package

[M]

batsignal can send desktop notifications at set battery levels, and can run a
command when the battery level gets dangerously low. This can be used to force
powering off a laptop when battery gets below critical levels, instead of
damaging the battery.

M (1):
  gnu: Add batsignal.

 gnu/packages/monitoring.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

-- 
2.37.2

[bug#57731] [PATCH 1/1] gnu: Add batsignal.

[M]

* gnu/packages/monitoring.scm (batsignal): New variable.
---
 gnu/packages/monitoring.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
index 47845700ee..bccf03ae06 100644
--- a/gnu/packages/monitoring.scm
+++ b/gnu/packages/monitoring.scm
@@ -12,6 +12,8 @@
 ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be>
 ;;; Copyright © 2022 Paul A. Patience <paul@apatience.com>
 ;;; Copyright © 2022 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2022 ( <paren@disroot.org>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -50,6 +52,7 @@ (define-module (gnu packages monitoring)
   #:use-module (gnu packages django)
   #:use-module (gnu packages gd)
   #:use-module (gnu packages gettext)
+  #:use-module (gnu packages gnome)
   #:use-module (gnu packages image)
   #:use-module (gnu packages mail)
   #:use-module (gnu packages ncurses)
@@ -764,3 +767,34 @@ (define-public python-statsd
     (description "StatsD is a friendly front-end to Graphite.  This package
 provides a simple Python client for the StatsD daemon.")
     (license license:expat)))
+
+(define-public batsignal
+  (package
+    (name "batsignal")
+    (version "1.6.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/electrickite/batsignal")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0b1j6mljnqgxwr3id3r9shzhsjk5r0qdh9cxkvy1dm4kzbyc4dxq"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:tests? #f ;; batsignal's tests depend on docker
+           #:phases
+           #~(modify-phases %standard-phases (delete 'configure))
+           #:make-flags
+           #~(list (string-append "PREFIX=" #$output)
+                   (string-append "CC=" #$(cc-for-target)))))
+    (inputs (list libnotify))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/electrickite/batsignal")
+    (synopsis "Simple power monitoring tool")
+    (description
+     "This package provides a daemon that monitors device power
+levels, notifying the user and optionally running a command when
+it reaches user-configured power thresholds.")
+    (license license:isc)))
-- 
2.37.2

[bug#57731] [PATCH 1/1] gnu: Add batsignal.

[Liliana Marie Prikler]

Hi

Am Sonntag, dem 11.09.2022 um 15:47 +0200 schrieb M:
> * gnu/packages/monitoring.scm (batsignal): New variable.
> ---
>  gnu/packages/monitoring.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/gnu/packages/monitoring.scm
> b/gnu/packages/monitoring.scm
> index 47845700ee..bccf03ae06 100644
> --- a/gnu/packages/monitoring.scm
> +++ b/gnu/packages/monitoring.scm
> @@ -12,6 +12,8 @@
>  ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be>
>  ;;; Copyright © 2022 Paul A. Patience <paul@apatience.com>
>  ;;; Copyright © 2022 Hartmut Goebel <h.goebel@crazy-compilers.com>
> +;;; Copyright © 2022 ( <paren@disroot.org>
> +;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
Did you two co-author the patch?  If so, add a "Co-authored-by" trailer
to the commit message.  Also, your copyright mail does not match the
sender, you may want to fix that.
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -50,6 +52,7 @@ (define-module (gnu packages monitoring)
>    #:use-module (gnu packages django)
>    #:use-module (gnu packages gd)
>    #:use-module (gnu packages gettext)
> +  #:use-module (gnu packages gnome)
>    #:use-module (gnu packages image)
>    #:use-module (gnu packages mail)
>    #:use-module (gnu packages ncurses)
> @@ -764,3 +767,34 @@ (define-public python-statsd
>      (description "StatsD is a friendly front-end to Graphite.  This
> package
>  provides a simple Python client for the StatsD daemon.")
>      (license license:expat)))
> +
> +(define-public batsignal
> +  (package
> +    (name "batsignal")
> +    (version "1.6.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url
> "https://github.com/electrickite/batsignal")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +               
> "0b1j6mljnqgxwr3id3r9shzhsjk5r0qdh9cxkvy1dm4kzbyc4dxq"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     (list #:tests? #f ;; batsignal's tests depend on docker
The test appears to be running "batsignal -v", which we could do in the
build container as well.
> +           #:phases
> +           #~(modify-phases %standard-phases (delete 'configure))
By convention #:phases is the last argument to set.
> +           #:make-flags
> +           #~(list (string-append "PREFIX=" #$output)
> +                   (string-append "CC=" #$(cc-for-target)))))
> +    (inputs (list libnotify))
> +    (native-inputs (list pkg-config))
> +    (home-page "https://github.com/electrickite/batsignal")
> +    (synopsis "Simple power monitoring tool")
"Power monitoring tool"
> +    (description
> +     "This package provides a daemon that monitors device power
> +levels, notifying the user and optionally running a command when
> +it reaches user-configured power thresholds.")
> +    (license license:isc)))
Cheers.

[bug#57731] [PATCH 1/1] gnu: Add batsignal.

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 742 bytes --]



On 11-09-2022 15:47, M wrote:
> +    (arguments
> +     (list #:tests? #f ;; batsignal's tests depend on docker
> +           #:phases
> +           #~(modify-phases %standard-phases (delete 'configure))
> +           #:make-flags
> +           #~(list (string-append "PREFIX=" #$output)
> +                   (string-append "CC=" #$(cc-for-target)))))
> +    (inputs (list libnotify))

The makefile uses pkg-config.  However, when cross-compiling,
TARGET-pkg-config is required instead.  To solve this, you will need to 
'substitute*' pkg-config to #$(pkg-config-for-target).  For an example, 
see opensmtpd-filter-dkimsign.

(Unfortunately the dependency libtirpc is not yet cross-compilable ...)

Greetings,
Maxime.

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[bug#57731] [PATCH 0/1] Add batsignal package

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 610 bytes --]



On 11-09-2022 15:43, M wrote:
> batsignal can send desktop notifications at set battery levels, and can run a
> command when the battery level gets dangerously low. This can be used to force
> powering off a laptop when battery gets below critical levels, instead of
> damaging the battery.

This looks like a good description to me, can you integrate the 'This 
can be used to force powering off a laptop when the battery gets below 
critical levels, instead of damaging the battery’ in the package 
description?  It seems like a widely useful and simple example usage.

Greetings,
Maxime.

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[bug#57731] [PATCH v2] gnu: Add batsignal.

[M]

* gnu/packages/monitoring.scm (batsignal): New variable.
  Co-authored by unmatched-paren and matf
---
 gnu/packages/monitoring.scm | 45 +++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
index 47845700ee..459b8d8539 100644
--- a/gnu/packages/monitoring.scm
+++ b/gnu/packages/monitoring.scm
@@ -12,6 +12,8 @@
 ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be>
 ;;; Copyright © 2022 Paul A. Patience <paul@apatience.com>
 ;;; Copyright © 2022 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2022 ( <paren@disroot.org>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -50,6 +52,7 @@ (define-module (gnu packages monitoring)
   #:use-module (gnu packages django)
   #:use-module (gnu packages gd)
   #:use-module (gnu packages gettext)
+  #:use-module (gnu packages gnome)
   #:use-module (gnu packages image)
   #:use-module (gnu packages mail)
   #:use-module (gnu packages ncurses)
@@ -764,3 +767,45 @@ (define-public python-statsd
     (description "StatsD is a friendly front-end to Graphite.  This package
 provides a simple Python client for the StatsD daemon.")
     (license license:expat)))
+
+(define-public batsignal
+  (package
+    (name "batsignal")
+    (version "1.6.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/electrickite/batsignal")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0b1j6mljnqgxwr3id3r9shzhsjk5r0qdh9cxkvy1dm4kzbyc4dxq"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:make-flags
+           #~(list (string-append "PREFIX=" #$output)
+                   (string-append "CC=" #$(cc-for-target)))
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'fix-cross-compile
+                 (lambda _
+                   (substitute* "Makefile"
+                     (("pkg-config")
+                      #$(pkg-config-for-target)))))
+               (delete 'configure)
+                            (replace 'check
+               (lambda* (#:key tests? #:allow-other-keys)
+                 (when tests?
+                   (invoke "./batsignal" "-v")))))))
+    (inputs (list libnotify))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/electrickite/batsignal")
+    (synopsis "Power monitoring tool")
+    (description
+     "This package provides a daemon that monitors device power
+levels, notifying the user and optionally running a command when
+it reaches user-configured power thresholds. This can be used to force powering
+off a laptop when the battery gets below critical levels, instead of damaging
+the battery.")
+    (license license:isc)))
-- 
2.37.2

[bug#57731] [PATCH 1/1] gnu: Add batsignal.

[M]

* gnu/packages/monitoring.scm (batsignal): New variable.
  Co-authored-by: ( <paren@disroot.org>
---
 gnu/packages/monitoring.scm | 45 +++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
index 47845700ee..7f665e931f 100644
--- a/gnu/packages/monitoring.scm
+++ b/gnu/packages/monitoring.scm
@@ -12,6 +12,8 @@
 ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be>
 ;;; Copyright © 2022 Paul A. Patience <paul@apatience.com>
 ;;; Copyright © 2022 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2022 ( <paren@disroot.org>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -50,6 +52,7 @@ (define-module (gnu packages monitoring)
   #:use-module (gnu packages django)
   #:use-module (gnu packages gd)
   #:use-module (gnu packages gettext)
+  #:use-module (gnu packages gnome)
   #:use-module (gnu packages image)
   #:use-module (gnu packages mail)
   #:use-module (gnu packages ncurses)
@@ -764,3 +767,45 @@ (define-public python-statsd
     (description "StatsD is a friendly front-end to Graphite.  This package
 provides a simple Python client for the StatsD daemon.")
     (license license:expat)))
+
+(define-public batsignal
+  (package
+    (name "batsignal")
+    (version "1.6.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/electrickite/batsignal")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0b1j6mljnqgxwr3id3r9shzhsjk5r0qdh9cxkvy1dm4kzbyc4dxq"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:make-flags
+           #~(list (string-append "PREFIX=" #$output)
+                   (string-append "CC=" #$(cc-for-target)))
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'fix-cross-compile
+                 (lambda _
+                   (substitute* "Makefile"
+                     (("pkg-config")
+                      #$(pkg-config-for-target)))))
+               (delete 'configure)
+                            (replace 'check
+               (lambda* (#:key tests? #:allow-other-keys)
+                 (when tests?
+                   (invoke "./batsignal" "-v")))))))
+    (inputs (list libnotify))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/electrickite/batsignal")
+    (synopsis "Power monitoring tool")
+    (description
+     "This package provides a daemon that monitors device power levels,
+notifying the user and optionally running a command when it reaches
+user-configured power thresholds.  This can be used to force powering off a
+laptop when the battery gets below critical levels, instead of damaging the
+battery.")
+    (license license:isc)))
-- 
2.37.2

[bug#57731] [PATCH v4] gnu: Add batsignal.

[M]

* gnu/packages/monitoring.scm (batsignal): New variable.

Co-authored-by: ( <paren@disroot.org>
---
 gnu/packages/monitoring.scm | 43 +++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
index 47845700ee..608973f9c2 100644
--- a/gnu/packages/monitoring.scm
+++ b/gnu/packages/monitoring.scm
@@ -764,3 +764,46 @@ (define-public python-statsd
     (description "StatsD is a friendly front-end to Graphite.  This package
 provides a simple Python client for the StatsD daemon.")
     (license license:expat)))
+
+(define-public batsignal
+  (package
+    (name "batsignal")
+    (version "1.6.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/electrickite/batsignal")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0b1j6mljnqgxwr3id3r9shzhsjk5r0qdh9cxkvy1dm4kzbyc4dxq"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:make-flags
+           #~(list (string-append "PREFIX=" #$output)
+                   (string-append "CC=" #$(cc-for-target)))
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'fix-cross-compile
+                 (lambda _
+                   (substitute* "Makefile"
+                     (("pkg-config")
+                      #$(pkg-config-for-target)))))
+               (delete 'configure)
+               (replace 'check
+                 (lambda* (#:key tests? #:allow-other-keys)
+                   (when tests?
+                     (invoke "./batsignal" "-v")))))))
+    (inputs (list libnotify))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/electrickite/batsignal")
+    (synopsis "Power monitoring tool")
+    (description
+     "This package provides a daemon that monitors device power levels,
+notifying the user and optionally running a command when it reaches
+user-configured power thresholds.  This can be used to force powering off a
+laptop when the battery gets below critical levels, instead of damaging the
+battery.")
+    (license license:isc)))
+
-- 
2.37.2

[bug#57731] [PATCH v4] gnu: Add batsignal.

[( via Guix-patches via]

LGTM!

    -- (

[bug#57731] [PATCH v5] gnu: Add batsignal.

[M]

* gnu/packages/monitoring.scm (batsignal): New variable.

Co-authored-by: ( <paren@disroot.org>
---
 gnu/packages/monitoring.scm | 45 +++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scm
index 47845700ee..8f75eacf9e 100644
--- a/gnu/packages/monitoring.scm
+++ b/gnu/packages/monitoring.scm
@@ -12,6 +12,8 @@
 ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be>
 ;;; Copyright © 2022 Paul A. Patience <paul@apatience.com>
 ;;; Copyright © 2022 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2022 ( <paren@disroot.org>
+;;; Copyright © 2022 Mathieu Laparie <mlaparie@disr.it>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -764,3 +766,46 @@ (define-public python-statsd
     (description "StatsD is a friendly front-end to Graphite.  This package
 provides a simple Python client for the StatsD daemon.")
     (license license:expat)))
+
+(define-public batsignal
+  (package
+    (name "batsignal")
+    (version "1.6.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/electrickite/batsignal")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0b1j6mljnqgxwr3id3r9shzhsjk5r0qdh9cxkvy1dm4kzbyc4dxq"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:make-flags
+           #~(list (string-append "PREFIX=" #$output)
+                   (string-append "CC=" #$(cc-for-target)))
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'fix-cross-compile
+                 (lambda _
+                   (substitute* "Makefile"
+                     (("pkg-config")
+                      #$(pkg-config-for-target)))))
+               (delete 'configure)
+               (replace 'check
+                 (lambda* (#:key tests? #:allow-other-keys)
+                   (when tests?
+                     (invoke "./batsignal" "-v")))))))
+    (inputs (list libnotify))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/electrickite/batsignal")
+    (synopsis "Power monitoring tool")
+    (description
+     "This package provides a daemon that monitors device power levels,
+notifying the user and optionally running a command when it reaches
+user-configured power thresholds.  This can be used to force powering off a
+laptop when the battery gets below critical levels, instead of damaging the
+battery.")
+    (license license:isc)))
+
-- 
2.37.2

bug#57731: [PATCH 0/1] Add batsignal package

[Ludovic Courtès]

Hi,

M <matf@disr.it> skribis:

> * gnu/packages/monitoring.scm (batsignal): New variable.
>
> Co-authored-by: ( <paren@disroot.org>

There was one missing #:use-module (gnu packages gnome), which I added.

Applied.  Thanks Mathieu, and thanks paren for reviewing!

Ludo’.

[bug#57731] [PATCH 0/1] Add batsignal package

[Mathieu]

Thanks all, glad to see this merged!

On 2022-09-24 15:56 Ludovic Courtès <ludo@gnu.org> wrote:

> Hi,
>  
> M <matf@disr.it> skribis:
>  
>> * gnu/packages/monitoring.scm (batsignal): New variable.
>>  
>> Co-authored-by: ( <paren@disroot.org>
>  
> There was one missing #:use-module (gnu packages gnome), which I
> added.
>  
> Applied.  Thanks Mathieu, and thanks paren for reviewing!
>  
> Ludo’.