From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petter Subject: Re: [PATCH] gnu: go: Update to 1.8.1 Date: Mon, 17 Apr 2017 15:37:49 +0200 Message-ID: <1e60418d89b070a52d90ef4b3f08eba3@mykolab.ch> References: <7f4cf1ee6c558899e8c9457102c2e0d4@mykolab.ch> <20170417135418.0bf12c87@sf> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_912b5127b97e8f6baf1a1d18984eb2fe" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d06qr-0002AR-FC for guix-devel@gnu.org; Mon, 17 Apr 2017 09:37:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d06qo-0003g1-A7 for guix-devel@gnu.org; Mon, 17 Apr 2017 09:37:57 -0400 Received: from mx.kolabnow.com ([95.128.36.1]:19562 helo=mx-out01.mykolab.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d06qn-0003fP-UJ for guix-devel@gnu.org; Mon, 17 Apr 2017 09:37:54 -0400 In-Reply-To: <20170417135418.0bf12c87@sf> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Sergei Trofimovich Cc: guix-devel@gnu.org --=_912b5127b97e8f6baf1a1d18984eb2fe Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi Sergei, I definitely think your fix deserves recognition. Without it I would certainly have been unable to build 1.8(.1)? this month. While editing the recipe is trivial mechanical wise, figuring out what to change was not :) Sorry to hear about your issues; I'm on x86_64 and Linux as well though... > $ /gnu/store/b4gflqj64yvksq7959r6m22mf9lzdy69-go-1.8.1/bin/go version > go version go1.8.1 linux/amd64 Hope you'll be able to work this out! Thanks for fixing Go 1.8 :) Best, Petter On 2017-04-17 14:54, Sergei Trofimovich wrote: > On Mon, 17 Apr 2017 14:16:06 +0200 > Petter wrote: > >> Hi, >> >> With this patch I'm not sure how to properly handle Copyright. I've >> taken a guess and prepared a >> patch anyway. >> >> Here's the situation. >> >> Updating to 1.8 was not trivial. A fix has been posted in a comment by >> Sergei Trofimovich on >> github[1]. It's a proper Guix patch, updating Go to 1.8, with the fix >> and the trivial update stuff, >> but as far as I can see not actually submitted to Guix. >> >> [1] https://github.com/golang/go/issues/19132#issuecomment-285897612 >> >> After this Go 1.8.1 has been released. The attached patch has the >> trivial update stuff for 1.8.1 >> and the fix by Sergei. I added Sergei to the Copyright section, but >> I'm >> not sure if this is >> correct, and if this is the way to do it. Also, I didn't find his >> e-mail >> address, so I just added >> his github page, in ()... >> >> A little messy, please let me know if I should do something >> differently. > > I consider the fix itself trivial thus I'm perfectly fine with not > being > attributed at all. Apologies for making it hard to track me down. > I've added one of emails to github's front page. > > [ While the fix is trivial debugging was a bit more fun :) ] > > If you still like to add attribution (or have other reasons) feel free > to add "Sergei Trofimovich " > > I didn't get to submitting something that works because some unrelated > go-1.8.0 tests failed for me. > > go-1.8.1 fails in a similar way, but if it works for you > it's very probable just my environment (x86_64-linux): > > guix-master $ ./pre-inst-env guix build go-1.8 > > ##### ../misc/cgo/test > runtime/cgo: pthread_create failed: Resource temporarily unavailable > scatter = 0x55ffc0 > hello from C > sqrt is: 0 > SIGABRT: abort > PC=0x7ffff71232c4 m=12 sigcode=18446744073709551610 > > Thanks for finishing go update! --=_912b5127b97e8f6baf1a1d18984eb2fe Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-go-Update-to-1.8.1.patch Content-Disposition: attachment; filename=0001-gnu-go-Update-to-1.8.1.patch; size=2683 RnJvbSBhZTg0MzRjNzJkNzVmNjhmYTI1NTcxYmVlNzIwODRhNjIzNjYxYTU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXR0ZXIgPHBldHRlckBteWtvbGFiLmNoPgpEYXRlOiBNb24s IDE3IEFwciAyMDE3IDE1OjE0OjE4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gZ251OiBnbzogVXBk YXRlIHRvIDEuOC4xLgoKKiBnbnUvcGFja2FnZXMvZ29sYW5nLnNjbSAoZ28pOiBVcGRhdGUgdG8g MS44LjEuCi0tLQogZ251L3BhY2thZ2VzL2dvbGFuZy5zY20gfCAxNSArKysrKysrKy0tLS0tLS0K IDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvZ251L3BhY2thZ2VzL2dvbGFuZy5zY20gYi9nbnUvcGFja2FnZXMvZ29sYW5nLnNjbQpp bmRleCAwMDYzMGNlMDYuLjkwYTgwOWViMiAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL2dvbGFu Zy5zY20KKysrIGIvZ251L3BhY2thZ2VzL2dvbGFuZy5zY20KQEAgLTMsOCArMyw5IEBACiA7Ozsg Q29weXJpZ2h0IMKpIDIwMTYgTWF0dGhldyBKb3JkYW4gPG1hdHRoZXdqb3JkYW5kZXZvcHNAeWFu ZGV4LmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxNiBBbmR5IFdpbmdvIDx3aW5nb0BpZ2FsaWEu Y29tPgogOzs7IENvcHlyaWdodCDCqSAyMDE2IEx1ZG92aWMgQ291cnTDqHMgPGx1ZG9AZ251Lm9y Zz4KLTs7OyBDb3B5cmlnaHQgwqkgMjAxNiBQZXR0ZXIgPHBldHRlckBteWtvbGFiLmNoPgorOzs7 IENvcHlyaWdodCDCqSAyMDE2LCAyMDE3IFBldHRlciA8cGV0dGVyQG15a29sYWIuY2g+CiA7Ozsg Q29weXJpZ2h0IMKpIDIwMTYsIDIwMTcgTGVvIEZhbXVsYXJpIDxsZW9AZmFtdWxhcmkubmFtZT4K Kzs7OyBDb3B5cmlnaHQgwqkgMjAxNyBTZXJnZWkgVHJvZmltb3ZpY2ggPHNseWZveEBpbmJveC5y dT4KIDs7OwogOzs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7CkBAIC0xOTcs MTEgKzE5OCwxMSBAQCBnYXJiYWdlIGNvbGxlY3Rpb24sIHZhcmlvdXMgc2FmZXR5IGZlYXR1cmVz IGFuZCBpbiB0aGUgc3R5bGUgb2YgY29tbXVuaWNhdGluZwogc2VxdWVudGlhbCBwcm9jZXNzZXMg KENTUCkgY29uY3VycmVudCBwcm9ncmFtbWluZyBmZWF0dXJlcyBhZGRlZC4iKQogICAgIChsaWNl bnNlIGxpY2Vuc2U6YnNkLTMpKSkKIAotKGRlZmluZS1wdWJsaWMgZ28tMS43CisoZGVmaW5lLXB1 YmxpYyBnby0xLjgKICAgKHBhY2thZ2UKICAgICAoaW5oZXJpdCBnby0xLjQpCiAgICAgKG5hbWUg ImdvIikKLSAgICAodmVyc2lvbiAiMS43LjUiKQorICAgICh2ZXJzaW9uICIxLjguMSIpCiAgICAg KHNvdXJjZQogICAgICAob3JpZ2luCiAgICAgICAgKG1ldGhvZCB1cmwtZmV0Y2gpCkBAIC0yMDks NyArMjEwLDcgQEAgc2VxdWVudGlhbCBwcm9jZXNzZXMgKENTUCkgY29uY3VycmVudCBwcm9ncmFt bWluZyBmZWF0dXJlcyBhZGRlZC4iKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgbmFtZSB2 ZXJzaW9uICIuc3JjLnRhci5neiIpKQogICAgICAgIChzaGEyNTYKICAgICAgICAgKGJhc2UzMgot ICAgICAgICAgIjA1OHE1N3ptaTIzcmZsaW5nemh5MWI4N3lsNjltYjYycWwycHNmeHFyN3E3bDg5 bGIwc2YiKSkpKQorICAgICAgICAgIjBtcWY4eWR4ZHgxcHdtcnM4cDh3bDV5MXFycGx6eG14emdi NnZrZ2h5NGw2N3owZzluaWsiKSkpKQogICAgIChhcmd1bWVudHMKICAgICAgKHN1YnN0aXR1dGUt a2V5d29yZC1hcmd1bWVudHMgKHBhY2thZ2UtYXJndW1lbnRzIGdvLTEuNCkKICAgICAgICAoKCM6 cGhhc2VzIHBoYXNlcykKQEAgLTMwMCw4ICszMDEsOCBAQCBzZXF1ZW50aWFsIHByb2Nlc3NlcyAo Q1NQKSBjb25jdXJyZW50IHByb2dyYW1taW5nIGZlYXR1cmVzIGFkZGVkLiIpCiAgICAgICAgICAg ICAgICAgICAgKCgiL2V0Yy9zZXJ2aWNlcyIpIChzdHJpbmctYXBwZW5kIG5ldC1iYXNlICIvZXRj L3NlcnZpY2VzIikpKQogICAgICAgICAgICAgICAgICAoc3Vic3RpdHV0ZSogInRpbWUvem9uZWlu Zm9fdW5peC5nbyIKICAgICAgICAgICAgICAgICAgICAoKCIvdXNyL3NoYXJlL3pvbmVpbmZvLyIp IHR6ZGF0YS1wYXRoKSkKLSAgICAgICAgICAgICAgICAgKHN1YnN0aXR1dGUqIChmaW5kLWZpbGVz ICJjbWQiICJhc20uYyIpCi0gICAgICAgICAgICAgICAgICAgKCgiL2xpYi9sZC1saW51eC4qXFwu c29cXC5bMC05XSIpIGxvYWRlcikpCisgICAgICAgICAgICAgICAgIChzdWJzdGl0dXRlKiAoZmlu ZC1maWxlcyAiY21kIiAiXFwuZ28iKQorICAgICAgICAgICAgICAgICAgICgoIi9saWIoNjQpPy9s ZC1saW51eC4qXFwuc29cXC5bMC05XSIpIGxvYWRlcikpCiAgICAgICAgICAgICAgICAgICN0KSkp CiAgICAgICAgICAgIChhZGQtYmVmb3JlICdidWlsZCAnc2V0LWJvb3RzdHJhcC12YXJpYWJsZXMK ICAgICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgb3V0cHV0cyBpbnB1dHMgIzphbGxvdy1vdGhl ci1rZXlzKQpAQCAtMzY0LDQgKzM2NSw0IEBAIHNlcXVlbnRpYWwgcHJvY2Vzc2VzIChDU1ApIGNv bmN1cnJlbnQgcHJvZ3JhbW1pbmcgZmVhdHVyZXMgYWRkZWQuIikKICAgICAgYCgoImdvIiAsZ28t MS40KQogICAgICAgICxAKHBhY2thZ2UtbmF0aXZlLWlucHV0cyBnby0xLjQpKSkpKQogCi0oZGVm aW5lLXB1YmxpYyBnbyBnby0xLjcpCisoZGVmaW5lLXB1YmxpYyBnbyBnby0xLjgpCi0tIAoyLjEx LjEKCg== --=_912b5127b97e8f6baf1a1d18984eb2fe--