From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2D7zNg0I1mGWqQAAgWs5BA (envelope-from ) for ; Wed, 05 Jan 2022 22:05:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KPhaNA0I1mHlDAAA9RJhRA (envelope-from ) for ; Wed, 05 Jan 2022 22:05:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4AABD312EB for ; Wed, 5 Jan 2022 22:05:17 +0100 (CET) Received: from localhost ([::1]:35420 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5DTA-0006dr-2A for larch@yhetil.org; Wed, 05 Jan 2022 16:05:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5DSw-0006di-Ok for guix-patches@gnu.org; Wed, 05 Jan 2022 16:05:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46103) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5DSw-0006yC-Eb for guix-patches@gnu.org; Wed, 05 Jan 2022 16:05:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5DSw-0007QX-Ae for guix-patches@gnu.org; Wed, 05 Jan 2022 16:05:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v6 05/41] guix: node-build-system: Add 'delete-dependencies' helper function. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Jan 2022 21:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 51838@debbugs.gnu.org Cc: Timothy Sample , Pierre Langlois , Jelle Licht Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.164141665328489 (code B ref 51838); Wed, 05 Jan 2022 21:05:02 +0000 Received: (at 51838) by debbugs.gnu.org; 5 Jan 2022 21:04:13 +0000 Received: from localhost ([127.0.0.1]:39006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5DS8-0007PR-FM for submit@debbugs.gnu.org; Wed, 05 Jan 2022 16:04:12 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:46959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5DS6-0007PB-Bb for 51838@debbugs.gnu.org; Wed, 05 Jan 2022 16:04:10 -0500 Received: by mail-wr1-f65.google.com with SMTP id i22so677903wrb.13 for <51838@debbugs.gnu.org>; Wed, 05 Jan 2022 13:04:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=SWTyzknieGH67dp2h0yN7SYu+5gKUqmQCHckxqRyzxU=; b=j1Jotcj/PWsdAt/62sUMHyt7LVu2Lmd427wdvhmAnGJU8p1O/wzwziCiRN3rsfqy3E mK/NYwq3p6CT79bVM6hT3W/ZLrfnmpXM8yJphJVFC3XNR/NMInpRBG8dEURjJ3d2+f1j 6UphpDyBHpk1JjNMJ9bmsqSE0DEpDyW3gN1JJRM5HwPm2MC7IloLhzHdGD21lecRbWFg fZrs0EakKc9YSaEPBglse3qblIocsj2BLPoRlp/1qDsrnV/EQR1JaQlaBG15H4ly/DbA 06cJu0/s3p7bGZzHX9p9BR0bMp2S8GHYvbt0/I/1qTrZMebH9Omx9VHcTec/NWemJEKU c3cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=SWTyzknieGH67dp2h0yN7SYu+5gKUqmQCHckxqRyzxU=; b=au3xFSKXr4k0Sa8dECuAVcZY/50Io+obJiaKtnH1Qmt/xHgZyhqmgqMice3eBSSPFp mRDz1+BJl+8v71BUaIKy0r4hRGpjeAE20iU4cRtwvdP7M9KhxFyTKmrEHjCBZ2BD3K1O hN1WFeEcFWHyZJG4BnQWQhz00eCSg6a66B6uU4c/gPX4J/akcqpq86dOo1DuWBVmQnkw 59XIEbi3d7nkIWtw8BDcQ6T8flix2W7yh1kicjF9wlaukIpvZkMOJO/rzJFu5qJyBbBL GpZSwNXoT46mntlEXDbKL6shoD4A/KfGmftU0TTyyCG9/jyOoQY2Rfz7Q1pfgtLX57Ly P+vg== X-Gm-Message-State: AOAM533V9IcqJezHyPurON9TUVLp0BfHH4/1qhZ7EjVu6ndQ1/9/9l39 fDj4AmviXpVmr8FqsQo57zM= X-Google-Smtp-Source: ABdhPJyUoxoS7P7VfBadr7RkGlMvvu8SyUbvFelvL+h9DB4Km6NL2GkcExB0qtobMOqukOvqZe9I7w== X-Received: by 2002:a5d:6d0a:: with SMTP id e10mr46773691wrq.327.1641416644559; Wed, 05 Jan 2022 13:04:04 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id r1sm88444wrz.30.2022.01.05.13.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 13:04:04 -0800 (PST) Message-ID: <1e4755f3697d54b751684210215a1337c101f4ca.camel@gmail.com> From: Liliana Marie Prikler Date: Wed, 05 Jan 2022 22:04:03 +0100 In-Reply-To: <4e443a9e-e024-d641-14cd-e36ef7cae46d@philipmcgrath.com> References: <082a81964a43ae5f735ad2ca433d0dfe00859c35.camel@gmail.com> <20211230073919.30327-1-philip@philipmcgrath.com> <20211230073919.30327-6-philip@philipmcgrath.com> <7d5dd434d7750123fa32cb623df0463d60d3f82f.camel@gmail.com> <23eaa7e6-c087-d885-924a-192917758bbf@philipmcgrath.com> <5b83ba5e35af7ac956a6d5de41cb98a892863b55.camel@gmail.com> <4e443a9e-e024-d641-14cd-e36ef7cae46d@philipmcgrath.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641416717; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SWTyzknieGH67dp2h0yN7SYu+5gKUqmQCHckxqRyzxU=; b=bsYVyCZth6BWACJa/HqyjcrZTgmo4UP0Xzgu+d5wBwzyMW+K9SPXE/Laf6vnk0NDJ5Iu+3 0ZE9jDq6X5AKos/NFZmZWRtbboeStRHd+v/dRvJvl76KXt76Mvkj1cLVkEmg7QynJ6BPB4 r15qNMX0tSOSSzMkkQKT/svwzo6syFpCHl6IyRBrrPNKIdG7BYDyksc7pCxElj15cmqGVh tE4VgjoG63plsybl0//nbU2HJB5cPXNi0q6nXrRns8QxbtRJahQ2aQuOd9PxQSgWQyA5F1 IZ4P5lKIS25+8Bz2yWbqwkAZTk74StS5tFuiIQwRm1y2DfCNo/VBz7Rigmlytw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641416717; a=rsa-sha256; cv=none; b=BX4nsnNfoBz9P1yicxljrMqT6dcItNikvYAmcqnw7K6KPWNAqx30pwaenBKvcnl0+euz8M IzKIUIM+fh4BtxoQEqyd41XhTzxtgCa5Jdgq/Lqhh8T8tIIKnDvIttIi/b3ODPeQCP6cUK YqT/M5iULkvRePkiLUoE4uerGc9xBVwHqP3GKg7NTPzKBuw8yEXc+GZ3LpgZ0aLfkUOypd ioazDY9A6b3+8xd8uDVyz0KUB4ZuEVh+0ysxXxA1/oSRfxXHSri70y7rhERwHa+caAhS4i BCw4AkNaDShyTGJBrAhxxi2GBITK4XPiHQcoo0dQpP8c8WKEIqqPZnS4nhU+Ng== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="j1Jotcj/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="j1Jotcj/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4AABD312EB X-Spam-Score: -2.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: JnZkwtotjjrl Hi, Am Mittwoch, dem 05.01.2022 um 14:08 -0500 schrieb Philip McGrath: > I will admit that I am more than a little frustrated that, having put > aside my own reservations and implemented the compromise proposal it > seemed everyone could live with, it now seems that the consensus was > in fact illusory. Moreover, I still do not understand what specific > changes I could send in a v8 that would get this patch series to a > state where everyone would agree it could be applied. To be honest, I should do part of my job as well here and apply some of my own suggestions as I push if you deem them reasonable. I think that'd get us to consensus in one iteration. > > I don't know what to make of this comment, and I especially don't > understand what the notorious left-pad incident has to do with my > views. Aside from its inflammatory nature, I think left-pad is a > confusing way to make a point because many people have tried to make > it "stand for" many different, perhaps even mutually contradictory, > conclusions. Point taken, I'll try to dedent my Javascript jokes. > In case it helps at all to state my position more fully: with or > without Guix, I think a major purpose, perhaps even the primary > purpose, of _any_ build system is to relieve users (including > ourselves) of the cognitive burden of lower-level details. Build > systems are a means of abstraction and encapsulation. > > [...] I agree with you that abstractions ought to help, but we do have some disagreements about the amount by which certain abstractions help. Those are gut feeling value judgements, they're not all entirely rational. > I hope this is just a matter of some nuance in the connotation of > the word "gratuitous" not coming across properly, but I would > appreciate the same consideration being extended to my perspective. > > Almost tautologically, I don't think adding '#:absent-dependencies' > would be gratuitous, or I wouldn't have proposed it. Generally, keywords are reserved for a few special operations. I don't currently have the time to write them all up, but suffice it to say I don't believe the way #:absent-dependencies would be used fits into any of those. I can write that up in a later message if you feel it's imporant enough. > From my perspective, though, the substance of these patches has been > ready to go for something like six weeks now, and the few > enhancements since then could easily have been small follow-on > patches. I would consider it very regrettable if this patch series > were to continue to be blocked by stylistic considerations > in the implementation of unexported helper functions. That's not at all my intention. I'll write up a checklist as a follow- up. We can go over these shortly and I'll have v6 with minor adjustments land hopefully soon (if it can't be done tomorrow I'll shoot for Sunday). Would that be acceptable?