From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:42703) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihcFz-0002u9-J8 for guix-patches@gnu.org; Wed, 18 Dec 2019 11:33:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihcFy-0007uM-BO for guix-patches@gnu.org; Wed, 18 Dec 2019 11:33:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37860) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ihcFy-0007sA-4Y for guix-patches@gnu.org; Wed, 18 Dec 2019 11:33:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ihcFy-000610-0l for guix-patches@gnu.org; Wed, 18 Dec 2019 11:33:02 -0500 Subject: [bug#38640] [PATCH] Add ripgrep and many rust dependencies Resent-Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Wed, 18 Dec 2019 08:32:57 -0800 From: Martin Becze In-Reply-To: References: <002582d46228db8739fc12c0404ad177@riseup.net> Message-ID: <1e0988ded5edd72803b0660004614db0@riseup.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: John Soo Cc: Guix-patches , 38640@debbugs.gnu.org On 2019-12-17 17:10, John Soo wrote: > HI everyone, > > I did some work on your review and have a couple questions before I > submit the next patchset. > > * My questions for Martin: > >> I'm trying to convince everyone to leave in the crago-inputs >> dependencies and add a "#:skip-build? #t" to the build arguments for > all >> source pakages. That way we don't have to specify the transient >> dependencies at the top level package. > > I like this idea. I think I will do it if you don't mind. It's either > that or add hidden? #t to the properties, right? > Whether to add #skip-build? #t to the packages is the last piece of > review I need to fixup. So the ` hidden? #t ` also hides the package from (find-packages*) functions in (gnu packages). I actully want to be able to search for and use rust libraries with guix, so I prefer not to hide them.