On 2015-08-05 11:11, Ricardo Wurmus wrote:
> Hi Daniel,
> 
> unfortunately, the commit message is still not correct.  It’s all on 
> one
> line and “gnu: enlightenment:” should be “gnu:” instead.  If you use
> “git commit” without “-m” you can edit the message in your default
> editor (configurable by setting the EDITOR variable).
> 
>> +(define-public rage
>> +  (package
>> +    (name "rage")
>> +    (version "0.1.4")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri
>> +               (string-append
>> +                
>> "http://download.enlightenment.org/rel/apps/rage/rage-"
>> +                version ".tar.gz"))
>> +              (sha256
>> +               (base32 
>> "10j3n8crk16jzqz2hn5djx6vms5f6x83qyiaphhqx94h9dgv2mgg"))))
>> +    (build-system gnu-build-system)
>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)))
>> +    (inputs
>> +     `(("efl" ,efl)
>> +       ("elementary" ,elementary)))
>> +    (home-page "http://www.enlightenment.org")
> 
> The home page for “rage” actually seems to be
> https://www.enlightenment.org/about-rage
> 
>> +    (synopsis "Powerful video play based on EFL")
> 
> “video play” –> “video player”.  Not sure if “Powerful” is a good word
> for a synopsis.  What makes it powerful?  If this cannot be expressed
> within the limited space of a synopsis it should be omitted.
> 
>> +    (description
>> +     "Rage is a video and audio player written with Enlightenment 
>> Foundation Libraries
>> +with some extra bells and whistles.")
> 
> This line looks a little too long.  When in Emacs please just use M-q 
> to
> break the long line according to our limits.
> 
> ~~ Ricardo
Thanks Ricardo,

I did the corrections using emacs editor and I did commit based on logs 
(see git log). It's right now?

-- 
Daniel Pimentel (d4n1 3:)