Re: [PATCH] Update enlightenment.scm: Add Rage Player

[Daniel Pimentel <d4n1@openmailbox.org>]

[-- Attachment #1: Type: text/plain, Size: 1921 bytes --]

On 2015-08-05 11:11, Ricardo Wurmus wrote:
> Hi Daniel,
> 
> unfortunately, the commit message is still not correct.  It’s all on 
> one
> line and “gnu: enlightenment:” should be “gnu:” instead.  If you use
> “git commit” without “-m” you can edit the message in your default
> editor (configurable by setting the EDITOR variable).
> 
>> +(define-public rage
>> +  (package
>> +    (name "rage")
>> +    (version "0.1.4")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri
>> +               (string-append
>> +                
>> "http://download.enlightenment.org/rel/apps/rage/rage-"
>> +                version ".tar.gz"))
>> +              (sha256
>> +               (base32 
>> "10j3n8crk16jzqz2hn5djx6vms5f6x83qyiaphhqx94h9dgv2mgg"))))
>> +    (build-system gnu-build-system)
>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)))
>> +    (inputs
>> +     `(("efl" ,efl)
>> +       ("elementary" ,elementary)))
>> +    (home-page "http://www.enlightenment.org")
> 
> The home page for “rage” actually seems to be
> https://www.enlightenment.org/about-rage
> 
>> +    (synopsis "Powerful video play based on EFL")
> 
> “video play” –> “video player”.  Not sure if “Powerful” is a good word
> for a synopsis.  What makes it powerful?  If this cannot be expressed
> within the limited space of a synopsis it should be omitted.
> 
>> +    (description
>> +     "Rage is a video and audio player written with Enlightenment 
>> Foundation Libraries
>> +with some extra bells and whistles.")
> 
> This line looks a little too long.  When in Emacs please just use M-q 
> to
> break the long line according to our limits.
> 
> ~~ Ricardo
Thanks Ricardo,

I did the corrections using emacs editor and I did commit based on logs 
(see git log). It's right now?

-- 
Daniel Pimentel (d4n1 3:)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0004-gnu-Add-Rage-player.patch --]
[-- Type: text/x-diff; name=0004-gnu-Add-Rage-player.patch, Size: 1225 bytes --]

From 11acae5bf4cbad9bb5d8707989e53074c647ef8c Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@member.fsf.org>
Date: Wed, 5 Aug 2015 11:22:15 -0300
Subject: [PATCH 4/4] gnu: Add Rage player.

* gnu/packages/enlightenment.scm: Change URI in home-page and description.
---
 gnu/packages/enlightenment.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenment.scm
index 5aa6525..48b9a32 100644
--- a/gnu/packages/enlightenment.scm
+++ b/gnu/packages/enlightenment.scm
@@ -255,11 +255,11 @@ contents and more.")
     (inputs
      `(("efl" ,efl)
        ("elementary" ,elementary)))
-    (home-page "http://www.enlightenment.org")
-    (synopsis "Powerful video play based on EFL")
+    (home-page "https://www.enlightenment.org/about-rage")
+    (synopsis "Video and audio player based on EFL")
     (description
-     "Rage is a video and audio player written with Enlightenment Foundation Libraries 
-with some extra bells and whistles.")
+     "Rage is a video and audio player written with Enlightenment Foundation
+Libraries with some extra bells and whistles.")
     (license license:bsd-2)))
 
 (define-public enlightenment
-- 
2.4.3