From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SAvTM0ui8GKSegEAbAwnHQ (envelope-from ) for ; Mon, 08 Aug 2022 07:42:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4OmOM0ui8GLkRQEAauVa8A (envelope-from ) for ; Mon, 08 Aug 2022 07:42:35 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4318431A57 for ; Mon, 8 Aug 2022 07:42:35 +0200 (CEST) Received: from localhost ([::1]:44286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oKvX8-0005h8-D7 for larch@yhetil.org; Mon, 08 Aug 2022 01:42:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKvWd-0005gv-U5 for guix-patches@gnu.org; Mon, 08 Aug 2022 01:42:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49008) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oKvWc-0006J0-Jy for guix-patches@gnu.org; Mon, 08 Aug 2022 01:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oKvWc-00021h-Cs for guix-patches@gnu.org; Mon, 08 Aug 2022 01:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56699] [PATCH v2] gnu: greetd-service-type: Add greeter-extra-groups config field. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Aug 2022 05:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56699 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: muradm , 56699@debbugs.gnu.org Cc: "\(" Received: via spool by 56699-submit@debbugs.gnu.org id=B56699.16599372977757 (code B ref 56699); Mon, 08 Aug 2022 05:42:02 +0000 Received: (at 56699) by debbugs.gnu.org; 8 Aug 2022 05:41:37 +0000 Received: from localhost ([127.0.0.1]:38757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKvWC-000212-R9 for submit@debbugs.gnu.org; Mon, 08 Aug 2022 01:41:37 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:33390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKvW8-00020p-FX for 56699@debbugs.gnu.org; Mon, 08 Aug 2022 01:41:35 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4M1Q6x3NcWz1LBRv; Mon, 8 Aug 2022 07:41:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4M1Q6x3NcWz1LBRv DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1659937289; bh=NJI7iz7CfAOxrPRsCZOyJwo9i4i47kmqVirXEMv4mh4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=K7Whn8r1Cv8gJ03bZb7fl7KW/5wJNC0M2TW6NJ53QN3/zt9jCyfnbJnnSvWEuWOzc 6qp3sNigig2M8gtsJuc+LmdByESTTBNStd6VmhheWa6IDQASxm80GBcoqNWeQrGpgT DGaAW7D5Gy/hlcMFYLfwh/UQy7/upJHhp9iaJM+Q= Message-ID: <1d138ba85a305947acc267d995179effd6be0edd.camel@ist.tugraz.at> From: Liliana Marie Prikler Date: Mon, 08 Aug 2022 07:41:35 +0200 In-Reply-To: <20220807214804.22323-1-mail@muradm.net> References: <874jyn20et.fsf@muradm.net> <20220807214804.22323-1-mail@muradm.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659937355; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NJI7iz7CfAOxrPRsCZOyJwo9i4i47kmqVirXEMv4mh4=; b=Ny7tbeNXaUbWhHcod9KLjLpvNWOShUrvKIWGJV3iCUA1G+mylQ53DTlSB1uix+Q169MLyJ ljkCQgVDpLFZR5jzjSQokcBYAwuyW8QmUzWhINz7Pt2TgA06IwBCcZgzp/g8ayVpLDN/8N vTtOh6Pnw/03xWKJt0TSr1nDXNKEEoziKlEvJ1lw1lc5LXVphjhOH/NdZCGHVN6sS5ewqi McHm4S3GZBOd8tW0KPVltBrh2/DRfm3TyFaPzSMnS3S7Bo07ZReIOgm+EUufvyYMkiAelm rUlSarhdWnuQlTYZ6FQ0ZbFTg2Qkj8BYUxmblBiLraV20ijR7zvOsHMKrn/5Dg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659937355; a=rsa-sha256; cv=none; b=FTbdvaxhCYbAyYOe6gB3Gxp5mXXbquNoysHaOK8+Rwqzz0KhuGtySeQgC9cTrkMTc8MqR5 16cta3CcwRAnDUZROLzrY5582JC/NQ90qZWtXOZYsIEPcKhNPDFtHXWkRJripFLJZzaNpN YEejhPcT/jcSMIP3GnVTGTtA2Kru7PnBtQEApJSi2UYCKn2XPelyuONWRiNkTrGk2et6vL 0Y+AsDRyJO0RpwrCjYa+M+hRuDQZh8zgYMRrwr6OW7R5xOeDS2XahE3iSa/KHbOkki2t1v SGDnWQ5ZLpkUt7/rnb+sHBquckNoulHVV+S9kF7IrLaBjw+Ffi+JK/e11txGuQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=K7Whn8r1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.91 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=K7Whn8r1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4318431A57 X-Spam-Score: 5.91 X-Migadu-Scanner: scn1.migadu.com X-TUID: XiUnt6KLps3h Am Montag, dem 08.08.2022 um 00:48 +0300 schrieb muradm: > --- >  doc/guix.texi         |  8 ++++++++ >  gnu/services/base.scm | 24 +++++++++++------------- >  gnu/tests/desktop.scm |  7 +++++++ >  3 files changed, 26 insertions(+), 13 deletions(-) > > diff --git a/doc/guix.texi b/doc/guix.texi > index 21cee4e369..2b09bea3b0 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -18509,6 +18509,14 @@ the 'root' account has just been created. >  @item @code{terminals} (default: @code{'()}) >  List of @code{greetd-terminal-configuration} per terminal for which >  @code{greetd} should be started. > + > +@item @code{greeter-groups} (default: @code{'()}) > +List of groups which should be added to @code{greeter} user. For > instance: > +@lisp > +(greeter-groups '("seat" "video")) > +@end lisp > +Note that, however it will fail if @code{seatd-service-type} is not > present, > +or to be more specific, @code{seat} group is not present. Note that this example will fail if the @code{seat} group does not exist. > +  (greeter-groups greetd-greeter-groups (default '()))) I think, we can err a little on the side of verbosity here and make clear that it's greeter-supplementary-groups. Other than that LGTM