From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZtCB-0004f7-Ow for guix-patches@gnu.org; Fri, 12 Jan 2018 01:52:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZtC6-0000L7-TH for guix-patches@gnu.org; Fri, 12 Jan 2018 01:52:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:44908) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZtC6-0000Ki-PT for guix-patches@gnu.org; Fri, 12 Jan 2018 01:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eZtC6-0002QX-C8 for guix-patches@gnu.org; Fri, 12 Jan 2018 01:52:02 -0500 Subject: [bug#28773] [PATCH] Wrap bin files in the ruby build system. Resent-Message-ID: References: <20171010084452.036b3052@cbaines.net> <877evvdycy.fsf@gnu.org> <87k1wom5j9.fsf@gnu.org> From: Ben Woodcroft Message-ID: <1b7ecb41-7ba7-2fa9-2e7d-c2e6cc008314@uq.edu.au> Date: Fri, 12 Jan 2018 16:51:07 +1000 MIME-Version: 1.0 In-Reply-To: <87k1wom5j9.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 28773@debbugs.gnu.org Hello! On 12/01/18 07:47, Ludovic Courtès wrote: > Hello! > > Ben Woodcroft skribis: > >> On 16/10/17 23:19, Ludovic Courtès wrote: >>> Hi Chris, >>> >>> Christopher Baines skribis: >>> >>>> This is a bit experimental. There is some description of the motivation >>>> behind this approach, as well as the downsides in the commit messages. >>>> >>>> I don't know how to wrap binaries with the GEM_PATH, but somehow >>>> excluding inputs specified as native-inputs, so I'd be very interested >>>> if anyone has ideas about this. >>>> >>>> Christopher Baines (3): >>>> ruby-build-system: Add wrap-ruby-program. >>>> ruby-build-system: Add a new wrap phase. >>>> gnu: Remove redundant wrapping from packages using ruby-build-system. >>> Cc’ing Ben who is another Serious Ruby User I think. :-) >> Maybe sometimes. I'll try to get a review back to you in the next week >> or so. > Ahem. :-) > > Chris, if you’re confident, I’d say you can go ahead. It does sound > like an improvement so it’d be sad to lose it. Ah yes, my apologies. Yes, this series LGTM, and it worked fine when I applied it in local packages too. Thanks. ben