From mboxrd@z Thu Jan 1 00:00:00 1970 From: dpg Subject: Re: Re: [PATCH] gnu: Add python2-gyp Date: Mon, 05 Feb 2018 18:23:30 -0500 Message-ID: <1CF1B1F8-E152-4B4F-AAB3-6E7BF86B23EC@gmail.com> References: <1517631607.29145.3.camel@gmail.com> <87bmh3d17c.fsf@gnu.org> <1517870390.6194.8.camel@gmail.com> <20180205231125.GA22963@jasmine.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiq6s-0005lF-Vr for guix-devel@gnu.org; Mon, 05 Feb 2018 18:23:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eiq6r-0000y9-Uo for guix-devel@gnu.org; Mon, 05 Feb 2018 18:23:38 -0500 In-Reply-To: <20180205231125.GA22963@jasmine.lan> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: "guix-devel@gnu.org" On February 5, 2018 6:11:25 PM EST, Leo Famulari wro= te: >On Mon, Feb 05, 2018 at 05:39:50PM -0500, dpg wrote: >> Sending a new patch, this will apply cleaner and has an actually good >commit >> message :-)=20 > >Thanks! But it still didn't apply :) > >> From 300c37a8d9818cfc1a6315d2113cf58b110e1664 Mon Sep 17 00:00:00 >2001 >> From: DoublePlusGood >> Date: Mon, 5 Feb 2018 17:26:34 -0500 >> Subject: [PATCH] gnu: python: Add python2-gyp >>=20 >> * gnu/packages/python=2Escm: Added python2-gyp library=2E > >> + ;; Google does not release versions, >> + ;; based on second most recent commit date=2E >> + (version "2017-10-11") > >As described in the manual section Version Numbers, we handle >versioning >of version control checkouts in a specific way: > >https://www=2Egnu=2Eorg/software/guix/manual/html_node/Version-Numbers=2E= html#Version-Numbers > >This allows us to ensure that the versions always increase and can be >used to refer back to the upstream version control repository=2E At least >in Git, dates are not meaningful=2E They can be set to anything with the >--date parameter=2E > >We also have the special helper functions git-version and git-file-name >to make it easy to use the standard versioning scheme=2E > >I standardized the version and source file-name as in the attached >diff, >standardized the commit message, updated the copyright date, and pushed >the result as commit 956ba99cb799889e0a0bc0f657f4e31b4f830775=2E Wow, thank you! I have a couple other patches on my personal branch and I'= ll be sure to apply similar changes=2E --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E