From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qE4iKDxiGmLpAwAAgWs5BA (envelope-from ) for ; Sat, 26 Feb 2022 18:24:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IFWDJTxiGmKA0QAA9RJhRA (envelope-from ) for ; Sat, 26 Feb 2022 18:24:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E889F4759C for ; Sat, 26 Feb 2022 18:24:11 +0100 (CET) Received: from localhost ([::1]:42438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nO0ni-0002Ne-KQ for larch@yhetil.org; Sat, 26 Feb 2022 12:24:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nO0na-0002NO-6Y for guix-patches@gnu.org; Sat, 26 Feb 2022 12:24:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34148) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nO0nZ-0004UI-UC for guix-patches@gnu.org; Sat, 26 Feb 2022 12:24:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nO0nZ-0002zF-KM for guix-patches@gnu.org; Sat, 26 Feb 2022 12:24:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53878] [PATCH v5 03/22] gnu: racket: Use Git origins for Racket packages. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 26 Feb 2022 17:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53878 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53878@debbugs.gnu.org, zimoun , Liliana Marie Prikler Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxime Devos , Liliana Marie Prikler , raingloom , Attila Lendvai , Malte Gerdes Received: via spool by 53878-submit@debbugs.gnu.org id=B53878.164589620911415 (code B ref 53878); Sat, 26 Feb 2022 17:24:01 +0000 Received: (at 53878) by debbugs.gnu.org; 26 Feb 2022 17:23:29 +0000 Received: from localhost ([127.0.0.1]:56274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nO0n3-0002y3-6t for submit@debbugs.gnu.org; Sat, 26 Feb 2022 12:23:29 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:34745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nO0n0-0002xn-2c for 53878@debbugs.gnu.org; Sat, 26 Feb 2022 12:23:27 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 0170958017F; Sat, 26 Feb 2022 12:23:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 26 Feb 2022 12:23:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= philipmcgrath.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=HiP9HMgZIgAVA3 N1rfhkULGbKBNkVNWUAUOQAvlE4Gs=; b=U18bFD6X5HNsXc49NCOi6RAsAhUwtY y41WyGNU17gBIoZK5kTJ6b57gWKy2D9jY1D78Vm538MQlYTtdk/3FAxKwamHMlJD 2pExoHe9BJzQpVsnliq/WOGyegWjVvuHJHoji53pZiLCeDDtk5KvEPgh6V9BSrrk 89rZnHsbW1XebhdW/m1UqMD1VSc0llOJ3/gEFebRMHMC5Btb/5Hss43lffP7NBV5 o/wVThb1xcEzTlPXv9hWTp8qYV7R7b1T9hsMZBLHBKchJMD2nG2cW4djeGDnkD6M wcIStl3wBLK2AFjSAcTUCCray7lonVUDvfjgsvGLa2maVktGjTebwQ/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=HiP9HMgZIgAVA3N1r fhkULGbKBNkVNWUAUOQAvlE4Gs=; b=F0YpMgQeAzyhcgG8lNTOd4CnjjrPH9hNN QH8UmaH9YElBDHwdRLGKxWYj2T4R2T3V6FBjf5+NR2boorJfAQmaj7SpO2zXtK4p +r+UfMVqCafKUM9RHHMP4H+Cf43lIvc9F+TCimkYCJ/vXE+/PYC9Z5KPIxSzCBsr 2Travl4LkrMNrfF/9/7U3WLY+oVxW8/c/UzEuL8YwrP0DAJPeUa+9JKxYu9t+ZjD AH3gB5gfhTLHpQPvCWR9ksDHjWikmmEDrobklPfHtpmsltQwupV3tMd0jXkR5spZ FXbMPCC4HqIBSrqzF0+lZ61ga+1xItN8usKOYzETYDyxBQUk9inRg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrleeigdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfgggtsehgtderredttddvnecuhfhrohhmpefrhhhilhhiphcu ofgtifhrrghthhcuoehphhhilhhiphesphhhihhlihhpmhgtghhrrghthhdrtghomheqne cuggftrfgrthhtvghrnhepkeegtedtveffueejleejueelvdevfeeivdeihfduveehueev hfffuefhieefhedtnecuffhomhgrihhnpehgihhtlhgrsgdrtghomhenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehphhhilhhiphesphhhihhl ihhpmhgtghhrrghthhdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 26 Feb 2022 12:23:18 -0500 (EST) From: Philip McGrath Date: Sat, 26 Feb 2022 12:23:17 -0500 Message-ID: <19823080.dSP1spjjOr@bastet> In-Reply-To: <0c9963cedab248085b106effdd68649647a41ca2.camel@ist.tugraz.at> References: <20220220060610.178131-1-philip@philipmcgrath.com> <3354324.gHnXMxdNb5@bastet> <0c9963cedab248085b106effdd68649647a41ca2.camel@ist.tugraz.at> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart26267686.q7ltLs4Q0i"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645896252; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=HiP9HMgZIgAVA3N1rfhkULGbKBNkVNWUAUOQAvlE4Gs=; b=FA67vUKdf+xO5DMada8dM/irVCLqcaVDC1Ak4c/BiTXIrciMuYooAJtESl67x+yukI5iRi c68L4x7wi+cXk44Uo/V6ztDa2LoFRj71+KqcqpD0GlY/8PoVq6CtYOEtxqS0weebIVGA/d XALQJN/3+fbEAwYJOU2RjWp0r0GU4q6Ide60dxClTK2LB8Uw0qLib/ILv/ZfmjUyWeNg0+ pcf2rWe0TLv6oXwJGQS7NY31SQlaL/K/9NfhdOuGJ5sRmM7Ka5bto9h2b8i8hxvP/B6sg7 fvM2eA0chXL/KaBE3HZOvk7s8pD1vLvzE2gq8YaBfWpSZRUKtPjlbhDx2Jjizw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645896252; a=rsa-sha256; cv=none; b=plF01sV8H0DJfDGnLTaE0uVly195VH2mRaAo0P/qNqnN9HsNcagyMlPpHs3OwYijMbnH9M x7IW9W4dFY4U9ZqeSFtGSDw8D2OpEfpIAL/U4fh9lnQ1K8C/4gIvJxrNQFll3pAXSoK9F9 YlklzvFECG7O3EKIfvQG5KX3oZ52NSjHAe7HVkWRtTV68+zaxE00ZvB2P+s1qZmUS0pPNX a1ZvC40XPRQPDybnHucZyuJB5gkie4T9SUqxE+bA1VewbQUrHTO4SnLiwh/Y8iaYx5BJx6 XZcZHhDUAfpZwTIEvavVfR8TGGpiCg5GA9E0FNOGS6QwJA3w9vN6qeXQ6oq8UA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm1 header.b=U18bFD6X; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=F0YpMgQe; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm1 header.b=U18bFD6X; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=F0YpMgQe; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E889F4759C X-Spam-Score: -0.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: I7XY2ik0YT7s --nextPart26267686.q7ltLs4Q0i Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Philip McGrath To: 53878@debbugs.gnu.org, zimoun , Liliana Marie Prikler Cc: Ludovic =?ISO-8859-1?Q?Court=E8s?= , Attila Lendvai , Malte Gerdes , raingloom , Maxime Devos , Liliana Marie Prikler Subject: Re: [PATCH v5 03/22] gnu: racket: Use Git origins for Racket packages. Date: Sat, 26 Feb 2022 12:23:17 -0500 Message-ID: <19823080.dSP1spjjOr@bastet> In-Reply-To: <0c9963cedab248085b106effdd68649647a41ca2.camel@ist.tugraz.at> References: <20220220060610.178131-1-philip@philipmcgrath.com> <3354324.gHnXMxdNb5@bastet> <0c9963cedab248085b106effdd68649647a41ca2.camel@ist.tugraz.at> Hi, On Saturday, February 26, 2022 9:26:29 AM EST Liliana Marie Prikler wrote: > Am Samstag, dem 26.02.2022 um 09:20 -0500 schrieb Philip McGrath: > > On Saturday, February 26, 2022 8:47:45 AM EST Liliana Marie Prikler > > > > wrote: > > > First, can we simplify "make-installation-layer.rkt" to "make- > > > installation-layer"? I don't think the file extension conveys much > > > meaning here, or does it? > > > > To me (I don't know about anyone else), the ".rtk" extension tells me > > that I have to pass the file as an argument to `racket`, i.e. that > > the file is not a launcher from `raco exe` or a script with a shebang > > that I could `invoke` directly. > > I'm not talking about the generated file, but the procedure that > generates it. Special characters like dots and slash are still pretty > special in Scheme, even if they're allowed as identifiers. > Do you mean A, B, C, and/or D of these: a > (replace 'configure > (lambda* (#:key inputs configure-flags #:allow-other-keys) > (let* ((racket (search-input-file inputs "bin/racket"))) > (apply invoke > racket > #$make-installation-layer.rkt ;; <--- A > `(,@configure-flags > ,(dirname (dirname racket)) > ,#$output)) > (invoke racket > "--config" (string-append #$output "/etc/racket") > "-l" "raco" "setup" > "--no-user")))) > > [...] > > (define make-installation-layer.rkt ;; <--- B > (scheme-file > "make-installation-layer.rkt" ;; <--- C > `(module > make-installation-layer racket/base ;; <--- D > (require racket/cmdline or something else? In particular, not to be dense, but B is not a function. One of the reasons I particularly like being able to use `.` in identifiers is to refer to files by name, without some ad-hoc encoding. > > > I think some way to shorten those origins would do wonders in terms > > > of the number of lines this patch adds. > > > > At one point, I had abbreviated the origins as something like: > > > > (REPO-SPEC SHA256 [COMMIT]) > > > > [...] > > I wouldn't do this inside of extract-package-source, but define a one > or two liner for adding specifically packages hosted on racket's > github. WDYT? > > > I wasn't sure about the trade-off between being slightly more cryptic > > than explicit origins, but a lot shorter. > > Note that the goal is not to code golf, but to be understandable. When > adding a bunch of origins as inputs, understandability suffers by > induced scrolling. > I've done this, and it was a very good idea. In particular, it helped find some places where I hadn't switched to using `%racket-commit` once the release was tagged. Other than potentially doing something about "make-installation-layer.rkt", I'd plan to squash the WIP/FIXUP commits in and send it as v6. -Philip --nextPart26267686.q7ltLs4Q0i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE9GWrrNY3rqwUFVXPygNjjfo/HHoFAmIaYgUACgkQygNjjfo/ HHpiYBAAhgNqtXQh02QvMmLy9w9ratJOeVlrOJrw2lHS69FenYboVB1VMcxE2sy2 A2RN0UgA2F5tkaslTwy9HTVd4a7zv54rW71Xxw5n8mN458vV5ev+GcsraDYqBOrA ATwi3Dri7hL6FDH9GOmA1A9cQTIFehzAh+8JfjN0ye0uEFZYj2m0xQMZjNgDfzKl 18dYbwiDVTRfHzer1E5PmlrgnBoow4ZSxC/QA10aFDQNw1ecsYdeqx45v4UUCTwQ NgJkfWWMA4BRhPxz4y+2pUUzNHIjFfV0bL/ewpDz0Woj2VSzK+PzWOR6owKB2g8s Q1bX6vo7y3mzH8I1p9485H9aCUeXFmbnReglqyRW/+Axw855GZ94aNT6RgnesyZW dpSpm3OnLNF0yuLfb5ujlr2OUWyQWEA82VKhGVBjiB2EZQsPt7JYMmOMmxi5hNRC v++00gLG5V+HQnccm4Bk5+gqH63BipFvu32JE45I/CqEvSBFMlx5cWrbUvw7KR1z ST9BBfKSoqIhWQof6ya9RVvhlRQCfZU3XivQLk3hgJr0NO0x5DrlEJaOtFuFOjZP z35C4FQTPt6IfqMxwFRr+tRyJIQd/ZQBcH4R/J19FOW5mTUMJT8VhL23t6aXisYX LJaqLHgdKSM23/mNDIWKu80m41UCTMY7MwxFEPuPH0C6qRX62mQ= =HkXh -----END PGP SIGNATURE----- --nextPart26267686.q7ltLs4Q0i--