From: Sharlatan Hellseher <sharlatanus@gmail.com>
To: 74992@debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus@gmail.com>,
Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
Sharlatan Hellseher <sharlatanus@gmail.com>
Subject: [bug#74992] [PATCH] import/go: Fix #:go formation.
Date: Mon, 23 Dec 2024 02:48:31 +0000 [thread overview]
Message-ID: <18f7d731f7d9e3f3003cf9ef4f8d9aca5b7c8a90.1734922057.git.sharlatanus@gmail.com> (raw)
In-Reply-To: <d971cdc3-b960-49e7-93a3-6393fc0e5b64@msavoritias.me>
Reported by MSavoritias <email@msavoritias.me> in #74992 "guix import go
package definition is not valid". This change fixes it: instead of
"#:go 1.22" will produce "#:go go-1.22".
* guix/import/go.scm (go-module->guix-package): Fix format for #:go key
argument.
Change-Id: I9db0688b8e2970f5e90b415966d39b45505b7c8e
---
guix/import/go.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/guix/import/go.scm b/guix/import/go.scm
index 32cba25b33..915846bed1 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -704,7 +704,9 @@ (define* (go-module->guix-package module-path #:key
(build-system go-build-system)
(arguments
(list ,@(if (version>? min-go-version (package-version (go-package)))
- `(#:go ,(string->number min-go-version))
+ `(#:go ,(string->symbol
+ (format #f "go-~a"
+ (string->number min-go-version))))
'())
#:import-path ,module-path
,@(if (string=? module-path root-module-path)
base-commit: 30fdffc4b5605431b28a23b03330e850b2184a76
--
2.46.0
prev parent reply other threads:[~2024-12-23 3:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 10:32 [bug#74992] guix import go package definition is not valid MSavoritias via Guix-patches via
2024-12-20 23:57 ` Sharlatan Hellseher
2024-12-23 1:02 ` Sharlatan Hellseher
2024-12-23 2:48 ` Sharlatan Hellseher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18f7d731f7d9e3f3003cf9ef4f8d9aca5b7c8a90.1734922057.git.sharlatanus@gmail.com \
--to=sharlatanus@gmail.com \
--cc=74992@debbugs.gnu.org \
--cc=cox.katherine.e+guix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.