From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id IDXpB+BrLWUuvQAA9RJhRA:P1 (envelope-from ) for ; Mon, 16 Oct 2023 18:59:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IDXpB+BrLWUuvQAA9RJhRA (envelope-from ) for ; Mon, 16 Oct 2023 18:59:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E6CEF3B72A for ; Mon, 16 Oct 2023 18:59:11 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VP5ddtYx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697475551; a=rsa-sha256; cv=none; b=dEG8fId69RDeMtjcVU+JVRdt6TwAenF/XmT5e5+4ybVGCvGVWbw382KV7zwGiaqDh/02NK rcLpCTjwxG9brz7QfK/JZAbtD1w2WngqiCpdglUhXKl4lSdJ0q16hY963zoLU1jW7n1frD tmzOWbLAXnaWk/brIPUXObgw8GG0VDLR7E0KZlvs4wYr7CPXPbc+hzjDxAquYIpzwzPb0d L+3sKL0UceaDAndUNzHEmJt3GVVEu76ATCXqnSygkzWtMLIFfKf1wkqHGoLKe0b789sMkn nWLPWNgnATItgTNnYYIDcjt1Q2glNzS3mKahrzG2a+77jhDhG6iSMmyd84+rQA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VP5ddtYx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697475551; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Vi5Ul3UZ9LBIYwqvL6EKf3utIfwTxDXIM3hqeP7kIGU=; b=UuxqM/oaZkrEDgXduj8IWFKYKCfuVSuRzuzswBBuhvdkqz0FOvMR4yAMPSQzmOX9M/i1fF yoCIoGE3IQHhc+zDcJnfDlKKZHe2cVM9YkJjkZK/70MuGJk3tpgO8D4+K3telev47dF5a/ H8tqE1Gzl4twHTIjk3TyDL/rGXFwp/TpSokbihv5YZXNSCGN9Qzto9XhuWqVvjPgO/xNQ6 fvqczHEGKVPgpWA4BLFTwPUfFkfiu23k4lrnXZw6BfbOit/bbJysZMRySOexPvd1CRv+6e lMVAzZrmPGWULyrr2QXhtiqEEK+Fm08zU620FIsNqN6+c0PY9dx0U8RDeWcG7g== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qsQvO-0002rv-LS; Mon, 16 Oct 2023 12:58:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsQvN-0002rk-Rp for guix-patches@gnu.org; Mon, 16 Oct 2023 12:58:37 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qsQvN-0008WU-Jo for guix-patches@gnu.org; Mon, 16 Oct 2023 12:58:37 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qsQvm-0002y5-5A for guix-patches@gnu.org; Mon, 16 Oct 2023 12:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66562] [PATCH v3] gnu: emacs-haskell-snippets: Use correct directory for snippets. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Oct 2023 16:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66562 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Rostislav Svoboda Cc: 66562@debbugs.gnu.org Received: via spool by 66562-submit@debbugs.gnu.org id=B66562.169747551511361 (code B ref 66562); Mon, 16 Oct 2023 16:59:02 +0000 Received: (at 66562) by debbugs.gnu.org; 16 Oct 2023 16:58:35 +0000 Received: from localhost ([127.0.0.1]:57712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsQvL-0002xB-9n for submit@debbugs.gnu.org; Mon, 16 Oct 2023 12:58:35 -0400 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:59450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsQvG-0002ws-PP for 66562@debbugs.gnu.org; Mon, 16 Oct 2023 12:58:33 -0400 Received: by mail-ed1-x542.google.com with SMTP id 4fb4d7f45d1cf-53d82bea507so8334257a12.2 for <66562@debbugs.gnu.org>; Mon, 16 Oct 2023 09:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697475479; x=1698080279; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Vi5Ul3UZ9LBIYwqvL6EKf3utIfwTxDXIM3hqeP7kIGU=; b=VP5ddtYxJxGvFxkfIQldd4T5UkJ7ab1Z7hvH/vCwu3TLtyIE2oBerclOtO5LABEk66 49pYPXyRsbFsA7Vz62BAWuw91nqb0o9lyURMI4WgOZINrzPQZ5gWi5rPvothselFEN3c Ma1kpcH8/U0Myfijx1DusIId2a4qGWeZOq4eFX9CfGhgLZV40oGCvTpVztEmvRUxmRIM 8gFk+tyD4X43A4cZc2spyWBmPeBUIHiHc1QfP1lZwKHO8KjHjjcQyUS4CZRcgRHu1jk9 xWuTYtXgySRU+IEVCgVZEb7HF1iaC0YNAXOKrTIpRgywhjCkap2regcRstpaluA+YY08 Q0tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697475479; x=1698080279; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Vi5Ul3UZ9LBIYwqvL6EKf3utIfwTxDXIM3hqeP7kIGU=; b=U/QmHgDy38cwbAAFao8oSx19B/+5LScj0gzQBeINusW74dhpljmbvzqRX49WTDsk/r l/MkU+1OqeErjpLgCzNV5CL+F+nCEIz6zaMs0iH1SRftOnOQ8DtqCQYzL67wYf9A+EqD o/ufRC5HUlCWsXWU5fWfs7R05NBcLIjOpX1MMTZhyTeVxHGS2URXOdKyLTetW+32GUJv vsv7JVOw2LeVM+CmKnxhZy7xq1MjX7NZ4+jWbD+fqQWF74JClTBfTodvyxDkMwLOZRSu jv2+9YhixS7mrB1T8wRYuiB/r9sfjuClQuAK1T0rP7mgxNaGiCSgFmBt3larchfHNizo itLw== X-Gm-Message-State: AOJu0YyufjZQdizXy60xm1DxAfrfKGJBH9V/FouYSgURSdy21lc90nXh TZAI/4d6Do4XtJ9Zm/9p8Mg= X-Google-Smtp-Source: AGHT+IFIBw8jD4Yh6PvZ7+7UEzQm+w/6zNCjXEmcR0ay8sHAu149nPQQkb/d2tdsjOTigR6gfcKUPg== X-Received: by 2002:a17:906:d54f:b0:9be:71ab:fb5e with SMTP id cr15-20020a170906d54f00b009be71abfb5emr6925902ejc.22.1697475479217; Mon, 16 Oct 2023 09:57:59 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id 17-20020a170906029100b00989828a42e8sm4355695ejf.154.2023.10.16.09.57.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:57:57 -0700 (PDT) Message-ID: <17cd7d2255c7e3e1efb1fb83fc4c0cc84c0c127e.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 16 Oct 2023 18:57:56 +0200 In-Reply-To: References: <36c6ef9a672215883a84b8fec5a58a440d32ee11.1697394827.git.liliana.prikler@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: 2.82 X-Spam-Score: 2.82 X-Migadu-Queue-Id: E6CEF3B72A X-TUID: S1CmyxjsRKWV Am Montag, dem 16.10.2023 um 12:57 +0200 schrieb Rostislav Svoboda: > Hi Liliana, >=20 > Your patch works (thank you) and I improved it a tiny bit. (See > attachment.) BTW shouldn't the revision number in the (git-version > "0.1.0" "1" commit) be increased to "2" in your patch and to "3" in > mine? No. It should just be one patch anyway and the change doesn't affect the source code, but the build recipe. As such, the rebuild is going to happen either way. > DRY in the specification of the relative path of the snippets > directory. You can just amend my commit. > - (let ((snippets > - (string-append > - (elpa-directory (assoc-ref outputs "out")) > - "/snippets/haskell-mode"))) > - (mkdir-p snippets) > - (copy-recursively "snippets/haskell-mode" > snippets))))))) > + (let* ((relative-dirpath "snippets/haskell-mode") > + (installation-dir > + (string-append (elpa-directory (assoc-ref > outputs "out")) > + "/" relative-dirpath))) > + (mkdir-p installation-dir) > + (copy-recursively relative-dirpath installation- > dir))))))) Now you repeat yourself on relative-dirpath (which is a very Java name anyway, just five characters shorter than the original value won't win you Kolmogorov complexity). Plus you're requiring let* instead of let. Btw. don't=20 ((compose=C2=A0 (lambda (src dst) (mkdir-p src) (copy-recursively dst src)) (lambda (dir store) (values dir (string-append store "/" dir))) "snippets/haskell-mode" (elpa-directory (assoc-ref outputs "out"))) to avoid gratuitous repetition. Sometimes explicit is better than implicit, even if it comes at the cost of typing a constant twice :) Cheers