From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:41100) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iE8d6-00026G-KJ for guix-patches@gnu.org; Sat, 28 Sep 2019 05:03:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iE8d5-0003fm-53 for guix-patches@gnu.org; Sat, 28 Sep 2019 05:03:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40175) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iE8d4-0003fI-U4 for guix-patches@gnu.org; Sat, 28 Sep 2019 05:03:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iE8d4-0006hE-Nl for guix-patches@gnu.org; Sat, 28 Sep 2019 05:03:02 -0400 Subject: [bug#37534] [PATCH] gnu: conky: Activate Pulseaudio support. Resent-Message-ID: Date: Sat, 28 Sep 2019 09:02:12 +0000 (UTC) Message-ID: <1727802752.681659.1569661332406@mail.yahoo.com> In-Reply-To: <875zlde4m5.fsf@nckx> References: <20190927203251.30974-1-va511e@yahoo.com> <875zlde4m5.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_681658_1275654177.1569661332405" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Dumitrascu Vasile via Guix-patches From: Dumitrascu Vasile via Guix-patches via To: 37534@debbugs.gnu.org, me@tobias.gr ------=_Part_681658_1275654177.1569661332405 Content-Type: multipart/alternative; boundary="----=_Part_681657_1582018685.1569661332330" ------=_Part_681657_1582018685.1569661332330 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =C2=A0 Hi Tobias Thank you for the review and sorry to have missed the sorting. I have re-attached the original patch as a file to this email, as I guess t= he encoding issues were caused by git send-mail. =C2=A0 Thank you again,=C2=A0=C2=A0=C2=A0 Vasile On Saturday, September 28, 2019, 12:50:15 AM GMT+2, Tobias Geerinckx-Ri= ce wrote: =20 =20 Vasile, Vasile Dumitrascu via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > --- a/gnu/packages/conky.scm > +++ b/gnu/packages/conky.scm > @@ -2,6 +2,7 @@ >=C2=A0 ;;; Copyright ?? 2015 Sini??a Bi??in >=C2=A0 ;;; Copyright ?? 2018, 2019 Tobias Geerinckx-Rice=20 >=C2=A0 >=C2=A0 ;;; Copyright ?? 2019 Pierre Neidhardt > +;;; Copyright ?? 2019 Vasile Dumitrascu Does this show up as corrupted in your mailbox as well?=C2=A0 (=E2=80=98??= =E2=80=99=20 instead of =E2=80=98=C2=A9=E2=80=99.) > @@ -76,6 +79,7 @@ >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ("libxext" ,libxext) >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ("libxft" ,libxft) >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ("libxinerama" ,libxinerama) > +=C2=A0 =C2=A0 =C2=A0 ("pulseaudio", pulseaudio) >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ("lua" ,lua) >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ("ncurses" ,ncurses) >=C2=A0 =C2=A0 =C2=A0 =C2=A0 ("curl" ,curl))) I guess any hope of alphabetical ordering was lost long ago. The change looks fine to me, but could you try fixing the text=20 encoding? Thanks! T G-R =20 ------=_Part_681657_1582018685.1569661332330 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
  Hi Tobias

Thank you for the review and sorry to have missed the sorting.
I have re-attached the original patch as a file to this email, as = I guess the encoding issues were caused by git send-mail.

  Thank you again,
    Vasile

=20
=20
On Saturday, September 28, 2019, 12:50:15 AM GMT+2, Tob= ias Geerinckx-Rice <me@tobias.gr> wrote:


Vasile,

Vasile Dumitrascu via Guix-patches via =E5=86=99=E9=81=93=EF=BC= =9A
> --- a/gnu/packages/conky.scm
&= gt; +++ b/gnu/packages/conky.scm
> @@ -2,6 +2,7 @@
>  ;;; Copyright ?? 2015 Sini??a Bi??in <sinisa@bidin.eu>
>  ;;; Copyright ?? 201= 8, 2019 Tobias Geerinckx-Rice
>  <me@t= obias.gr>
>  ;;; Copyright ?? 2019 Pierre = Neidhardt <mail@ambrevar.xyz>
> = +;;; Copyright ?? 2019 Vasile Dumitrascu <va511e@yahoo.com>

Does this show up as corrupted i= n your mailbox as well?  (=E2=80=98??=E2=80=99
inst= ead of =E2=80=98=C2=A9=E2=80=99.)


> @@ -7= 6,6 +79,7 @@
>        ("libxext" = ,libxext)
>        ("libxft" ,lib= xft)
>        ("libxinerama" ,lib= xinerama)
> +      ("pulseaudio", puls= eaudio)
>        ("lua" ,lua)
>        ("ncurses" ,ncurses)
>        ("curl" ,curl)))


I guess any hope of alphabetical ordering was= lost long ago.

The change looks fine = to me, but could you try fixing the text
encoding?

Thanks!

T G-R
------=_Part_681657_1582018685.1569661332330-- ------=_Part_681658_1275654177.1569661332405 Content-Type: text/x-patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-gnu-conky-Activate-Pulseaudio-support.patch" Content-ID: <30338319-d9ee-e63d-c775-9bc0f8e7521d@yahoo.com> RnJvbSBkZGQxNGY5MmZhYTYyOThmOTNkZWQxMWZmMWY5NmIzNGY4NDdhNTQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWYXNpbGUgRHVtaXRyYXNjdSA8dmE1MTFlQHlhaG9vLmNvbT4K RGF0ZTogRnJpLCAyNyBTZXAgMjAxOSAyMjozMjowNSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGdu dTogY29ua3k6IEFjdGl2YXRlIFB1bHNlYXVkaW8gc3VwcG9ydC4KCiogZ251L3BhY2thZ2VzL2Nv bmt5LnNjbSAoY29ua3kpOgogIFtpbnB1dHNdIEFkZCBwdWxzZWF1ZGlvLgotLS0KIGdudS9wYWNr YWdlcy9jb25reS5zY20gfCA2ICsrKysrLQogMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9jb25reS5zY20gYi9n bnUvcGFja2FnZXMvY29ua3kuc2NtCmluZGV4IDY4MWZlYjZlNDMuLjA0NmQxMzJhOWIgMTAwNjQ0 Ci0tLSBhL2dudS9wYWNrYWdlcy9jb25reS5zY20KKysrIGIvZ251L3BhY2thZ2VzL2Nvbmt5LnNj bQpAQCAtMiw2ICsyLDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAxNSBTaW5pxaFhIEJpxJFpbiA8 c2luaXNhQGJpZGluLmV1PgogOzs7IENvcHlyaWdodCDCqSAyMDE4LCAyMDE5IFRvYmlhcyBHZWVy aW5ja3gtUmljZSA8bWVAdG9iaWFzLmdyPgogOzs7IENvcHlyaWdodCDCqSAyMDE5IFBpZXJyZSBO ZWlkaGFyZHQgPG1haWxAYW1icmV2YXIueHl6PgorOzs7IENvcHlyaWdodCDCqSAyMDE5IFZhc2ls ZSBEdW1pdHJhc2N1IDx2YTUxMWVAeWFob28uY29tPgogOzs7CiA7OzsgVGhpcyBmaWxlIGlzIHBh cnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTMxLDYgKzMyLDcgQEAKICAgIzp1c2UtbW9kdWxlIChn bnUgcGFja2FnZXMgbHVhKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBuY3Vyc2VzKQog ICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBwa2ctY29uZmlnKQorICAjOnVzZS1tb2R1bGUg KGdudSBwYWNrYWdlcyBwdWxzZWF1ZGlvKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyB4 b3JnKSkKIAogKGRlZmluZS1wdWJsaWMgY29ua3kKQEAgLTUxLDcgKzUzLDggQEAKICAgICAoYXJn dW1lbnRzCiAgICAgIGAoIzp0ZXN0cz8gI2YgICAgICAgICAgICAgICAgICAgICAgOyB0aGVyZSBh cmUgbm8gdGVzdHMKICAgICAgICAjOmNvbmZpZ3VyZS1mbGFncwotICAgICAgIChsaXN0ICItRFJF TEVBU0U9dHJ1ZSIpCisgICAgICAgKGxpc3QgIi1EUkVMRUFTRT10cnVlIgorICAgICAgICAgICAg ICItREJVSUxEX1BVTFNFQVVESU89T04iKQogICAgICAgICM6cGhhc2VzCiAgICAgICAgKG1vZGlm eS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcwogICAgICAgICAgKGFkZC1hZnRlciAndW5wYWNrICdh ZGQtZnJlZXR5cGUtdG8tc2VhcmNoLXBhdGgKQEAgLTc2LDYgKzc5LDcgQEAKICAgICAgICAoImxp YnhleHQiICxsaWJ4ZXh0KQogICAgICAgICgibGlieGZ0IiAsbGlieGZ0KQogICAgICAgICgibGli eGluZXJhbWEiICxsaWJ4aW5lcmFtYSkKKyAgICAgICAoInB1bHNlYXVkaW8iLCBwdWxzZWF1ZGlv KQogICAgICAgICgibHVhIiAsbHVhKQogICAgICAgICgibmN1cnNlcyIgLG5jdXJzZXMpCiAgICAg ICAgKCJjdXJsIiAsY3VybCkpKQotLSAKMi4yMy4wCgo= ------=_Part_681658_1275654177.1569661332405--