From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:46237) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9xKi-0005Tw-Vq for guix-patches@gnu.org; Thu, 05 Mar 2020 15:43:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9xKg-0006Ib-LT for guix-patches@gnu.org; Thu, 05 Mar 2020 15:43:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37810) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9xKg-0006IT-IA for guix-patches@gnu.org; Thu, 05 Mar 2020 15:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9xKg-0006ZW-Gc for guix-patches@gnu.org; Thu, 05 Mar 2020 15:43:02 -0500 Subject: [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful patch. Resent-Message-ID: From: Alexey Abramov Date: Thu, 05 Mar 2020 21:42:01 +0100 Message-ID: <170ac6f01a8.281d.da5dc967fe079fb386b94d5b80162893@mmer.org> In-Reply-To: <20200304025607.GA1199@jasmine.lan> References: <20200222201755.50425-1-levenson@mmer.org> <20200304025607.GA1199@jasmine.lan> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 39742@debbugs.gnu.org Many thanks! I will fix these in the next patches. Alexey On March 4, 2020 03:25:36 Leo Famulari wrote: > Hi, > > Thanks for these patches and sorry for the delay in review! There are a > lot of patches and it takes a while to get through them. > > On Sat, Feb 22, 2020 at 09:17:49PM +0100, Alexey Abramov wrote: >> * gnu/packages/java.scm: Add patch >> * gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New >> file. Allows you to run gradlew to run properly. Useful for debugging. > > The commit message needs a couple changes, to something like this: > > ------ > * gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. > * gnu/packages/java.scm (java-openjfx-build)[source]: Use it. > ------ > > We don't need to describe the patch in the commit message. Instead, we > explain it in a comment at the beginning of the patch file itself. This > is easier for the people that will read the patch later. The comment > should explain what the patch does and where it came from, including > links to bug reports and external patch sources, if they exist. > > We need to register the new patch file in 'gnu/local.mk', so that it > gets distributed in the Guix release process. > > And finally, we need to name the package variable (java-openjfx-build) > that the patch is being used by. > > Here is an example from an older commit: > > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=ca5e404f9a1ff81a38a32578c9c3a6c866482a9a