From: Tanguy LE CARROUR <tanguy@bioneland.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 62969@debbugs.gnu.org, mirai@makinata.eu
Subject: [bug#62969] [PATCH v3] home: Add msmtp service.
Date: Wed, 17 May 2023 10:52:05 +0200 [thread overview]
Message-ID: <168431352507.9673.2828328652177284378@localhost> (raw)
In-Reply-To: <87ednxyxd4.fsf@gnu.org>
Hi,
Quoting Ludovic Courtès (2023-05-03 22:27:03)
> Tanguy LE CARROUR <tanguy@bioneland.org> skribis:
>
> > Quoting Ludovic Courtès (2023-04-30 23:30:10)
> >> Tanguy Le Carrour <tanguy@bioneland.org> skribis:
> >>
> >> > * gnu/home/services/mail.scm: New file.
> >> > * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> >> > * doc/guix.texi (Mailing): New node.
> >>
> >> I get:
> >>
> >> --8<---------------cut here---------------start------------->8---
> >> [ 94%] GUILEC gnu/home/services/mail.go
> >> gnu/home/services/mail.scm:52:0: warning: possibly unbound variable `serialize-string'
> >> gnu/home/services/mail.scm:53:0: warning: possibly unbound variable `serialize-boolean'
> >> gnu/home/services/mail.scm:54:0: warning: possibly unbound variable `serialize-integer'
> >> --8<---------------cut here---------------end--------------->8---
> >>
> >> I guess these procedures should be provided as well?
> >
> > I also get them when making `gnu/home/services/mail.go`. But aren't
> > those "just" warnings.
>
> It means that there’s code referring to these procedures, and that they
> don’t exist. It’s worth investigating anyway.
I have noooo clue where to start! #noob’ 😅
> A couple of minor things:
> […]
> > +The @code{(gnu home services mail)} modules provides services that help
>
> “module” (singular)
Done!
> > +@uref{https://marlam.de/msmtp, MSMTP} is a @acronym{SMTP, Simple Mail
> > +Transfer Protocol} client. It sends mails to a predefined SMTP server
>
> “mail” (singular)
Done!
> > +@code{~/.config/msmtp/config} file.
>
> “@file”
Done!
> This new intro + example look nice to me!
>
> > +@item @code{logfile} (type: maybe-string)
>
> [...]
>
> > +@item @code{passwordeval} (type: maybe-string)
> > +Set the password for authentication to the output (stdout) of the
> > +command cmd.
>
> Sorry for not noticing earlier but I’d suggest ‘log-file’ and
> ‘password-evaluation’ (?) to stick with the established naming
> convention.
Done!
> So I think beyond this the main issue is figuring out the missing
> serialization procedures, and then we’re done!
I'm sending a v4!
Cheers,
--
Tanguy
next prev parent reply other threads:[~2023-05-17 8:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 14:42 [bug#62969] [PATCH] home: Add msmtp service Tanguy Le Carrour
2023-04-20 16:36 ` Bruno Victal
2023-04-23 17:10 ` Tanguy LE CARROUR
2023-04-23 17:12 ` [bug#62969] [PATCH v2] " Tanguy Le Carrour
2023-04-30 21:30 ` [bug#62969] [PATCH] " Ludovic Courtès
2023-05-03 10:01 ` [bug#62969] [PATCH v3] " Tanguy LE CARROUR
2023-05-03 20:27 ` Ludovic Courtès
2023-05-17 8:52 ` Tanguy LE CARROUR [this message]
2023-05-17 8:51 ` [bug#62969] [PATCH v4] " Tanguy Le Carrour
2023-05-29 21:43 ` bug#62969: [PATCH] " Ludovic Courtès
2023-05-30 6:54 ` [bug#62969] " Tanguy LE CARROUR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168431352507.9673.2828328652177284378@localhost \
--to=tanguy@bioneland.org \
--cc=62969@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=mirai@makinata.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.