bug#21677: Guile-NCurses 1.6 test failure with ncurses 6.0

bug#21677: Guile-NCurses 1.6 test failure with ncurses 6.0

[Ludovic Courtès]

When compiled with NCurses 6.0, guile-ncurses 1.6 has one test failure:

--8<---------------cut here---------------start------------->8---
FAIL: curses_034_util.test

[...]

============================================================================
Testsuite summary for GNU Guile-Ncurses 1.6
============================================================================
# TOTAL: 71
# PASS:  70
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
--8<---------------cut here---------------end--------------->8---

This was fine with NCurses 5.0.

Ludo’.

bug#21677: Guile-NCurses test failure when built against NCurses 6.0

[Ludovic Courtès]

Hello,

Guile-NCurses 1.6 has one test failure when built against NCurses 6.0:

--8<---------------cut here---------------start------------->8---
================================================
   GNU Guile-Ncurses 1.6: test/test-suite.log
================================================

# TOTAL: 71
# PASS:  70
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: curses_034_util
=====================

[?1049h[1;24r[m[4l[?7h[H[2J[6;6Hzzz[H[2J[24;1H[?1049l^[[?1l>UNRESOLVED: util: delay-output
PASS: util: curses-version
PASS: util: unctrl #\bel
PASS: util: unctrl x
PASS: util: unctrl xchar #\bel
PASS: util: unctrl xchar x
PASS: util: keyname #\bel
PASS: util: keyname x
PASS: util: keyname home
FAIL: getwin/putwin: putwin
ERROR: getwin/putwin: getwin - arguments: ((srfi-34 #<condition &curses-wrong-type-arg-error [arg: #f expected-type: window] e7d210>))

--8<---------------cut here---------------end--------------->8---

This was fine with NCurses 5.0.

Any ideas?

(Run ‘guix build guile-ncurses’ with current Guix master to reproduce.)

Thanks in advance!

Ludo’.

bug#21677: [Bug-guile-ncurses] Guile-NCurses test failure when built against NCurses 6.0

[Mike Gran]

> On Tuesday, October 13, 2015 1:59 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> > Hello,
> 
> Guile-NCurses 1.6 has one test failure when built against NCurses 6.0:
> 

> FAIL: getwin/putwin: putwin
> ERROR: getwin/putwin: getwin - arguments: ((srfi-34 #<condition 
> &curses-wrong-type-arg-error [arg: #f expected-type: window] e7d210>))

> Any ideas?

getwin/putwin save and restore a representation of a screen to a file.
That file format has changed for ncurses 6.  Their binding is
probably the least robust of the many functions in guile-ncurses.

I'll see what I can do with regards to a fix.

FWIW, this particular failure is constrained to those two functions alone,
and doesn't indicate any other problems.

-Mike

bug#21677: [Bug-guile-ncurses] Guile-NCurses test failure when built against NCurses 6.0

[Ludovic Courtès]

Mike Gran <spk121@yahoo.com> skribis:

>> On Tuesday, October 13, 2015 1:59 AM, Ludovic Courtès <ludo@gnu.org> wrote:
>> > Hello,
>> 
>> Guile-NCurses 1.6 has one test failure when built against NCurses 6.0:
>> 
>
>> FAIL: getwin/putwin: putwin
>> ERROR: getwin/putwin: getwin - arguments: ((srfi-34 #<condition 
>> &curses-wrong-type-arg-error [arg: #f expected-type: window] e7d210>))
>
>> Any ideas?
>
> getwin/putwin save and restore a representation of a screen to a file.
> That file format has changed for ncurses 6.  Their binding is
> probably the least robust of the many functions in guile-ncurses.
>
> I'll see what I can do with regards to a fix.

OK.

Any suggestions on how to fix it or work around it in Guix?  Or maybe we
should just wait for whatever fix you come up with?

Thanks!

Ludo’.

bug#21677: [Bug-guile-ncurses] Guile-NCurses test failure when built against NCurses 6.0

[Mike Gran]

 
> On Tuesday, October 13, 2015 10:12 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> > Mike Gran <spk121@yahoo.com> skribis:
> 
>>>  On Tuesday, October 13, 2015 1:59 AM, Ludovic Courtès 
> <ludo@gnu.org> wrote:
>>>  > Hello,
>>> 
>>>  Guile-NCurses 1.6 has one test failure when built against NCurses 6.0:
>>> 
>> 
>>>  FAIL: getwin/putwin: putwin
>>>  ERROR: getwin/putwin: getwin - arguments: ((srfi-34 #<condition 
>>>  &curses-wrong-type-arg-error [arg: #f expected-type: window] 
> e7d210>))
>> 
>>>  Any ideas?
>> 
>>  getwin/putwin save and restore a representation of a screen to a file.
>>  That file format has changed for ncurses 6.  Their binding is
>>  probably the least robust of the many functions in guile-ncurses.
>> 
>>  I'll see what I can do with regards to a fix.
> 
> OK.
> 
> Any suggestions on how to fix it or work around it in Guix?  Or maybe we
> should just wait for whatever fix you come up with?

You could try adding ac_cv_func_fopencookie=no to the configure call.
If that works, that should be a legit fix.
 
Otherwise, I'll need a couple of days.
 
Or you could just remove the failing test curses_034_util.test from
test/Makefile.am.  But that would be cheating. ;-)

-Mike

bug#21677: [Bug-guile-ncurses] Guile-NCurses test failure when built against NCurses 6.0

[Mike Gran]

 
>>>>   Guile-NCurses 1.6 has one test failure when built against NCurses 
> 6.0:
>>>> 
>>> 
>>>>   FAIL: getwin/putwin: putwin
>>>>   ERROR: getwin/putwin: getwin - arguments: ((srfi-34 #<condition 
> 
>>>>   &curses-wrong-type-arg-error [arg: #f expected-type: window] 
>>  e7d210>))
>>> 
>>>>   Any ideas?

Okay.  I've tried some of the combinations of Guile, Ncurses and OS
and getwin/putwin is broken in different ways with different combinations.

No one uses those functions anyway, as far as I can tell.

I think the plan is to put out a guile-ncurses 1.7 that just eliminates
it.  And then soon, put out a guile-ncurses 2.0 that will require guile-2.0.11+
and ncurses 6.0+, and re-evaluate whether it is worth it to fix
those functions.

I'll try to put out guile-ncurses 1.7 this week.

-Mike

bug#21677: [Bug-guile-ncurses] Guile-NCurses test failure when built against NCurses 6.0

[Ludovic Courtès]

Mike Gran <spk121@yahoo.com> skribis:

> Okay.  I've tried some of the combinations of Guile, Ncurses and OS
> and getwin/putwin is broken in different ways with different combinations.
>
> No one uses those functions anyway, as far as I can tell.
>
> I think the plan is to put out a guile-ncurses 1.7 that just eliminates
> it.  And then soon, put out a guile-ncurses 2.0 that will require guile-2.0.11+
> and ncurses 6.0+, and re-evaluate whether it is worth it to fix
> those functions.
>
> I'll try to put out guile-ncurses 1.7 this week.

Great, thanks.

Ludo’.

bug#21677: [Bug-guile-ncurses] Guile-NCurses test failure when built against NCurses 6.0

[Ludovic Courtès]

For now, Guix commit 3931607 skips the offending test.

Ludo’.