From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OFMSHLxmRWTyNgEASxT56A (envelope-from ) for ; Sun, 23 Apr 2023 19:11:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CM3/G7xmRWR9eAEA9RJhRA (envelope-from ) for ; Sun, 23 Apr 2023 19:11:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 316341A71B for ; Sun, 23 Apr 2023 19:11:24 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqdEv-0007TF-3J; Sun, 23 Apr 2023 13:11:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqdEs-0007St-UX for guix-patches@gnu.org; Sun, 23 Apr 2023 13:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqdEs-0003hG-Ls for guix-patches@gnu.org; Sun, 23 Apr 2023 13:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pqdEs-0000oQ-HC for guix-patches@gnu.org; Sun, 23 Apr 2023 13:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62969] [PATCH] home: Add msmtp service. Resent-From: Tanguy LE CARROUR Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 23 Apr 2023 17:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62969 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 62969@debbugs.gnu.org Received: via spool by 62969-submit@debbugs.gnu.org id=B62969.16822698293082 (code B ref 62969); Sun, 23 Apr 2023 17:11:02 +0000 Received: (at 62969) by debbugs.gnu.org; 23 Apr 2023 17:10:29 +0000 Received: from localhost ([127.0.0.1]:46902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqdEK-0000ne-VS for submit@debbugs.gnu.org; Sun, 23 Apr 2023 13:10:29 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:43487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqdEF-0000nL-AX for 62969@debbugs.gnu.org; Sun, 23 Apr 2023 13:10:27 -0400 Received: (Authenticated sender: tanguy@bioneland.org) by mail.gandi.net (Postfix) with ESMTPSA id DCD81240003; Sun, 23 Apr 2023 17:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bioneland.org; s=gm1; t=1682269817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZauskUDCZCuaAPW5eyLhpF5SHYG40mrFyL537YbkF+Q=; b=cvB3bzA1QOCp0ndIg0XPPcuo38NBciD7tWO/2379XCHBSbC0CFk7QlnbAK1VwauKieE9Hf f63Vj8VL+TTvEpLUkiMjbIeh1P9oTdXacmUuCcsZhqy4mhPLntieTqmYngcZ1LkgawQm5S K3V8ZCtKDaeDkopdb5Uc+//uxtJBtClGleZhbO3/AlQyO6rfAFXMy/PbjkW0DSWixm9mXS zA+8PXR9ou5529BvuDOuUlNHSeEDylGsD65nwnoI8HvZ40olucOPhzRUZWLu7UedzcLmHk MCLAnDbrTtCxCbVZHzPNCw+6D83BCT/8NuT2rGKdvh38S6YIW6bXSZcd7Oom4A== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable References: <20230420144230.9392-1-tanguy@bioneland.org> <4f8624a0-31fe-1ea5-733a-b2e1917291b4@makinata.eu> From: Tanguy LE CARROUR In-Reply-To: <4f8624a0-31fe-1ea5-733a-b2e1917291b4@makinata.eu> Date: Sun, 23 Apr 2023 19:10:15 +0200 Message-ID: <168226981597.13515.12105199384744750840@localhost> User-Agent: alot/0.10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682269884; a=rsa-sha256; cv=none; b=vDlLSrUxnuoOjtZa4R8BCEZ+9EsqG+IUA61KiU7iMyjoDPBd3e3db0xDtmIZYa8x0qbk+t LRUOT8R05vpTt3FQx8wpvSSnLSIvG2XWaIHgNW1sEKDRdpq30/P61NI1IX4gDZYDvDTi+r 2JWNU0wI5eKr6x33zE1IYYouuzhPEJ0XWPWU+gqHepmTiySUcKXv+Fd9RihLokxZgFo9eZ JEm63raoVgTAYWXBhMoXSc41uQc9RNGutHx3cl18JuXq96oEaj31IvIwqvJFknFt9lxFTY 9a4YiLnVhR8hc0CJT1klV4wnzQieMcYi2huv779v00qzgsLi1DM4ADr3r0cANg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=bioneland.org header.s=gm1 header.b=cvB3bzA1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=bioneland.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682269884; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZauskUDCZCuaAPW5eyLhpF5SHYG40mrFyL537YbkF+Q=; b=BbqoWevRRd0jimxAdPAJPU27ahTdSUPFgBQEcuiev8DPNpp6UgCVBVFO85ez2/aYdF0NaD Blc4Qgi/YxM+9/CsolqZidSNEn0SvIC+DZ3PUZ+npnkArS9McLzcpLwxNs6PpzHHjbsz7H Qr/gqR+fqH9Ic4Qvr2fmweqCNucViv4qsdv3tke7xdvU0NztYHSfZcYHaI14a0RCG8C5It y2z6bTPHpuAqAOca+s8/CNVn9q7iqQge27QLVD3jZcq9RFUZMBBc4hxJRZHwWdPwGFVYaX O4bUHhIHfutqoZnT9soxBvntbrcKCtkvxA30ObC0PfJUVxGcqiDtLDsu648n/g== X-Migadu-Spam-Score: -0.81 X-Spam-Score: -0.81 X-Migadu-Queue-Id: 316341A71B X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=bioneland.org header.s=gm1 header.b=cvB3bzA1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=bioneland.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: fOfRVluSM+Oz Hi Bruno, Thank you so much for you comments! I've applied (almost, see below) all of your suggestions and I will send a = v2. Quoting Bruno Victal (2023-04-20 18:36:59) > On 2023-04-20 15:42, Tanguy Le Carrour wrote: > > +(define (configuration-serialize-maybe-string field-name value) > > + #~(if #$(maybe-value-set? value) > > + (string-append #$(uglify-symbol field-name) " " #$value "\n") > > + ""))> + > > +(define (configuration-serialize-maybe-integer field-name value) > > + #~(if #$(maybe-value-set? value) > > + (string-append #$(uglify-symbol field-name) " " (number->string = #$value) "\n") > > + "")) > > + > > +(define (configuration-serialize-maybe-boolean field-name value) > > + #~(if #$(maybe-value-set? value) > > + (string-append #$(uglify-symbol field-name) " " (if #$value "on"= "off") "\n") > > + "")) > You don't have to perform the maybe-value-set? checks, it is automaticall= y done for you. > The only cases where this isn't true is if you explicitly override the se= rializer in > define-configuration. [2] This is the only thing I can't figure out how to make work?! When I remove the `(if #$(maybe-value-set? value) =E2=80=A6)` I get the following error: ``` Backtrace: 10 (primitive-load "/gnu/store/ajcf46q8yr9sb9n90psa5ay96jw?") In ice-9/ports.scm: 433:17 9 (call-with-output-file _ _ #:binary _ #:encoding _) In ice-9/eval.scm: 159:9 8 (_ #(#(#) #)) 155:9 7 (_ #(#(#) #)) 173:39 6 (_ #(#(#) #)) 159:9 5 (_ #(#(#) #)) 173:55 4 (_ #(#(#) #)) 173:55 3 (_ #(#(#) #)) 279:15 2 (_ #(#(#) #)) 223:20 1 (proc #(#(#) #)) In unknown file: 0 (%resolve-variable (7 . %unset-marker%) #) ERROR: In procedure %resolve-variable: Unbound variable: %unset-marker% ``` > > + (prefix configuration-)) > These are poor prefix choices for a module named (gnu home services mail). > If it were (gnu home services msmtp) or (gnu home services mail msmtp) it= would be acceptable > but a module named (gnu home services mail) is expected to eventually con= tain multiple services that > have to co-exist. These prefixes are too non-specific and confusion prone= for such circumstances. >=20 > I'd set this to (prefix msmtp-configuration-). (the same logic applies to= the remaining (prefix ...) lines) I totally agree! You guessed correctly, this home service was living inside `(bioneland home services msmtp)`, so the naming seemed to make sense at the time, but not any more! Thanks again for your time and help! --=20 Tanguy