From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6JXJEtDvQmMv8QAAbAwnHQ (envelope-from ) for ; Sun, 09 Oct 2022 17:59:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wKfVEtDvQmM0VAAA9RJhRA (envelope-from ) for ; Sun, 09 Oct 2022 17:59:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EA4B72A981 for ; Sun, 9 Oct 2022 17:59:11 +0200 (CEST) Received: from localhost ([::1]:54480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohYhr-0005l2-3G for larch@yhetil.org; Sun, 09 Oct 2022 11:59:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohYhd-0005i4-W1 for guix-devel@gnu.org; Sun, 09 Oct 2022 11:58:58 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:60167) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohYhb-0007YX-5M for guix-devel@gnu.org; Sun, 09 Oct 2022 11:58:57 -0400 Received: (Authenticated sender: tanguy@bioneland.org) by mail.gandi.net (Postfix) with ESMTPSA id A214A100009; Sun, 9 Oct 2022 15:58:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bioneland.org; s=gm1; t=1665331130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gdn2yOkIor03LU188/pjxvhde7rUZfUaKN60IpMdb78=; b=CIAvMenZknIoDGBvlZWHTnwAVRwfZu9FSeCtjQmTcuuJ4rb0jWuLBSC+2Nf6NMoyZdbzI+ PZmtaXkQ5qtixvmELNsRbCG23fXGQWxP+Zg2+MudzganK07fgHZf0XwsVv1dUXhqPJKEWp ZO0Ppg0nz95eouQ7LnjTymXAQZa55/uMSVpgJ0i4uodssv8rlMrMWlTEzQZOnMKk5HwZrH 4qfsn+4GpHFEwAnGmjEO3zQ92Y2gbws1H9hW8EhWzNQq372/GnSN66mweGZ6gTpouIKHAT /lwU7NJ+eQTqBZtKlFr66mfUnZnSKUTqaLUUtM5bV/d8YG34lQKyjLTJBVLeOg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable References: <87a66wfzeh.fsf@cbaines.net> <166497850086.2821.11724664487538606446@localhost> <87czb642q7.fsf@cbaines.net> Subject: Re: Notes from discussion on Quality Assurance from the 10 Years of Guix event From: Tanguy LE CARROUR Cc: guix-devel@gnu.org To: Christopher Baines In-Reply-To: <87czb642q7.fsf@cbaines.net> Date: Sun, 09 Oct 2022 17:58:49 +0200 Message-ID: <166533112965.2749.15218878117663623474@localhost> User-Agent: alot/0.10 Received-SPF: pass client-ip=217.70.178.231; envelope-from=tanguy@bioneland.org; helo=relay11.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665331152; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=gdn2yOkIor03LU188/pjxvhde7rUZfUaKN60IpMdb78=; b=EB068viOqMP3g3n1RbBgH+oq6SbsuemOnWmwe9zGkZ/twBJ/R7evsMLMBwkyH+ao5O78F1 JUAsBc7pN1FRX/vWXvVlT4Vz3hFA3DVIFlshvTSYKH6zs1khRBrDqXauFwwCRDBfiBrbYz BeO7BPhkIl4P/rG2PC4sTWw90r4nRF7RVHg9KN/2k+1u5QzMLMvlPlouSd8ujI+z9IZuY1 a00IhJnpxsf+Ks+fZFgJNHrwq7WbxUZEMP2hmn7lzifKXfadLuK7e1WcF5QOD6mOcrCgSn snRrFvcnfTwFc1hI5CXyV8LOhZNqsaSjdrh/62rU6Icy/xNtRG81cU1BiXjjCQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665331152; a=rsa-sha256; cv=none; b=dnK5DbbOYZ9k9qvTtbuvj75ng8nL0SCPLkG42i87hCK9G7V6SnhsZYWA+EVJlCh/a7GU0J QJEno58Z67/z4+MHflVICqx752uQpqwNikyPvJYw77sbGFkhUeuCzKFj+ISJSj2Dj5/Qm2 2PpVmN4dK4F+YdobJ/sWvG05Wcxn7dwgCEa9+H9jmeCDp2hDnW8FqTLaV0dgLuJk3VrgFl Twikmff9tBRhJmkmCVK8u9FuIG/7WPG2ex9wbbOnsVzKxOZ9s9oqxJyFs2JUfdRl09afvq i6mbzbLbRYcXpi/SmE/p3jXAEBeYJ1/8m1POWX4ku0MIJ3EczwAzvHdg5T/tNA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=bioneland.org header.s=gm1 header.b=CIAvMenZ; dmarc=pass (policy=none) header.from=bioneland.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.98 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=bioneland.org header.s=gm1 header.b=CIAvMenZ; dmarc=pass (policy=none) header.from=bioneland.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: EA4B72A981 X-Spam-Score: -1.98 X-Migadu-Scanner: scn1.migadu.com X-TUID: wGbrYl2x4boy Quoting Christopher Baines (2022-10-05 18:51:52) > Tanguy LE CARROUR writes: >=20 > >> - Minimise the burden for submitters > >> - Lengthy guidance for submitting patches > > > > Actually, the `16.4 Packaging Guidelines` and `16.6 Submitting Patches` > > are everything that I've ever looked for. >=20 > I think the point here is that the Submitting Patches section is quite > long. You mean the 17 point list?! =F0=9F=98=85 > > The only problem is `16.5.4 Formatting Code` that makes use of `./etc/i= ndent-code.el` > > that was removed back in January. >=20 > The latest version of the manual suggests using guix style, so this is > maybe a problem limited to old versions of the manual? I read it there: : ```shell ./etc/indent-code.el gnu/packages/file.scm package ``` If the online manual is considered an old version, where should I look for the current documentation? Devel? It seems to be up to date there, indeed: ```shell ./pre-inst-env guix style package ``` > >> - Changelog format > > > > "format" and "content". > > > > I've heard about a magic trick in Emacs, but as a user of "the other ed= itor", > > I have to write everything manually. > > > > I guess one could write a command that would detect what has changed and > > write the changelog. This could also be used on the reviewer/qa side to > > check if the patch actually does what it says it does. >=20 > I think there's room for improvement here in terms of telling people not > to worry about it too much, plus providing more guidance on the format > and common examples. >=20 > There's also tooling like the etc/committer.scm script which I don't > know anything about really, but it seems to handle writing this message > in some cases. ```shell $ ./pre-inst-env guix refresh -u csvkit # [=E2=80=A6] gnu/packages/wireservice.scm:205:13: csvkit: updating from version 1.0.5 to= version 1.0.7... # [=E2=80=A6] $ guile etc/committer.scm gnu: csvkit: Update to 1.0.7. * gnu/packages/wireservice.scm (csvkit): Update to 1.0.7. [master 715de68b73] gnu: csvkit: Update to 1.0.7. 1 file changed, 2 insertions(+), 2 deletions(-) ``` Mind=3Dblown=E2=84=A2 =F0=9F=A4=AF Thanks!!! > >> - Learn how to review more patches > > > > Also learn how to review your first patch! Being able to push a "+1" > > button in the QA interface might be useful? > > For the time being, I don't know what feedback from me could be useful > > for a commiter and how to provide it. >=20 > Yep, I think Arun had some useful ideas on this back in February > [1]. Particuarly including a checklist somewhere (issues.guix.gnu.org or > maybe qa.guix.gnu.org). >=20 > 1: https://guix.gnu.org/en/blog/2022/online-guix-days-2022-announcement-2/ Added to my "to watch" list. > Please let me know if I can help with any of this. The QA frontpage in > particular should have a bunch of easier things to do, and I've got a > rough list of tasks I put together here [2]. >=20 > 2: https://git.cbaines.net/guix/qa-frontpage/about/ First, I'll have to do my homework and read everything that's related to QA and DataService. I'll let you know as soon as I've found something useful to bring to the table. --=20 Tanguy