From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id dT7sL0OQN2KJMQAAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 21:36:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uNxhLEOQN2I/3AAA9RJhRA (envelope-from ) for ; Sun, 20 Mar 2022 21:36:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D6B939FED for ; Sun, 20 Mar 2022 21:36:19 +0100 (CET) Received: from localhost ([::1]:56646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nW2Hh-0003Jf-UC for larch@yhetil.org; Sun, 20 Mar 2022 16:36:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nW2HS-0003Gm-Fs for guix-patches@gnu.org; Sun, 20 Mar 2022 16:36:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41308) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nW2HS-0007y4-7g for guix-patches@gnu.org; Sun, 20 Mar 2022 16:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nW2HS-0004Pi-1p for guix-patches@gnu.org; Sun, 20 Mar 2022 16:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54309] [PATCH] services: auditd: use exclusive log directory for auditd Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Mar 2022 20:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54309 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: fesoj000 , 54309@debbugs.gnu.org Received: via spool by 54309-submit@debbugs.gnu.org id=B54309.164780851716883 (code B ref 54309); Sun, 20 Mar 2022 20:36:02 +0000 Received: (at 54309) by debbugs.gnu.org; 20 Mar 2022 20:35:17 +0000 Received: from localhost ([127.0.0.1]:35201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nW2Gi-0004OF-OZ for submit@debbugs.gnu.org; Sun, 20 Mar 2022 16:35:16 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:59852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nW2Gh-0004O4-50 for 54309@debbugs.gnu.org; Sun, 20 Mar 2022 16:35:16 -0400 Received: from [192.168.100.254] ([178.119.10.153]) by xavier.telenet-ops.be with bizsmtp id 8kbD270063J72EA01kbD6Q; Sun, 20 Mar 2022 21:35:13 +0100 Message-ID: <164b19e525895c50d73e0a84658c1d30c6ab452f.camel@telenet.be> From: Maxime Devos Date: Sun, 20 Mar 2022 21:35:13 +0100 In-Reply-To: <05b76afd93703efe8fca7fd11513c07343123dd3.camel@telenet.be> References: <80cc8802439c49138638dee6d4fb9015723f9727.camel@telenet.be> <05b76afd93703efe8fca7fd11513c07343123dd3.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Fwer0rW+6oxCt1pbknNK" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647808513; bh=s0dA7qABkejZD3PFna5U11GMz/3mMoyQpvRQzO1aZ90=; h=Subject:From:To:Date:In-Reply-To:References; b=EdFWSoXupm4GcgeZ68Ahp/51egy56GO64X1rSqls0prLV40bibxtXD+/CqeQlC2FB /muIUbrJb3KaOxnvqgtE/a2+8Pd64MkuCBSiaDlOmOjzHJVUoU9rZdcONYqUAH1j5g 8uPe0ZUslmOxHFEj78SDbmO+RZ2rKiToYksw2PPoidTmK1oK0ISkHLqjneAJNjOuQS gTVTPAeuyyIjQMEGCucujdrd4NblHChHeDzU8IE1YU2nHH29Lcje5+Oa6zpQBEzyfw UJXAaJl1XAleLOfobLnSmZHN6/22r680NbHEMiJdVkNiov0kMxvHg9m3Lo0Qm5DoS6 ebcFyWNQv0/gQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647808579; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=s0dA7qABkejZD3PFna5U11GMz/3mMoyQpvRQzO1aZ90=; b=Fc/VeWIIrMZmkbLIEyXv5vRidhStGTt3pxAzH/y0T5aJOH6UmuNsr7nNdqWbJ1AdTW1plE bKqDIRr4S/Kh7/93t8PmxbBCbZsURKguSRKFWCAeotKJ42OuNoCJc/qyW/eO3TsMFNTOMo btdhp4wlvVEX/Qs7nXA50FjL1dLpmgzph7DBoyCIJmIT/Robs2A2sTPSJJrfkhv12Vju98 WtWXkjwkzT0SCouEDaHmBBmswiAnFLzpCDTHEr1oO4Zmz3IaC0kwY8dBBmx2M798j3N2rm EVeIwcp9/SpWVrQQrPrSt/+RXFB+KaYTY+VMo0fM5sc3uknwZG7ROyjsMaeiXQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647808579; a=rsa-sha256; cv=none; b=GGBOTOj30zHtC/WOvpp37dfWkXd3KkEjRPkLMOsKn7+qTgk2G5xch6QFg77CAgjkyZCADH kObSfDI1SZTobraBb2W6HhrKwlzYzK47WlCa3ylI0yDS/DeS1H2af5FHvs5nHuXh9dJ1+v VynIIryE8c56J5lkyTP//vdhvgiLUVJMHgCeXtHPtTm6kCV+jrj/cWH8ctfmukxd7pPgWe VoSXXXRqazVIqdD51iKzxzxkbOz0OHEzQWI+jZHuP4hwhCq7h4sIvbnpnGMqY3Fj/oj/aM yDY3E6XSG+TSgEFLkA9mfccqL3oycmy6CEGuA5wWR4rqM4wylp22nMaw1rVr1w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=EdFWSoXu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.77 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=EdFWSoXu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8D6B939FED X-Spam-Score: 3.77 X-Migadu-Scanner: scn1.migadu.com X-TUID: icEpIAHjYFbA --=-Fwer0rW+6oxCt1pbknNK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Maxime Devos schreef op zo 20-03-2022 om 21:30 [+0100]: > fesoj000 schreef op zo 20-03-2022 om 21:22 [+0100]: > > > I cannot recommend this, what if 'mkdir-p' throws an exception? > > > That might cause problems.=C2=A0 Or maybe not, but it would require > > > some analysis that can be avoided with 'mkdir-p/perms'. > > Hm, but i still have to set umask to prevent TOCTOU, the > > implementation of 'mkdir-p/perms' does not take care of that. >=20 > mkdir-p/perms could be modified to take care of that. > If that is done, then other users of mkdir-p/perms would benefit as > well. >=20 > To implement this, I recommend using the prodecures from > >=20 > -- that patch was written to remove the TOCTOU! It seems to be ignored so far upstream, so I'll look into defining a Guile package variant that can be used by the activation code. Greetings, Maxime. --=-Fwer0rW+6oxCt1pbknNK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjeQARccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7jndAP4vJegPum4a6DSNEHRtSGLywGcu PzAW+e2xmG/tOnODxwEAwcnBgKCCJpsrqWIvBwDu0BIslZazdAiliGULghFJuAQ= =Vvn8 -----END PGP SIGNATURE----- --=-Fwer0rW+6oxCt1pbknNK--