all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tanguy LE CARROUR <tanguy@bioneland.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 53046@debbugs.gnu.org
Subject: [bug#53046] [PATCH] gnu: python-args: Patch reference to basestring.
Date: Mon, 10 Jan 2022 08:48:49 +0100	[thread overview]
Message-ID: <164180092977.2244.10462578989817222327@localhost> (raw)
In-Reply-To: <e4a300ba49b83c44343c4242b7d2d349c494c477.camel@telenet.be>

Hi Maxime,


Quoting Maxime Devos (2022-01-09 22:34:52)
> Maxime Devos schreef op zo 09-01-2022 om 22:15 [+0100]:
> > > This fixes a build failure in the 'sanity-check' phase.
> > > +             (substitute* "args.py"
> > > +               (("basestring") "str"))
> > 
> > Does it actually fix the build failure, or is it only suppressed?
> > [...]
> 
> According to <https://github.com/kennethreitz-archive/args/pull/19>,
> the tests are excluded from the tarball.  It would be useful to
> switch to git-fetch such that tests can be run, verifying whether
> this change causes problems or not.

I'll switch to `git-fetch` and see! Maybe Python 2 tests will also pass
with the patch!?

I'll apply all your suggestions and send a v2.

Thanks again for your time and advice.

-- 
Tanguy




  reply	other threads:[~2022-01-10  8:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06 10:21 [bug#53046] [PATCH] gnu: python-args: Patch reference to basestring Tanguy Le Carrour
2022-01-09 21:15 ` Maxime Devos
2022-01-09 21:34   ` Maxime Devos
2022-01-10  7:48     ` Tanguy LE CARROUR [this message]
2022-01-10  7:46   ` Tanguy LE CARROUR
2022-01-17 13:34 ` [bug#53046] [PATCH v2] gnu: " Tanguy Le Carrour
2022-01-17 14:14   ` Maxime Devos
2022-01-17 14:22     ` Tanguy LE CARROUR
2022-01-17 14:23 ` [bug#53046] [PATCH v3] " Tanguy Le Carrour
2022-03-10 17:28 ` [bug#53046] [PATCH v4] gnu: python-args: " Tanguy Le Carrour
2022-08-04  9:09   ` bug#53046: [PATCH] " Ludovic Courtès
2022-08-04  9:42     ` [bug#53046] " Tanguy LE CARROUR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164180092977.2244.10462578989817222327@localhost \
    --to=tanguy@bioneland.org \
    --cc=53046@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.