From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp11.migadu.com ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms0.migadu.com with LMTPS
	id gMDdHe4CIGIZVwEAgWs5BA
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Thu, 03 Mar 2022 00:51:10 +0100
Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp11.migadu.com with LMTPS
	id 6EA5G+4CIGKtQwAA9RJhRA
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Thu, 03 Mar 2022 00:51:10 +0100
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 2A035236F9
	for <larch@yhetil.org>; Thu,  3 Mar 2022 00:51:09 +0100 (CET)
Received: from localhost ([::1]:35570 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	id 1nPYkN-0005U3-Eg
	for larch@yhetil.org; Wed, 02 Mar 2022 18:51:07 -0500
Received: from eggs.gnu.org ([209.51.188.92]:57352)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1nPYkI-0005Tt-Nb
 for guix-patches@gnu.org; Wed, 02 Mar 2022 18:51:02 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:47142)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1nPYkI-0007Vw-F6
 for guix-patches@gnu.org; Wed, 02 Mar 2022 18:51:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1nPYkI-0001pp-9Z
 for guix-patches@gnu.org; Wed, 02 Mar 2022 18:51:02 -0500
X-Loop: help-debbugs@gnu.org
Subject: [bug#54216] [PATCH v2] gnu: shepherd-for-guix: New package for use in
 Guix.
Resent-From: "Leo Famulari" <leo@famulari.name>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Wed, 02 Mar 2022 23:51:02 +0000
Resent-Message-ID: <handler.54216.B54216.16462650547039@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 54216
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: zimoun <zimon.toutoune@gmail.com>, "Attila Lendvai" <attila@lendvai.name>
Cc: 54216@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Received: via spool by 54216-submit@debbugs.gnu.org id=B54216.16462650547039
 (code B ref 54216); Wed, 02 Mar 2022 23:51:02 +0000
Received: (at 54216) by debbugs.gnu.org; 2 Mar 2022 23:50:54 +0000
Received: from localhost ([127.0.0.1]:41039 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1nPYkA-0001pT-58
 for submit@debbugs.gnu.org; Wed, 02 Mar 2022 18:50:54 -0500
Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:59115)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@famulari.name>) id 1nPYk7-0001pD-NX
 for 54216@debbugs.gnu.org; Wed, 02 Mar 2022 18:50:52 -0500
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.west.internal (Postfix) with ESMTP id 71FA73200E51;
 Wed,  2 Mar 2022 18:50:44 -0500 (EST)
Received: from imap48 ([10.202.2.98])
 by compute2.internal (MEProxy); Wed, 02 Mar 2022 18:50:44 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=cc:cc:content-type:date:date:from:from:in-reply-to
 :in-reply-to:message-id:mime-version:references:reply-to:sender
 :subject:subject:to:to; s=mesmtp; bh=QMtWLgDaKMk7OpySmX9MBXGedGD
 /Q0U+KpDO+nA//Yg=; b=KD/sysp3vKuWfJ6q9bXnxXXcflUeDDZXzAs71v8emqP
 VKdfYIRdTznHhxzPssn0kFBqr+RcM5T2Lnd6i7xTOaM7IAYM0cURvB0N2X5CjpjH
 hzivwQchff0y8bzSdF2Ie8upL1SM29PfvDjr7AojfbZ55l11xZA6KRfzv8kleo4s
 =
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QMtWLgDaKMk7OpySm
 X9MBXGedGD/Q0U+KpDO+nA//Yg=; b=FMQfD0bK1YMNwkzUdoj3ZxNOcmww0CMO5
 EB/v4NMuT5LUuPD8UPGJlIhw1hxXtwdSHlSKcYp+Soez+6Fd376GVn+vOwq0GBim
 ezKBiJZxfYbuUKREcY52UcBTh4FB/nel2EyvcGWCCydv8Gvc4i3PPBdY2php2Qr5
 wiWiZRukdOU6iSEb4CflSF18D8fE1JiRtRnAvhldXNd2q47QMxqNGsDq2LoF8AhI
 Eq5U8BbWHVkjLTChEEtyLOv4yL0OHfqxLLHtdvhnVJz30dxDXpk3nN//XQFM0T8x
 /igZVxkBSUIsTHw8HDnrox1jhDonRSiMA7QymhGcswrw2aNpamXSQ==
X-ME-Sender: <xms:0wIgYswm6PhroqFS7JEkRGjwxFA7r6nTMp1EjrWAdqhUTEqACO_M-A>
 <xme:0wIgYgTpuYF3J0kgdss6ZLWDHmIKijAvPqBOcvepiwAQqay2ZEU6kZUzRk0fXJgep
 l0mTe-Hmdn011C18g>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddthedgudeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdfnvgho
 ucfhrghmuhhlrghrihdfuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrf
 grthhtvghrnhepkedvheeutdetueeigeevhffhvdeihfekleetfeffgeevhfehtdetfeei
 ueejtefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh
 eplhgvohesfhgrmhhulhgrrhhirdhnrghmvg
X-ME-Proxy: <xmx:0wIgYuUmkoIP3fxXXrPthzIHVM_w7ZKBUEmDeYu6SpQGmfBUUB7ouQ>
 <xmx:0wIgYqi5K50c0Az5j6DlogwnLKchKJm2OhPnEgbYvLEH_pDmMQaOFQ>
 <xmx:0wIgYuDAjkecaFYH-PLWhP2yEXVCoj1Kk7atH1r5TzffBAx2uLy8Jw>
 <xmx:0wIgYv5RkbOodsZLqrwc5JLbtJPK899zsGM-boruEj5Ttde165F0wQ>
Received: by mailuser.nyi.internal (Postfix, from userid 501)
 id A15FC21E006E; Wed,  2 Mar 2022 18:50:43 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.5.0-alpha0-4778-g14fba9972e-fm-20220217.001-g14fba997
Mime-Version: 1.0
Message-Id: <15fbca84-83ed-43cd-9bd4-e187ccadf4ec@www.fastmail.com>
In-Reply-To: <CAJ3okZ1vah5XFy3BVoc=hv0Ke5GxT+3M3uYo2CTNRZyPHz-mAQ@mail.gmail.com>
References: <20220301182848.26694-1-attila@lendvai.name>
 <20220301184517.13439-1-attila@lendvai.name>
 <992c3326a10e0bb28491f8226ebbe84aa93ad9ca.camel@telenet.be>
 <aJFlM3mC27rhgpJ7Mr5IN7Zyb84HRFfGSJinSMwiKWGxoY8t6gjmUatPyK2y_S8PNSqHgnTUbGJ3NDoiNHDnjN2rHVbi80WbUntglsXEO1s=@lendvai.name>
 <CAJ3okZ1vah5XFy3BVoc=hv0Ke5GxT+3M3uYo2CTNRZyPHz-mAQ@mail.gmail.com>
Date: Wed, 02 Mar 2022 18:50:24 -0500
From: "Leo Famulari" <leo@famulari.name>
Content-Type: text/plain
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1646265070;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:resent-cc:resent-from:resent-sender:
	 resent-message-id:in-reply-to:in-reply-to:references:references:
	 list-id:list-help:list-unsubscribe:list-subscribe:list-post:
	 dkim-signature; bh=QMtWLgDaKMk7OpySmX9MBXGedGD/Q0U+KpDO+nA//Yg=;
	b=Cvs6p46Rv2n8EXSsucI7rIb6Ujwb912sectepARptaLQ/EviMwYX3+puebZIGM4Lu2EmkH
	lMOEPv/+19PwIHJsjNnGHsZqFA+awGUUJMtIeMMp04Dw2cnkuMxShO/P8FSv2fZmCvPKzW
	18Gwc9LpxhFndjF5pxfluZQh0n3kPetgKS1NKThRl0gwYF0OyLHs3/tIMAVhFS2Z5NRp3f
	pXrFvotKV7XNuEJ37lIiRJ/DquqGetBpbQNbbTiiocVHjewMcBlWNc5ARi3w4Ga7UgyZIN
	HcvWTVyo2UPdZdPb8/Be/AMTmXoy6OggR8MjJUj9tQDpPUqSZYgEa/fARPf0Jw==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646265070; a=rsa-sha256; cv=none;
	b=MI4vzcgVQ+RLWmx5KreePCVhr2v8qIixkLNSoihGmZA2+LJFpMM/DWa1CIbS0/p5BYfyqM
	ZClDw1lTIUjz7tjZKLh3Roj4EotIdpH7hqHzKfUimRZhUtsJyEiq83vjam1mv3mD/KKO+O
	wBjzsxWR+tUgVxAMbbfIHb2eFxBHuc5zBgTJG78gLuEUNIechpRGFjQew69jM2mEpBweuh
	p1Vmf0xbz2wDafhMO9qNi16O4JmQpc6S0a/ec78KSHjAMQlm8ucCNOWQE4CmQtCH4ibw4E
	dXb2zhjIc6uSEEw3VZd/r2Wbww4hrGLgq7qXrXTEKRZ1UiGzDGO40vxYsW94rg==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b="KD/sysp3";
	dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=FMQfD0bK;
	dmarc=none;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Spam-Score: 3.84
Authentication-Results: aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b="KD/sysp3";
	dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=FMQfD0bK;
	dmarc=none;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Queue-Id: 2A035236F9
X-Spam-Score: 3.84
X-Migadu-Scanner: scn0.migadu.com
X-TUID: KTqtzmFTK56G

Origin snippets should only be used to remove nonfree things from the upstream source code. All other changes should use patch files or a build phase.

On Wed, Mar 2, 2022, at 04:14, zimoun wrote:
> Hi Attila,
>
> On Tue, 1 Mar 2022 at 20:42, Attila Lendvai <attila@lendvai.name> wrote:
>
>> unfortunately, it won't help us much here, because one snippet modifies
>> Makefile.am, while the other Makefile.in.
>
> Guix does not have a clear line for patching (or I am not aware of the
> update); what is going to source+snippet vs arguments+phase.  Pros and
> cons for both; basically the question is what "guix build --source"
> should return?
>
> Option source+snippet means it returns the source of what Guix really
> builds -- so many packages would not respect this rule of thumb.
>
> Option arguments+phase means it returns the real unmodified upstream
> source (modulo removal of non-free) -- so "guix shell -D foo" would
> break for many packages.
>
> Difficult tension. :-)  For most cases, not an unique answer; maybe
> that's why we do not have a clear documentation. :-)  I just mention
> it i.e., I am not saying you can do something. :-)  I am simply
> pointing that Guix does not have a clear recommendation /
> documentation where the patches should go; probably depending on their
> nature.  Well, nothing related with your patch. :-)
>
> That's said, personally, in this case, instead of having the Makefile*
> patch in 'source', I would do the patching using a phase.
>
> Cheers,
> simon