From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +D9SEWvyuGF9lAAAgWs5BA (envelope-from ) for ; Tue, 14 Dec 2021 20:37:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eKUlDWvyuGHvWQAAB5/wlQ (envelope-from ) for ; Tue, 14 Dec 2021 19:37:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 54EA0154A1 for ; Tue, 14 Dec 2021 20:37:14 +0100 (CET) Received: from localhost ([::1]:38072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mxDbt-0002qw-Cx for larch@yhetil.org; Tue, 14 Dec 2021 14:37:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxDbi-0002qY-Ns for guix-patches@gnu.org; Tue, 14 Dec 2021 14:37:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48125) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mxDbi-0007HW-Dv for guix-patches@gnu.org; Tue, 14 Dec 2021 14:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mxDbi-0005da-4J for guix-patches@gnu.org; Tue, 14 Dec 2021 14:37:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52439] [PATCH] gnu: emacs-recutils: Update to 1.8.2-0.058dbe4. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Dec 2021 19:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52439 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Morgan.J.Smith@outlook.com Cc: 52439@debbugs.gnu.org Received: via spool by 52439-submit@debbugs.gnu.org id=B52439.163951061421656 (code B ref 52439); Tue, 14 Dec 2021 19:37:02 +0000 Received: (at 52439) by debbugs.gnu.org; 14 Dec 2021 19:36:54 +0000 Received: from localhost ([127.0.0.1]:59671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxDbZ-0005dD-Ik for submit@debbugs.gnu.org; Tue, 14 Dec 2021 14:36:53 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:45963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxDbV-0005cw-7e for 52439@debbugs.gnu.org; Tue, 14 Dec 2021 14:36:52 -0500 Received: by mail-wr1-f66.google.com with SMTP id o13so34171704wrs.12 for <52439@debbugs.gnu.org>; Tue, 14 Dec 2021 11:36:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=/YidaPnV6UWs7jwd7PL6UZcUq5EM8YtoQDgptZdkAr4=; b=D2d3JQVu5PbkMrnIv9sK+XoyaLRW0iFWoH8tofmJcjBUG2+BKsAno3LVnwcP1rVdQl 4agrcFP+ZjH0E84JIUBmP/N+mZht5HVdYQG9O281OQDMu129m3PoVfs98DW8hRp5Tm7K ldL5M/9TbBFbQQ/0JZi6lVlzHFzKvVSsh3ctom6QRTXOK1b6x75iiD91KgyebB25sGbH KFdKgCMOgl1lwiyn9+jgqCc49cCoC329Zu0H5LKK8ECT5X6YDNvd7pTAJuQvirs3yiKH AvdYTEVj604Oq0UPv2dVQkJoVeCt4H20fi6lWcoWSAJcGVyxZXY8x4qMVBxTE4m06iLU pk9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=/YidaPnV6UWs7jwd7PL6UZcUq5EM8YtoQDgptZdkAr4=; b=ca/URjaPhRDTQ9H2smu9+VRsG2umoASOXnPfRCfsS2qqbTW6463ZY0qNtDJJncW4uX Fl0p9Hd/lD3mHbSrlN3ds4slEobeYvMJir1J8g1GnWJRt3RiZ91X5KuTQ9NB7PIT9zdw BhhpJgfmqET/I3nn8pK93kxGHQSCp2brAqpRVWG3hY4i0rMMX5xYUl//lpn8KypANSeW SntwBZgvjYzR3VPnuLGVWaQoEpMlMMAoROe3fRDa/zU2b6Km/fkNDFxlp+sBu1j9h4vN /PRCMGgx9noKd/upNzUduj7U/Qah0cxFN1rJT64E18U4trQjSoslaiV06AkJ5NdZ7GVz 5hOg== X-Gm-Message-State: AOAM533PhNOf9hkVRzoIosmPiNsdSziHCuOoCfM0ctCenTu/ViPo8BvJ Gau7tSKptJmiFp/Y9jbPMzo= X-Google-Smtp-Source: ABdhPJxqnGcysefOXqjJ8enYOLE4CnL8BsAvEWzr0HWJ9KSyWF486dcKw9VU4bfh3Gb3DDQ1sFYdBg== X-Received: by 2002:a5d:5181:: with SMTP id k1mr1111109wrv.681.1639510603206; Tue, 14 Dec 2021 11:36:43 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id r7sm713258wrq.29.2021.12.14.11.36.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Dec 2021 11:36:42 -0800 (PST) Message-ID: <15aecbbfba26c94dc856f516dbe39d27c910d254.camel@gmail.com> From: Liliana Marie Prikler Date: Tue, 14 Dec 2021 20:36:41 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639510635; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/YidaPnV6UWs7jwd7PL6UZcUq5EM8YtoQDgptZdkAr4=; b=frOYXQPcw5Z/k2DPq0DCVLLN44VoPh5bNL8AK+XKZXthFZMROLJK64OsfqpEAjHVmJgxyo 6cFRLM59Ijoo4bdyyxywVEC8ZA8JEg+NYjPElJMzWyHRZLDojTlINs5tRVazURjz9zdqpK COKJ2tYFqv9FoQ236a/w+I67aqFt7ncglJT1LVnv0BoKqckJJBtOC263gXkQEv7cN7lLXo MTqKWpeLlEoeEfHVq6rRW8Wt1hI970l01CXFmqaQjB2lNc6R0lJ5cNWZueftOD85JyAbju IyRhlJ8kA22zIbL+1W64yWmLSaWjs1GRxyYaSQXNju7kezfGNVMOKv9IUmZ0sw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639510635; a=rsa-sha256; cv=none; b=jARb3TRJ5ha1tbXE6QBgHNQxwAdVsL77nZq46BkeVoEnQW0IhZnc9Fo5Kqz3pHrQKwOZMq 2ePYtW/ZGxOljALo0YfsKEd4TzPYRb1GIaocRJ2kjNG0aimu8LUyn4n+wRpfRq++7dc/tG EMyLRtJPd7+gypVyoNUnJotYn5QoaEITkTl3R08qgMLis17zbBi1vS5M6oKDOnB9rc3XZh D8JFJnhaA8mi37YFkNZB+uF8h6ImjY9aq/AaBqhsX7xJVJrP0cq4UOEmT0LpJGCVlH29Up oDmPo7w+rBnKA3n7N/KBIPCkBgYtnVi5NS/PUaPctN3B6XH48eTNiFrSwJmlPg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=D2d3JQVu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.87 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=D2d3JQVu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 54EA0154A1 X-Spam-Score: -1.87 X-Migadu-Scanner: scn1.migadu.com X-TUID: QjgMnIlRp9gl Hi, Note, that you don't need to clean any of this up; I'll do it myself before pushing. However, due to the recent c-u-f merge and the fact that I only have limited time per day to actually push things, I wanted to give some feedback ahead of time for the sake of transparency. Am Montag, den 13.12.2021, 19:54 -0500 schrieb Morgan.J.Smith@outlook.com: > From: Morgan Smith > > * gnu/packages/databases.scm (emacs-recutils): Update to 1.8.2- > 0.058dbe4. > [inherit]: Don't inherit from recutils > [source]: Add > [native-inputs]: Add texinfo > [home-page]: Add > [arguments]: Add make-info phase > [license]: Add > --- Generally, we use full sentences here. > > Liliana Marie Prikler writes: > > For the record, the convention is usually to use the upstream name, > > *but that's not always reasonable*. > > I am very tempted to put rec-mode in the upstream-name package > properties but I feel like that is not at all what that property is > intended for. You *can* actually use upstream-name if you use elpa as source. That would have the effect of making `guix refresh' work as intended. > Thanks for being open to a name change but I'm starting to feel like > maybe I'm just being stubborn and there would be very little benefit > :P. Especially since you've raised some very good points. Uhm, actually I'm just as stubborn in not wanting another deprecated- package :P > gnu/packages/databases.scm | 49 +++++++++++++++++++++++++----------- > -- > 1 file changed, 33 insertions(+), 16 deletions(-) > > diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm > index 7cff0f99c5..c0b714fc37 100644 > --- a/gnu/packages/databases.scm > +++ b/gnu/packages/databases.scm > @@ -141,6 +141,7 @@ (define-module (gnu packages databases) > #:use-module (gnu packages sqlite) > #:use-module (gnu packages tcl) > #:use-module (gnu packages terminals) > + #:use-module (gnu packages texinfo) > #:use-module (gnu packages textutils) > #:use-module (gnu packages time) > #:use-module (gnu packages tls) > @@ -1384,24 +1385,40 @@ (define-public recutils > (home-page "https://www.gnu.org/software/recutils/"))) > > (define-public emacs-recutils > - (package > - (inherit recutils) > - (name "emacs-recutils") > - (build-system emacs-build-system) > - (arguments > - '(#:phases > - (modify-phases %standard-phases > - (add-after 'unpack 'change-directory > - (lambda _ > - (chdir "etc") > - #t))))) > - (native-inputs '()) > - (inputs '()) > - (synopsis "Emacs mode for working with recutils database files") > - (description "This package provides an Emacs major mode > @code{rec-mode} > + ;; Untagged release > + (let ((commit "058dbe420e63bd460c0c8d09dd97ab55bc45533a") > + (revision "0")) > + (package > + (name "emacs-recutils") > + (version (git-version "1.8.2" revision commit)) Following the discussion over at rec-mode, it appears as though ELPA is seen as some source of truth. That is a bit disappointing to us Guixers, given the lz vs. uncompressed archive thing ELPA has, but I think we can point to ELPA here while ensuring that we also push this to SWH. > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url " > https://git.savannah.gnu.org/git/recutils/rec-mode.git") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1qy8wrj14nzxzr6zvs4574v54jlhqszm1ybgq4a8pavkx2ay4 > c7r")) > + (modules '((guix build utils))) > + (snippet '(begin (delete-file "rec-mode.info"))))) > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (add-before 'install 'make-info > + (lambda _ > + (invoke "makeinfo" "--no-split" > + "-o" "rec-mode.info" "rec-mode.texi")))))) > + (native-inputs > + `(("texinfo" ,texinfo))) > + (build-system emacs-build-system) It's always a good idea to put build-system before arguments. > + (home-page "https://www.gnu.org/software/recutils/") > + (synopsis "Emacs mode for working with recutils database > files") > + (description "This package provides an Emacs major mode > @code{rec-mode} > for working with GNU Recutils text-based, human-editable > databases. It > supports editing, navigation, and querying of recutils database > files > -including field and record folding."))) > +including field and record folding.") > + (license license:gpl3+)))) Otherwise LGTM. Again, I'll push this with adjustments to the above soon™, but can't promise a fix date yet. Cheers