From: Mark Meyer <mark@ofosos.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: python2-pyicu: Disable failing test.
Date: Fri, 15 Dec 2017 11:58:22 +0100 [thread overview]
Message-ID: <1513335502.2832092.1206018928.19279436@webmail.messagingengine.com> (raw)
In-Reply-To: <20171215104759.28107-1-me@tobias.gr>
Tobias,
thanks for the patch, this works for me :)
Cheers, Mark
On Fri, Dec 15, 2017, at 11:47, Tobias Geerinckx-Rice wrote:
> * gnu/packages/python.scm (python2-pyicu)[arguments]: Add
> ‘delete-failing-test’ phase.
> ---
>
> Mark,
>
> ...of course it finishes right after I send that previous e-mail.
>
> This patch makes the build pass for me. Could you confirm whether it
> works for you?
>
> Kind regards,
>
> T G-R
>
> gnu/packages/python.scm | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index e36056d45..372b5afe3 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -1130,7 +1130,20 @@ Python 3.3+.")
> (license license:x11)))
>
> (define-public python2-pyicu
> - (package-with-python2 python-pyicu))
> + (let ((base (package-with-python2
> + (strip-python2-variant python-pyicu))))
> + (package
> + (inherit base)
> + (arguments
> + `(,@(package-arguments base)
> + #:phases
> + (modify-phases %standard-phases
> + (add-before 'check 'delete-failing-test
> + (lambda _
> + ;; XXX: This fails due to Unicode issues unique to Python
> 2,
> + ;; it seems:
> <https://github.com/ovalhub/pyicu/issues/61>.
> + (delete-file "test/test_Script.py")
> + #t))))))))
>
> (define-public python2-dogtail
> ;; Python 2 only, as it leads to "TabError: inconsistent use of tabs
> and
> --
> 2.15.0
>
--
Mark Meyer
mark@ofosos.org
next prev parent reply other threads:[~2017-12-15 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 9:26 Build failure in pyicu Mark Meyer
2017-12-15 10:41 ` Tobias Geerinckx-Rice
2017-12-15 10:47 ` [PATCH] gnu: python2-pyicu: Disable failing test Tobias Geerinckx-Rice
2017-12-15 10:58 ` Mark Meyer [this message]
2017-12-15 11:17 ` Tobias Geerinckx-Rice
2017-12-15 12:30 ` Mark Meyer
2017-12-15 15:45 ` Tobias Geerinckx-Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513335502.2832092.1206018928.19279436@webmail.messagingengine.com \
--to=mark@ofosos.org \
--cc=guix-devel@gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.