From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1Vts-00052t-Ez for guix-patches@gnu.org; Mon, 09 Oct 2017 07:07:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1Vtm-0005hz-OL for guix-patches@gnu.org; Mon, 09 Oct 2017 07:07:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48509) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e1Vtm-0005hZ-KI for guix-patches@gnu.org; Mon, 09 Oct 2017 07:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e1Vtm-0003cy-A8 for guix-patches@gnu.org; Mon, 09 Oct 2017 07:07:02 -0400 Subject: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. Resent-Message-ID: Message-ID: <1507547167.17241.18.camel@tourbillion-technology.com> From: Paul Garlick Date: Mon, 09 Oct 2017 12:06:07 +0100 In-Reply-To: <87o9piit59.fsf@gnu.org> References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> <873779hdci.fsf@gnu.org> <87o9piit59.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 28593@debbugs.gnu.org, Dave Love Hi Ludo and Dave, > Paul, Dave: what do we do this patch? > >   https://bugs.gnu.org/28593 > To recap on my comments on the patch: i) a debug output would be fine; possibly with an extra comment for OpenFOAM users to say what it can be used for ii) deleting object files, to save disk space, under 'platforms/linux64GccDPInt32Opt/src' should also be fine, with the proviso that the re-compilation process should be checked before committing.  There is an example procedure, albeit for an earlier version, given at https://openfoamwiki.net/index.php/How_to_add_tempera ture_to_icoFoam .  A slightly modified procedure should work for version 4.1. Dave, can you try this on your patched version?  'wmake' should re- generate the object files that are needed and produce a new executable.  Check that there are no instances of errors such as 'file not found' iii) substitute a more descriptive word than 'junk' for the object files; 'intermediate' or some such iv) the source files take up much less space than the object files.  I wouldn't worry about deleting them. Best regards, Paul.