From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1di2W8-00079s-Cr for guix-patches@gnu.org; Wed, 16 Aug 2017 13:54:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1di2W2-00012n-Pe for guix-patches@gnu.org; Wed, 16 Aug 2017 13:54:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:32779) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1di2W2-00012h-LX for guix-patches@gnu.org; Wed, 16 Aug 2017 13:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1di2W2-0002RN-9M for guix-patches@gnu.org; Wed, 16 Aug 2017 13:54:02 -0400 Subject: [bug#28045] [PATCH] gnu: Add openfoam Resent-Message-ID: Message-ID: <1502905946.2548.31.camel@tourbillion-technology.com> From: Paul Garlick In-Reply-To: <20170814214925.2cd96b3f@centurylink.net> References: <20170811110636.23339-1-pgarlick@tourbillion-technology.com> <20170814214925.2cd96b3f@centurylink.net> Content-Type: multipart/alternative; boundary="=-uh1g6VGBYjO2lycZ4azp" Date: Wed, 16 Aug 2017 18:52:26 +0100 Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Eric Bavier , Marius Bakke Cc: 28045@debbugs.gnu.org --=-uh1g6VGBYjO2lycZ4azp Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hello Guix, Thank you Marius and Eric for your reviews and comments. I have been working through the changes and updating the patch.  However, in the process of rebasing I have noticed a change in Guix that impacts on the OpenFOAM definition.  Specifically, a recent commit (26599d6) has changed the definition of the scotch package so that it now uses 64bit integers.  In a nutshell, this causes a build failure in OpenFOAM. In OpenFOAM, there is a variable to specify the size of the integer values (32bit or 64bit).  This single variable is used by both metis and scotch, meaning that they both have to use 32bit integers or both use 64bit integers.  At present, Guix offers a 64bit scotch and a 32bit metis. A straightforward solution would be to add the extra packages, a 32bit scotch and/or a 64bit metis.  For scotch, that would be the same definition, except for the 'INTSIZE64' line.  For metis, that would involve an edit of 'metis.h', setting IDXTYPEWIDTH and REALTYPEWIDTH to 64. Would you prefer this to be the subject of a separate patch, or included in the OpenFOAM patch?  There is also a question about how to name the packages; scotch and scotch32, for example, or scotch and scotch-64int etc. Best regards, Paul On Mon, 2017-08-14 at 21:49 -0500, Eric Bavier wrote: > Hello Paul, > > Thank you for the patch! > > --=-uh1g6VGBYjO2lycZ4azp Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Hello Guix,

Thank yo= u Marius and Eric for your reviews and comments.

I= have been working through the changes and updating the patch.  Howeve= r, in the process of rebasing I have noticed a change in Guix that impacts = on the OpenFOAM definition.  Specifically, a recent commit (26599d6) h= as changed the definition of the scotch package so that it now uses 64bit i= ntegers.  In a nutshell, this causes a build failure in OpenFOAM.

In OpenFOAM, there is a variable to specify the size o= f the integer values (32bit or 64bit).  This single variable is used b= y both metis and scotch, meaning that they both have to use 32bit integers = or both use 64bit integers.  At present, Guix offers a 64bit scotch an= d a 32bit metis.

A straightforward solution would = be to add the extra packages, a 32bit scotch and/or a 64bit metis.  Fo= r scotch, that would be the same definition, except for the 'INTSIZE64' lin= e.  For metis, that would involve an edit of 'metis.h', setting IDXTYP= EWIDTH and REALTYPEWIDTH to 64.

Would you prefer t= his to be the subject of a separate patch, or included in the OpenFOAM patc= h?  There is also a question about how to name the packages; scotch an= d scotch32, for example, or scotch and scotch-64int etc.

Best regards,

Paul

On Mon, 2017-08-14 at 21:49 -0500, Eric Bavier wrote:
Hello Paul,

Thank you for the patch!
--=-uh1g6VGBYjO2lycZ4azp--