From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Garlick Subject: Re: [PATCH] gnu: Add opencascade-oce Date: Thu, 19 Jan 2017 12:01:16 +0000 Message-ID: <1484827276.2709.14.camel@tourbillion-technology.com> References: <1484738618-3156-1-git-send-email-pgarlick@tourbillion-technology.com> <87k29s8bd3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="=-hUImzS99kt9MKuhPTIh7" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUBPC-0006mD-K8 for guix-devel@gnu.org; Thu, 19 Jan 2017 07:01:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUBP7-0006Jo-Oz for guix-devel@gnu.org; Thu, 19 Jan 2017 07:01:26 -0500 Received: from smtp.hosts.co.uk ([85.233.160.19]:57508) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cUBP7-0006If-Jh for guix-devel@gnu.org; Thu, 19 Jan 2017 07:01:21 -0500 In-Reply-To: <87k29s8bd3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke , guix-devel@gnu.org --=-hUImzS99kt9MKuhPTIh7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hello Marius, Thank you for your review. > I wonder if this could fit in "engineering.scm". Or maybe > "geometry.scm" > or "3d.scm". We try to avoid "single program" modules. What do you > think? Perhaps maths.scm is the best place, in order to avoid creating a new module.  The Gmsh package is already there.  To check; am I right in saying that a library in one module can be used as an input for a package in another module?  For example, if FreeCAD were to be packaged, and placed in engineering.scm, could it use opencascade-oce as an input from maths.scm? > > > > +(define-public opencascade-oce > > + (package > > + (name "opencascade-oce") > > + (version "0.17.2") > > > > > Version 0.18 was released a few days ago! > It would be useful to package both versions.  There is a difference in the OpenGL graphics card requirements in going from version 0.17.2 to 0.18. > > > > + (license license:lgpl2.1))) ; plus header files exception > > > > > Please expand on the exception comment and mention > OCCT_LGPL_EXCEPTION.txt. There are also some public domain files, and > the bundled "gtest" is bsd-3. src/OpenGl/OpenGl_glext.h is distributed > under the expat license. Some files generated by "bison" has GPL3+. > I have added the information about the expat and BSD-3 licenses.  Can you elaborate on the public domain files and Bison? Best, Paul. --=-hUImzS99kt9MKuhPTIh7 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
Hello Marius,

Thank you for your review.

I wonder if this could fit in "engineering.scm". Or maybe "geometry.scm"
or "3d.scm". We try to avoid "single program" modules. What do you think?

Perhaps maths.scm is the best place, in order to avoid creating a new module.  The Gmsh package is already there.  To check; am I right in saying that a library in one module can be used as an input for a package in another module?  For example, if FreeCAD were to be packaged, and placed in engineering.scm, could it use opencascade-oce as an input from maths.scm?


+(define-public opencascade-oce
+  (package
+    (name "opencascade-oce")
+    (version "0.17.2")



Version 0.18 was released a few days ago!

It would be useful to package both versions.  There is a difference in the OpenGL graphics card requirements in going from version 0.17.2 to 0.18.


+    (license license:lgpl2.1))) ; plus header files exception



Please expand on the exception comment and mention
OCCT_LGPL_EXCEPTION.txt. There are also some public domain files, and
the bundled "gtest" is bsd-3. src/OpenGl/OpenGl_glext.h is distributed
under the expat license. Some files generated by "bison" has GPL3+.

I have added the information about the expat and BSD-3 licenses.  Can you elaborate on the public domain files and Bison?

Best,

Paul.
--=-hUImzS99kt9MKuhPTIh7--