From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: [PATCH] services: nginx: Actually check if configuration is valid. Date: Fri, 9 Sep 2016 04:05:15 +0200 Message-ID: <1473386715-10297-1-git-send-email-me@tobias.gr> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biBC9-00055F-6F for guix-devel@gnu.org; Thu, 08 Sep 2016 22:05:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biBC3-0005dr-Bd for guix-devel@gnu.org; Thu, 08 Sep 2016 22:05:32 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:46924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biBC3-0005dl-5Q for guix-devel@gnu.org; Thu, 08 Sep 2016 22:05:27 -0400 Received: from localhost.localdomain (ptr-2hj4tbtvcl90ij2ml4xlngsoq.ip6.access.telenet.be [IPv6:2a02:1811:b680:8200:e4bd:a7c2:276f:f03a]) (Authenticated sender: me@tobias.gr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 7C97817209C for ; Fri, 9 Sep 2016 04:05:23 +0200 (CEST) List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org * gnu/services/web.scm (nginx-activation): Fix path to nginx binary. --- Hullo again! I suspect not many people run nginx (or dovecot, but that's a different matter) on Guix. The nginx activation script will now correctly print a non-fatal error if the configuration smells off. Why I'm mailing: was this intended to be fatal? It's easy to miss now. Kind regards, T G-R gnu/services/web.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/services/web.scm b/gnu/services/web.scm index d86aab5..5b0e816 100644 --- a/gnu/services/web.scm +++ b/gnu/services/web.scm @@ -80,7 +80,7 @@ (format #t "creating nginx run directory '~a'~%" #$run-directory) (mkdir-p #$run-directory) ;; Check configuration file syntax. - (system* (string-append #$nginx "/bin/nginx") + (system* (string-append #$nginx "/sbin/nginx") "-c" #$config-file "-t"))))) (define nginx-shepherd-service -- 2.7.4