all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice <me@tobias.gr>
To: guix-devel@gnu.org
Subject: [PATCH] services: nginx: Actually check if configuration is valid.
Date: Fri,  9 Sep 2016 04:05:15 +0200	[thread overview]
Message-ID: <1473386715-10297-1-git-send-email-me@tobias.gr> (raw)

* gnu/services/web.scm (nginx-activation): Fix path to nginx binary.
---

Hullo again!

I suspect not many people run nginx (or dovecot, but that's a different
matter) on Guix. The nginx activation script will now correctly print a
non-fatal error if the configuration smells off.

Why I'm mailing: was this intended to be fatal? It's easy to miss now.

Kind regards,

T G-R

 gnu/services/web.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/web.scm b/gnu/services/web.scm
index d86aab5..5b0e816 100644
--- a/gnu/services/web.scm
+++ b/gnu/services/web.scm
@@ -80,7 +80,7 @@
          (format #t "creating nginx run directory '~a'~%" #$run-directory)
          (mkdir-p #$run-directory)
          ;; Check configuration file syntax.
-         (system* (string-append #$nginx "/bin/nginx")
+         (system* (string-append #$nginx "/sbin/nginx")
                   "-c" #$config-file "-t")))))
 
 (define nginx-shepherd-service
-- 
2.7.4

             reply	other threads:[~2016-09-09  2:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09  2:05 Tobias Geerinckx-Rice [this message]
2016-09-09  2:09 ` [PATCH] services: nginx: Actually check if configuration is valid Thompson, David
2016-09-09  2:21   ` Tobias Geerinckx-Rice
2016-09-09  2:29     ` Thompson, David
2016-09-09  2:36       ` Tobias Geerinckx-Rice
2016-09-09 22:42       ` Ludovic Courtès
2016-09-09 22:41 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473386715-10297-1-git-send-email-me@tobias.gr \
    --to=me@tobias.gr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.