From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: [PATCH 1/7] emacs: Rename 'file-path' to 'file-name'. Date: Fri, 22 Jan 2016 11:19:29 +0300 Message-ID: <1453450775-594-2-git-send-email-alezost@gmail.com> References: <1453450775-594-1-git-send-email-alezost@gmail.com> Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMWws-0005Pp-TX for guix-devel@gnu.org; Fri, 22 Jan 2016 03:20:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMWwo-00071n-G5 for guix-devel@gnu.org; Fri, 22 Jan 2016 03:20:01 -0500 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:33103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMWwo-00071X-3C for guix-devel@gnu.org; Fri, 22 Jan 2016 03:19:58 -0500 Received: by mail-lf0-x242.google.com with SMTP id z62so3669090lfd.0 for ; Fri, 22 Jan 2016 00:19:57 -0800 (PST) Received: from localhost.localdomain ([217.107.192.146]) by smtp.gmail.com with ESMTPSA id j71sm725356lfi.20.2016.01.22.00.19.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 22 Jan 2016 00:19:56 -0800 (PST) In-Reply-To: <1453450775-594-1-git-send-email-alezost@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org * emacs/guix-info.el (guix-info-file-path): Rename to... (guix-info-file-name): ... this. * emacs/guix-list.el (guix-list-file-path): Rename to... (guix-list-file-name): ... this. (guix-list-get-file-path): Rename to... (guix-list-get-file-name): ... this. * emacs/guix-ui-generation.el (guix-generation-list-format): Adjust accordingly. * emacs/guix-ui-system-generation.el (guix-system-generation-list-format): Likewise. * NEWS: Mention faces renaming. --- NEWS | 3 ++- emacs/guix-info.el | 6 +++--- emacs/guix-list.el | 14 +++++++------- emacs/guix-ui-generation.el | 2 +- emacs/guix-ui-system-generation.el | 2 +- 5 files changed, 14 insertions(+), 13 deletions(-) diff --git a/NEWS b/NEWS index 0084394..b27ebc7 100644 --- a/NEWS +++ b/NEWS @@ -16,7 +16,7 @@ Please send Guix bug reports to bug-guix@gnu.org. *** Emacs interface for system generations *** Emacs interface for hydra.gnu.org -*** Changes in Emacs interface variables +*** Changes in Emacs interface variables and faces In the following names, BUFFER-TYPE means "info" or "list"; ENTRY-TYPE means "package", "output" or "generation". @@ -30,6 +30,7 @@ ENTRY-TYPE means "package", "output" or "generation". - guix-buffer-name-function -> guix-ui-buffer-name-function - guix-update-after-operation -> guix-ui-update-after-operation - guix-search-params -> guix-package-search-params +- guix-BUFFER-TYPE-file-path (face) -> guix-BUFFER-TYPE-file-name **** Replaced - guix-list-column-format, guix-list-column-value-methods -> diff --git a/emacs/guix-info.el b/emacs/guix-info.el index 644533e..6aefd2f 100644 --- a/emacs/guix-info.el +++ b/emacs/guix-info.el @@ -42,9 +42,9 @@ "Face used for titles of parameters." :group 'guix-info-faces) -(defface guix-info-file-path +(defface guix-info-file-name '((t :inherit link)) - "Face used for file paths." + "Face used for file names." :group 'guix-info-faces) (defface guix-info-url @@ -337,7 +337,7 @@ BUTTON-OR-FACE is a button type)." (define-button-type 'guix-file :supertype 'guix - 'face 'guix-info-file-path + 'face 'guix-info-file-name 'help-echo "Find file" 'action (lambda (btn) (guix-find-file (button-label btn)))) diff --git a/emacs/guix-list.el b/emacs/guix-list.el index 7e57f42..51eb106 100644 --- a/emacs/guix-list.el +++ b/emacs/guix-list.el @@ -33,9 +33,9 @@ (guix-define-buffer-type list) -(defface guix-list-file-path - '((t :inherit guix-info-file-path)) - "Face used for file paths." +(defface guix-list-file-name + '((t :inherit guix-info-file-name)) + "Face used for file names." :group 'guix-list-faces) (defface guix-list-time @@ -214,10 +214,10 @@ VAL may be nil." (guix-get-string (guix-get-time-string seconds) 'guix-list-time)) -(defun guix-list-get-file-path (path &optional _) - "Return PATH button specification for `tabulated-list-entries'." - (list path - 'face 'guix-list-file-path +(defun guix-list-get-file-name (file-name &optional _) + "Return FILE-NAME button specification for `tabulated-list-entries'." + (list file-name + 'face 'guix-list-file-name 'action (lambda (btn) (find-file (button-label btn))) 'follow-link t 'help-echo "Find file")) diff --git a/emacs/guix-ui-generation.el b/emacs/guix-ui-generation.el index 4047850..74b8ff2 100644 --- a/emacs/guix-ui-generation.el +++ b/emacs/guix-ui-generation.el @@ -166,7 +166,7 @@ current profile's GENERATION." :format '((number nil 5 guix-list-sort-numerically-0 :right-align t) (current guix-generation-list-get-current 10 t) (time guix-list-get-time 20 t) - (path guix-list-get-file-path 30 t)) + (path guix-list-get-file-name 30 t)) :titles '((number . "N.")) :sort-key '(number . t) :marks '((delete . ?D))) diff --git a/emacs/guix-ui-system-generation.el b/emacs/guix-ui-system-generation.el index d79f3bc..7f4d76d 100644 --- a/emacs/guix-ui-system-generation.el +++ b/emacs/guix-ui-system-generation.el @@ -71,7 +71,7 @@ SEARCH-VALUES." (current guix-generation-list-get-current 10 t) (label nil 40 t) (time guix-list-get-time 20 t) - (path guix-list-get-file-path 30 t)) + (path guix-list-get-file-name 30 t)) :titles guix-generation-list-titles :sort-key '(number . t) :marks '((delete . ?D))) -- 2.7.0