From: Leo Famulari <leo@famulari.name>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/1] gnu: Add Anonymous Pro fonts.
Date: Sat, 05 Sep 2015 15:06:40 -0400 [thread overview]
Message-ID: <1441480000.680390.375666841.73572D4D@webmail.messagingengine.com> (raw)
In-Reply-To: <877fo5uh0n.fsf@gmail.com>
On Sat, Sep 5, 2015, at 09:34, Alex Kost wrote:
> Leo Famulari (2015-09-04 00:53 +0300) wrote:
> > + (source (origin
> > + (method url-fetch)
> > + (uri (string-append "http://www.marksimonson.com/assets/content/fonts/"
>
> This line is too long, we prefer to stay within 78 chars. I would make
> it:
>
> (string-append
> "http://www.marksimonson.com/assets/content/fonts/"
>
> > + "AnonymousPro-" version ".zip"))
> > + (sha256
> > + (base32 "1asj6lykvxh46czbal7ymy2k861zlcdqpz8x3s5bbpqwlm3mhrl6"))))
>
> Such (base32 "…") lines also look too long for me, so I prefer to move a
> hash on another line (but some people leave it this way).
I thought that lint would catch those, sorry.
> > + (for-each (lambda (ttf)
> > + (copy-file ttf
> > + (string-append font-dir "/" ttf)))
> > + (find-files "." "\\.ttf$"))
> > + (for-each (lambda (doc)
> > + (copy-file doc
> > + (string-append doc-dir "/" doc)))
> > + (find-files "." "\\.txt$"))))))
>
> This (find-files …) should be shifted 2 chars left (the same as
> 'find-files' in the previous 'for-each').
No excuse there, sorry again.
> Otherwise, LGTM. So if there will be no other comments and objections
> on the package name, I will push it. No need to resend the patch — I'll
> fix these small issues I mentioned. Thank you.
I think the package name is fine. Thank you!
next prev parent reply other threads:[~2015-09-05 19:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 21:53 [PATCH 0/1] Add Anonymous Pro fonts Leo Famulari
2015-09-03 21:53 ` [PATCH 1/1] gnu: " Leo Famulari
2015-09-05 13:34 ` Alex Kost
2015-09-05 19:06 ` Leo Famulari [this message]
2015-09-06 9:45 ` Alex Kost
2015-09-05 13:33 ` [PATCH 0/1] " Alex Kost
2015-09-05 15:57 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441480000.680390.375666841.73572D4D@webmail.messagingengine.com \
--to=leo@famulari.name \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.