From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/3] gnu: Add llfuse.
Date: Tue, 01 Sep 2015 17:04:53 -0400
Message-ID: <1441141493.1352268.372111089.17473147@webmail.messagingengine.com>
References: <cover.1440609350.git.leo@famulari.name>
	<a10ded9f0f7b07e614369b2b6027c439e11eecd9.1440609350.git.leo@famulari.name>
	<87d1y48s7b.fsf@gmail.com> <8737yzbrpu.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48600)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ZWsjj-0002n2-1T
	for guix-devel@gnu.org; Tue, 01 Sep 2015 17:05:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ZWsjf-0003UH-2G
	for guix-devel@gnu.org; Tue, 01 Sep 2015 17:04:58 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:51898)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ZWsje-0003Tq-Sa
	for guix-devel@gnu.org; Tue, 01 Sep 2015 17:04:55 -0400
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
	by mailout.nyi.internal (Postfix) with ESMTP id 44CE2202E1
	for <guix-devel@gnu.org>; Tue,  1 Sep 2015 17:04:53 -0400 (EDT)
In-Reply-To: <8737yzbrpu.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?UTF-8?Q?Ludovic=20Court=C3=A8s?= <ludo@gnu.org>, Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

On Mon, Aug 31, 2015, at 07:52, Ludovic Court=C3=A8s wrote:
> Alex Kost <alezost@gmail.com> skribis:
>=20
> > Leo Famulari (2015-08-26 20:16 +0300) wrote:
>=20
> [...]
>=20
> >> +   (description "Python-LLFUSE is a set of Python bindings for the lo=
w level
> >> +FUSE API.  It requires at least FUSE 2.8.0 and supports both Python 2=
.x and
> >> +3.x.")
> >
> > IMHO mentioning a version of fuse is not needed.  And IIUC this package
> > provides a python3 library, so I would also remove "supports both =E2=
=80=A6".
>=20
> +1

Done.

>=20
> >> +   (home-page "https://bitbucket.org/nikratio/python-llfuse/")
> >> +   (license lgpl2.0)))
> >
> > It should be 'lgpl2.0+' as the LICENSE file says "or (at your option)
> > any later version".
>=20
> Yes.  Leo, could you also check a few source file headers to confirm
> they either have the =E2=80=9Cor later=E2=80=9D clause, or do not specify=
 any version?

The LLFUSE source files are all "LGPL" without mention of a version. The
LICENSE file is the only place where the version is specified (LGPL
2.0+). However, I also found that an included source file from another
project (underscore.js) is MIT/expat.=20

> > Also I think it is better to put this package in "python.scm" as it just
> > contains some general python library.  But I'm not an expert here, so
> > better wait for comments of other people.
>=20
> Agreed.
>=20
> > But I would name it 'python-llfuse' and would also add 'python2-llfuse'
> > package (bug again: I didn't make a single python package).
>=20
> Right.  See the convention described at
> <https://www.gnu.org/software/guix/manual/html_node/Python-Modules.html>.

Done.

> Leo, could you send an updated patch?

Forthcoming...