From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thomas Schmitt" Subject: Re: ISO installer image: GPT versus MBR partitions Date: Thu, 25 Apr 2019 20:46:17 +0200 Message-ID: <14387677849925631817@scdbackup.webframe.org> References: <20190425195521.4dd1ef5e@scratchpost.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:51761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJjLi-0005H2-MS for guix-devel@gnu.org; Thu, 25 Apr 2019 14:43:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJjLh-0004Ld-Eg for guix-devel@gnu.org; Thu, 25 Apr 2019 14:43:58 -0400 In-Reply-To: <20190425195521.4dd1ef5e@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: bug-xorriso@gnu.org Cc: guix-devel@gnu.org Hi, i wrote: > > --file-system-type=3Diso9660[_$variation] Danny Milosavljevic wrote: > I'm not sure yet. We have a lot of special-casing for iso9660 > already. If anything, at that point, we could pass an arbitrary list > of options or something (an "environment" if you will. Hah). How ever the options are brought to the grub-mkrescue run and the script, i strongly urge not to expose all possible combinations of MKRESCUE_SED* variables to the ISO production process. Four consistent variations will be enough and avoid riddling failures. > The problem is that there were horrible security problems in bash and th= at > made a lot of distributions switch to a more minimal shell ("dash") for > scripts. It is supposed to run on dash, ksh, and BSD sh versions. > we patch grub-mkrescue to use an absolute path for mformat and mcopy > in order to make them predictable. How deep shall this go ? dd, awk, od, head, find, test, mv, rm, ... > > > For example in grub-mkrescue-sed.sh there's no "-e" in the shebang > > Is it conservative enough to add it ? > It will exit the shell when one of the toplevel commands has an > exit status !=3D 0. But do all reasonable shells support -e ? (I must dig in man ksh down to builtin command -set to get confirmation.) > > That's why i brought a Guile re-write into consideration. > > Firstly it would be the language of choice and secondly it would make > > Guix independent of my ideas how it should be done. > We're not trying to become iso bootloader experts ourselves :) Currently Guix ISO production is not enough boss over what gets into the ISO image. Neither with EFI partition properties nor with partition table type. > For now, let's try the shell script and make it more paranoid. Please report all changes (and be ready to motivate them). Have a nice day :) Thomas