* Re: 01/01: gnu: ncmpcpp: Enable taglib support. [not found] ` <E1YUEXM-0005oq-0e@vcs.savannah.gnu.org> @ 2015-03-08 21:30 ` Ludovic Courtès 2015-03-09 9:57 ` Paul van der Walt 2015-03-09 10:03 ` [PATCH] gnu: ncmpcpp: Move taglib from native-inputs Paul van der Walt 0 siblings, 2 replies; 4+ messages in thread From: Ludovic Courtès @ 2015-03-08 21:30 UTC (permalink / raw) To: Paul van der Walt; +Cc: guix-devel Howdy! Paul <paul@denknerd.org> skribis: > commit cd77777602af48a32466d8d720a6c70a89721607 > Author: Paul van der Walt <paul@denknerd.org> > Date: Sat Mar 7 13:40:40 2015 +0100 > > gnu: ncmpcpp: Enable taglib support. > > * gnu/packages/mpd.scm (ncmpcpp): Add --with-taglib configure flag. [...] > diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm > index 2313b30..2f9ad72 100644 > --- a/gnu/packages/mpd.scm > +++ b/gnu/packages/mpd.scm > @@ -196,10 +196,11 @@ terminal using ncurses.") > `(("pkg-config" ,pkg-config) > ("automake" ,automake) > ("autoconf" ,autoconf) > - ("libtool" ,libtool))) > + ("libtool" ,libtool) > + ("taglib" ,taglib))) ‘taglib’ should go to a new ‘inputs’ field, not to ‘native-inputs’ (the distinction between the two is for when cross-compiling: ‘native-inputs’ are things that need to be run on the machine that compiles, whereas ‘inputs’ is code to run on the target machine.) Could you adjust accordingly? Thanks, Ludo’. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 01/01: gnu: ncmpcpp: Enable taglib support. 2015-03-08 21:30 ` 01/01: gnu: ncmpcpp: Enable taglib support Ludovic Courtès @ 2015-03-09 9:57 ` Paul van der Walt 2015-03-09 19:45 ` Ludovic Courtès 2015-03-09 10:03 ` [PATCH] gnu: ncmpcpp: Move taglib from native-inputs Paul van der Walt 1 sibling, 1 reply; 4+ messages in thread From: Paul van der Walt @ 2015-03-09 9:57 UTC (permalink / raw) To: Ludovic Courtès; +Cc: guix-devel On 2015-03-08 at 22:30, quoth Ludovic Courtès: >> + ("taglib" ,taglib))) > > ‘taglib’ should go to a new ‘inputs’ field, not to ‘native-inputs’ (the > distinction between the two is for when cross-compiling: ‘native-inputs’ > are things that need to be run on the machine that compiles, whereas > ‘inputs’ is code to run on the target machine.) > > Could you adjust accordingly? Argh, of course you're right -- that was purely me having a fuzzy lack-of-attention moment... Sorry about that, correcting now. p. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 01/01: gnu: ncmpcpp: Enable taglib support. 2015-03-09 9:57 ` Paul van der Walt @ 2015-03-09 19:45 ` Ludovic Courtès 0 siblings, 0 replies; 4+ messages in thread From: Ludovic Courtès @ 2015-03-09 19:45 UTC (permalink / raw) To: Paul van der Walt; +Cc: guix-devel Paul van der Walt <paul@denknerd.org> skribis: > On 2015-03-08 at 22:30, quoth Ludovic Courtès: >>> + ("taglib" ,taglib))) >> >> ‘taglib’ should go to a new ‘inputs’ field, not to ‘native-inputs’ (the >> distinction between the two is for when cross-compiling: ‘native-inputs’ >> are things that need to be run on the machine that compiles, whereas >> ‘inputs’ is code to run on the target machine.) >> >> Could you adjust accordingly? > > Argh, of course you're right -- that was purely me having a fuzzy > lack-of-attention moment... Sorry about that, correcting now. No problem! Paul van der Walt <paul@denknerd.org> skribis: > * gnu/packages/mpd.scm (ncmpcpp): Fixup badly-placed taglib input. Rather “Move TAGLIB from ‘native-inputs’ to ‘inputs’.” Please push, thanks! Ludo’. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] gnu: ncmpcpp: Move taglib from native-inputs. 2015-03-08 21:30 ` 01/01: gnu: ncmpcpp: Enable taglib support Ludovic Courtès 2015-03-09 9:57 ` Paul van der Walt @ 2015-03-09 10:03 ` Paul van der Walt 1 sibling, 0 replies; 4+ messages in thread From: Paul van der Walt @ 2015-03-09 10:03 UTC (permalink / raw) To: guix-devel * gnu/packages/mpd.scm (ncmpcpp): Fixup badly-placed taglib input. --- gnu/packages/mpd.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm index 2f9ad72..f89d3ed 100644 --- a/gnu/packages/mpd.scm +++ b/gnu/packages/mpd.scm @@ -191,13 +191,13 @@ terminal using ncurses.") (inputs `(("libmpdclient" ,libmpdclient) ("boost" ,boost) ("readline" ,readline) - ("ncurses" ,ncurses))) + ("ncurses" ,ncurses) + ("taglib" ,taglib))) (native-inputs `(("pkg-config" ,pkg-config) ("automake" ,automake) ("autoconf" ,autoconf) - ("libtool" ,libtool) - ("taglib" ,taglib))) + ("libtool" ,libtool))) (arguments '(#:configure-flags '("BOOST_LIB_SUFFIX=" "--with-taglib") -- 2.3.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-09 19:45 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20150307131259.22314.37235@vcs.savannah.gnu.org> [not found] ` <E1YUEXM-0005oq-0e@vcs.savannah.gnu.org> 2015-03-08 21:30 ` 01/01: gnu: ncmpcpp: Enable taglib support Ludovic Courtès 2015-03-09 9:57 ` Paul van der Walt 2015-03-09 19:45 ` Ludovic Courtès 2015-03-09 10:03 ` [PATCH] gnu: ncmpcpp: Move taglib from native-inputs Paul van der Walt
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/guix.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.